All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] [RFC] arm: use PSCI if available
Date: Tue, 26 Mar 2013 14:58:54 +0000	[thread overview]
Message-ID: <201303261458.55183.arnd@arndb.de> (raw)
In-Reply-To: <1364308875-26484-6-git-send-email-stefano.stabellini@eu.citrix.com>

On Tuesday 26 March 2013, Stefano Stabellini wrote:
> Check for the presence of PSCI before setting smp_ops, use PSCI if it is
> available.
> 
> This is useful because at least when running on Xen it's possible to have a
> PSCI node for example on a Versatile Express or an Exynos5 machine. In these
> cases the PSCI SMP calls should be the ones to be called.
> 
> Remove virt_smp_ops and platsmp.c from mach-virt because they aren't needed
> anymore.

Very nice, I had a similar idea but had not gotten around to write a patch.
This fits in nicely with my plans to make all fields of machine_desc optional.

>  void __init smp_set_ops(struct smp_operations *ops)
>  {
> -       if (ops)
> +       int rc = -ENODEV;
> +#ifdef CONFIG_ARM_PSCI
> +       rc = psci_init(&smp_ops);
> +#endif
> +       if (rc && ops)
>                smp_ops = *ops;
>  };

Could you move this into the caller, i.e. setup_arch() so we call smp_set_ops
either for psci_smp_ops or for machine_desc->smp?

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, konrad.wilk@oracle.com,
	Ian.Campbell@citrix.com, will.deacon@arm.com,
	marc.zyngier@arm.com, linux@arm.linux.org.uk, nico@linaro.org
Subject: Re: [PATCH v2 6/6] [RFC] arm: use PSCI if available
Date: Tue, 26 Mar 2013 14:58:54 +0000	[thread overview]
Message-ID: <201303261458.55183.arnd@arndb.de> (raw)
In-Reply-To: <1364308875-26484-6-git-send-email-stefano.stabellini@eu.citrix.com>

On Tuesday 26 March 2013, Stefano Stabellini wrote:
> Check for the presence of PSCI before setting smp_ops, use PSCI if it is
> available.
> 
> This is useful because at least when running on Xen it's possible to have a
> PSCI node for example on a Versatile Express or an Exynos5 machine. In these
> cases the PSCI SMP calls should be the ones to be called.
> 
> Remove virt_smp_ops and platsmp.c from mach-virt because they aren't needed
> anymore.

Very nice, I had a similar idea but had not gotten around to write a patch.
This fits in nicely with my plans to make all fields of machine_desc optional.

>  void __init smp_set_ops(struct smp_operations *ops)
>  {
> -       if (ops)
> +       int rc = -ENODEV;
> +#ifdef CONFIG_ARM_PSCI
> +       rc = psci_init(&smp_ops);
> +#endif
> +       if (rc && ops)
>                smp_ops = *ops;
>  };

Could you move this into the caller, i.e. setup_arch() so we call smp_set_ops
either for psci_smp_ops or for machine_desc->smp?

	Arnd

  reply	other threads:[~2013-03-26 14:58 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26 14:40 [PATCH v2 0/6] xen/arm: move to mach-virt and support SMP Stefano Stabellini
2013-03-26 14:40 ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 1/6] xen/arm: actually pass a non-NULL percpu pointer to request_percpu_irq Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 2/6] xen/arm: SMP support Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 3/6] xen: move the xenvm machine to mach-virt Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 4/6] xen/arm: implement HYPERVISOR_vcpu_op Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 5/6] xenvm: add a simple PSCI node and a second cpu Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 15:00   ` Arnd Bergmann
2013-03-26 15:00     ` Arnd Bergmann
2013-03-26 16:39     ` Stefano Stabellini
2013-03-26 16:39       ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 6/6] [RFC] arm: use PSCI if available Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:58   ` Arnd Bergmann [this message]
2013-03-26 14:58     ` Arnd Bergmann
2013-03-26 15:09     ` Stefano Stabellini
2013-03-26 15:09       ` Stefano Stabellini
2013-03-26 15:04   ` Will Deacon
2013-03-26 15:04     ` Will Deacon
2013-03-26 15:25     ` Stefano Stabellini
2013-03-26 15:25       ` Stefano Stabellini
2013-03-26 15:37       ` Will Deacon
2013-03-26 15:37         ` Will Deacon
2013-03-26 15:46         ` Arnd Bergmann
2013-03-26 15:46           ` Arnd Bergmann
2013-03-26 15:46           ` Arnd Bergmann
2013-03-26 15:55           ` Stefano Stabellini
2013-03-26 15:55             ` Stefano Stabellini
2013-03-26 16:03           ` Nicolas Pitre
2013-03-26 16:03             ` Nicolas Pitre
2013-03-26 16:03             ` Nicolas Pitre
2013-03-27 11:15             ` Stefano Stabellini
2013-03-27 11:15               ` Stefano Stabellini
2013-03-26 15:49         ` Stefano Stabellini
2013-03-26 15:49           ` Stefano Stabellini
2013-03-26 15:49           ` Stefano Stabellini
2013-03-26 16:01         ` Nicolas Pitre
2013-03-26 16:01           ` Nicolas Pitre
2013-03-26 16:01           ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303261458.55183.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.