All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] [RFC] arm: use PSCI if available
Date: Tue, 26 Mar 2013 15:46:49 +0000	[thread overview]
Message-ID: <201303261546.50194.arnd@arndb.de> (raw)
In-Reply-To: <20130326153730.GA22368@mudshark.cambridge.arm.com>

On Tuesday 26 March 2013, Will Deacon wrote:
> > They can even base the implementation of their smp_ops on the current
> > psci code, in order to facilitate that I could get rid of psci_ops
> > (which initialization is based on device tree) and export the psci_cpu_*
> > functions instead, so that they can be called directly by other smp_ops.
> 
> Again, I think this destroys the layering. The whole point is that the PSCI
> functions are called from within something that understands precisely how to
> talk to the firmware and what it is capable of.

Right, we probably the psci smp ops to be separate from the rest of the psci
code, but I also think that Stefano is right that we should let any platform
use the psci smp ops if possible, rather than having to implement their own.

> > > If this can indeed work for the virtual platforms (Xen and KVM), then I
> > > think it would be better expressed using `virt' smp_ops, which map directly
> > > to PSCI, rather than putting them here. Even then, it's tying KVM and Xen
> > > together on the firmware side of things...
> > 
> > Keep in mind that dom0 on Xen boots as a native machine (versatile
> > express or exynos5 for example) with a Xen hypervisor node on it.  We
> > would need to find a way to override the default machine smp_ops with
> > a set of xen_smp_ops early at boot.
> > I don't like this option very much, I think is fragile.
> 
> Why can't dom0 use whatever smp ops the native machine would use?

The part that I'm most interested in is making it possible for a platform
to kill off its native smp ops in the kernel by implementing the psci
ops. I think it's a good strategy to use psci by default if both 
platform and psci implementations are available.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Will Deacon <will.deacon@arm.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"nico@linaro.org" <nico@linaro.org>
Subject: Re: [PATCH v2 6/6] [RFC] arm: use PSCI if available
Date: Tue, 26 Mar 2013 15:46:49 +0000	[thread overview]
Message-ID: <201303261546.50194.arnd@arndb.de> (raw)
In-Reply-To: <20130326153730.GA22368@mudshark.cambridge.arm.com>

On Tuesday 26 March 2013, Will Deacon wrote:
> > They can even base the implementation of their smp_ops on the current
> > psci code, in order to facilitate that I could get rid of psci_ops
> > (which initialization is based on device tree) and export the psci_cpu_*
> > functions instead, so that they can be called directly by other smp_ops.
> 
> Again, I think this destroys the layering. The whole point is that the PSCI
> functions are called from within something that understands precisely how to
> talk to the firmware and what it is capable of.

Right, we probably the psci smp ops to be separate from the rest of the psci
code, but I also think that Stefano is right that we should let any platform
use the psci smp ops if possible, rather than having to implement their own.

> > > If this can indeed work for the virtual platforms (Xen and KVM), then I
> > > think it would be better expressed using `virt' smp_ops, which map directly
> > > to PSCI, rather than putting them here. Even then, it's tying KVM and Xen
> > > together on the firmware side of things...
> > 
> > Keep in mind that dom0 on Xen boots as a native machine (versatile
> > express or exynos5 for example) with a Xen hypervisor node on it.  We
> > would need to find a way to override the default machine smp_ops with
> > a set of xen_smp_ops early at boot.
> > I don't like this option very much, I think is fragile.
> 
> Why can't dom0 use whatever smp ops the native machine would use?

The part that I'm most interested in is making it possible for a platform
to kill off its native smp ops in the kernel by implementing the psci
ops. I think it's a good strategy to use psci by default if both 
platform and psci implementations are available.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Will Deacon <will.deacon@arm.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"nico@linaro.org" <nico@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 6/6] [RFC] arm: use PSCI if available
Date: Tue, 26 Mar 2013 15:46:49 +0000	[thread overview]
Message-ID: <201303261546.50194.arnd@arndb.de> (raw)
In-Reply-To: <20130326153730.GA22368@mudshark.cambridge.arm.com>

On Tuesday 26 March 2013, Will Deacon wrote:
> > They can even base the implementation of their smp_ops on the current
> > psci code, in order to facilitate that I could get rid of psci_ops
> > (which initialization is based on device tree) and export the psci_cpu_*
> > functions instead, so that they can be called directly by other smp_ops.
> 
> Again, I think this destroys the layering. The whole point is that the PSCI
> functions are called from within something that understands precisely how to
> talk to the firmware and what it is capable of.

Right, we probably the psci smp ops to be separate from the rest of the psci
code, but I also think that Stefano is right that we should let any platform
use the psci smp ops if possible, rather than having to implement their own.

> > > If this can indeed work for the virtual platforms (Xen and KVM), then I
> > > think it would be better expressed using `virt' smp_ops, which map directly
> > > to PSCI, rather than putting them here. Even then, it's tying KVM and Xen
> > > together on the firmware side of things...
> > 
> > Keep in mind that dom0 on Xen boots as a native machine (versatile
> > express or exynos5 for example) with a Xen hypervisor node on it.  We
> > would need to find a way to override the default machine smp_ops with
> > a set of xen_smp_ops early at boot.
> > I don't like this option very much, I think is fragile.
> 
> Why can't dom0 use whatever smp ops the native machine would use?

The part that I'm most interested in is making it possible for a platform
to kill off its native smp ops in the kernel by implementing the psci
ops. I think it's a good strategy to use psci by default if both 
platform and psci implementations are available.

	Arnd

  reply	other threads:[~2013-03-26 15:46 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26 14:40 [PATCH v2 0/6] xen/arm: move to mach-virt and support SMP Stefano Stabellini
2013-03-26 14:40 ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 1/6] xen/arm: actually pass a non-NULL percpu pointer to request_percpu_irq Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 2/6] xen/arm: SMP support Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 3/6] xen: move the xenvm machine to mach-virt Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 4/6] xen/arm: implement HYPERVISOR_vcpu_op Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 5/6] xenvm: add a simple PSCI node and a second cpu Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 15:00   ` Arnd Bergmann
2013-03-26 15:00     ` Arnd Bergmann
2013-03-26 16:39     ` Stefano Stabellini
2013-03-26 16:39       ` Stefano Stabellini
2013-03-26 14:41 ` [PATCH v2 6/6] [RFC] arm: use PSCI if available Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:41   ` Stefano Stabellini
2013-03-26 14:58   ` Arnd Bergmann
2013-03-26 14:58     ` Arnd Bergmann
2013-03-26 15:09     ` Stefano Stabellini
2013-03-26 15:09       ` Stefano Stabellini
2013-03-26 15:04   ` Will Deacon
2013-03-26 15:04     ` Will Deacon
2013-03-26 15:25     ` Stefano Stabellini
2013-03-26 15:25       ` Stefano Stabellini
2013-03-26 15:37       ` Will Deacon
2013-03-26 15:37         ` Will Deacon
2013-03-26 15:46         ` Arnd Bergmann [this message]
2013-03-26 15:46           ` Arnd Bergmann
2013-03-26 15:46           ` Arnd Bergmann
2013-03-26 15:55           ` Stefano Stabellini
2013-03-26 15:55             ` Stefano Stabellini
2013-03-26 16:03           ` Nicolas Pitre
2013-03-26 16:03             ` Nicolas Pitre
2013-03-26 16:03             ` Nicolas Pitre
2013-03-27 11:15             ` Stefano Stabellini
2013-03-27 11:15               ` Stefano Stabellini
2013-03-26 15:49         ` Stefano Stabellini
2013-03-26 15:49           ` Stefano Stabellini
2013-03-26 15:49           ` Stefano Stabellini
2013-03-26 16:01         ` Nicolas Pitre
2013-03-26 16:01           ` Nicolas Pitre
2013-03-26 16:01           ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303261546.50194.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.