From: Joerg Roedel <joro@8bytes.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: zsmalloc: Fix link error on ARM
Date: Wed, 27 Mar 2013 00:03:59 +0100 [thread overview]
Message-ID: <20130326230359.GD30540@8bytes.org> (raw)
In-Reply-To: <20130326224536.GA29952@kroah.com>
On Tue, Mar 26, 2013 at 03:45:36PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Mar 26, 2013 at 11:33:52PM +0100, Joerg Roedel wrote:
> > Testing the arm chromebook config against the upstream
> > kernel produces a linker error for the zsmalloc module from
> > staging. The symbol flush_tlb_kernel_range is not available
> > there. Fix this by removing the reimplementation of
> > unmap_kernel_range in the zsmalloc module and using the
> > function directly.
> >
> > Signed-off-by: Joerg Roedel <joro@8bytes.org>
>
> Why is this not an error for any other architecture? Why is arm
> special?
The version of the function __zs_unmap_object() which uses
flush_tlb_kernel_range() in the zsmalloc driver is only compiled in when
USE_PGTABLE_MAPPING is defined. And USE_PGTABLE_MAPPING is defined in
the same file only when CONFIG_ARM is defined. So this happens only on
ARM.
Regards,
Joerg
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: zsmalloc: Fix link error on ARM
Date: Wed, 27 Mar 2013 00:03:59 +0100 [thread overview]
Message-ID: <20130326230359.GD30540@8bytes.org> (raw)
In-Reply-To: <20130326224536.GA29952@kroah.com>
On Tue, Mar 26, 2013 at 03:45:36PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Mar 26, 2013 at 11:33:52PM +0100, Joerg Roedel wrote:
> > Testing the arm chromebook config against the upstream
> > kernel produces a linker error for the zsmalloc module from
> > staging. The symbol flush_tlb_kernel_range is not available
> > there. Fix this by removing the reimplementation of
> > unmap_kernel_range in the zsmalloc module and using the
> > function directly.
> >
> > Signed-off-by: Joerg Roedel <joro@8bytes.org>
>
> Why is this not an error for any other architecture? Why is arm
> special?
The version of the function __zs_unmap_object() which uses
flush_tlb_kernel_range() in the zsmalloc driver is only compiled in when
USE_PGTABLE_MAPPING is defined. And USE_PGTABLE_MAPPING is defined in
the same file only when CONFIG_ARM is defined. So this happens only on
ARM.
Regards,
Joerg
next prev parent reply other threads:[~2013-03-26 23:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 22:33 [PATCH] staging: zsmalloc: Fix link error on ARM Joerg Roedel
2013-03-26 22:33 ` Joerg Roedel
2013-03-26 22:45 ` Greg Kroah-Hartman
2013-03-26 22:45 ` Greg Kroah-Hartman
2013-03-26 23:03 ` Joerg Roedel [this message]
2013-03-26 23:03 ` Joerg Roedel
2013-03-26 23:09 ` Greg Kroah-Hartman
2013-03-26 23:09 ` Greg Kroah-Hartman
2013-03-26 23:19 ` Joerg Roedel
2013-03-26 23:19 ` Joerg Roedel
2013-03-26 23:24 ` Greg Kroah-Hartman
2013-03-26 23:24 ` Greg Kroah-Hartman
2013-03-26 23:47 ` Joerg Roedel
2013-03-26 23:47 ` Joerg Roedel
2013-03-27 0:05 ` Minchan Kim
2013-03-27 0:05 ` Minchan Kim
2013-03-27 0:23 ` Joerg Roedel
2013-03-27 0:23 ` Joerg Roedel
2013-03-27 0:43 ` Joerg Roedel
2013-03-27 0:43 ` Joerg Roedel
2013-03-27 1:09 ` Minchan Kim
2013-03-27 1:09 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326230359.GD30540@8bytes.org \
--to=joro@8bytes.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.