From: Joerg Roedel <joro@8bytes.org>
To: Minchan Kim <minchan.kim@lge.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] staging: zsmalloc: Fix link error on ARM
Date: Wed, 27 Mar 2013 01:43:14 +0100 [thread overview]
Message-ID: <20130327004314.GH30540@8bytes.org> (raw)
In-Reply-To: <20130327000552.GA13283@blaptop>
On Wed, Mar 27, 2013 at 09:05:52AM +0900, Minchan Kim wrote:
> And please Cc stable.
Okay, here it is. The result is compile-tested.
Changes since v1:
* Remove the module-export for unmap_kernel_range and make zsmalloc
built-in instead
Here is the patch:
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Minchan Kim <minchan.kim@lge.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] staging: zsmalloc: Fix link error on ARM
Date: Wed, 27 Mar 2013 01:43:14 +0100 [thread overview]
Message-ID: <20130327004314.GH30540@8bytes.org> (raw)
In-Reply-To: <20130327000552.GA13283@blaptop>
On Wed, Mar 27, 2013 at 09:05:52AM +0900, Minchan Kim wrote:
> And please Cc stable.
Okay, here it is. The result is compile-tested.
Changes since v1:
* Remove the module-export for unmap_kernel_range and make zsmalloc
built-in instead
Here is the patch:
>From 2b70502720b36909f9f39bdf27be21321a219c31 Mon Sep 17 00:00:00 2001
From: Joerg Roedel <joro@8bytes.org>
Date: Tue, 26 Mar 2013 23:24:22 +0100
Subject: [PATCH v2] staging: zsmalloc: Fix link error on ARM
Testing the arm chromebook config against the upstream
kernel produces a linker error for the zsmalloc module from
staging. The symbol flush_tlb_kernel_range is not available
there. Fix this by removing the reimplementation of
unmap_kernel_range in the zsmalloc module and using the
function directly. The unmap_kernel_range function is not
usable by modules, so also disallow building the driver as a
module for now.
Cc: stable@vger.kernel.org
Signed-off-by: Joerg Roedel <joro@8bytes.org>
---
drivers/staging/zsmalloc/Kconfig | 2 +-
drivers/staging/zsmalloc/zsmalloc-main.c | 5 +----
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/zsmalloc/Kconfig b/drivers/staging/zsmalloc/Kconfig
index 9084565..7fab032 100644
--- a/drivers/staging/zsmalloc/Kconfig
+++ b/drivers/staging/zsmalloc/Kconfig
@@ -1,5 +1,5 @@
config ZSMALLOC
- tristate "Memory allocator for compressed pages"
+ bool "Memory allocator for compressed pages"
default n
help
zsmalloc is a slab-based memory allocator designed to store
diff --git a/drivers/staging/zsmalloc/zsmalloc-main.c b/drivers/staging/zsmalloc/zsmalloc-main.c
index e78d262..324e123 100644
--- a/drivers/staging/zsmalloc/zsmalloc-main.c
+++ b/drivers/staging/zsmalloc/zsmalloc-main.c
@@ -656,11 +656,8 @@ static inline void __zs_unmap_object(struct mapping_area *area,
struct page *pages[2], int off, int size)
{
unsigned long addr = (unsigned long)area->vm_addr;
- unsigned long end = addr + (PAGE_SIZE * 2);
- flush_cache_vunmap(addr, end);
- unmap_kernel_range_noflush(addr, PAGE_SIZE * 2);
- flush_tlb_kernel_range(addr, end);
+ unmap_kernel_range(addr, PAGE_SIZE * 2);
}
#else /* USE_PGTABLE_MAPPING */
--
1.7.9.5
next prev parent reply other threads:[~2013-03-27 0:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 22:33 [PATCH] staging: zsmalloc: Fix link error on ARM Joerg Roedel
2013-03-26 22:33 ` Joerg Roedel
2013-03-26 22:45 ` Greg Kroah-Hartman
2013-03-26 22:45 ` Greg Kroah-Hartman
2013-03-26 23:03 ` Joerg Roedel
2013-03-26 23:03 ` Joerg Roedel
2013-03-26 23:09 ` Greg Kroah-Hartman
2013-03-26 23:09 ` Greg Kroah-Hartman
2013-03-26 23:19 ` Joerg Roedel
2013-03-26 23:19 ` Joerg Roedel
2013-03-26 23:24 ` Greg Kroah-Hartman
2013-03-26 23:24 ` Greg Kroah-Hartman
2013-03-26 23:47 ` Joerg Roedel
2013-03-26 23:47 ` Joerg Roedel
2013-03-27 0:05 ` Minchan Kim
2013-03-27 0:05 ` Minchan Kim
2013-03-27 0:23 ` Joerg Roedel
2013-03-27 0:23 ` Joerg Roedel
2013-03-27 0:43 ` Joerg Roedel [this message]
2013-03-27 0:43 ` Joerg Roedel
2013-03-27 1:09 ` Minchan Kim
2013-03-27 1:09 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327004314.GH30540@8bytes.org \
--to=joro@8bytes.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.