All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] [RFC] arm: use PSCI if available
Date: Wed, 27 Mar 2013 19:14:13 +0000	[thread overview]
Message-ID: <201303271914.13544.arnd@arndb.de> (raw)
In-Reply-To: <20130327181206.GD20990@mudshark.cambridge.arm.com>

On Wednesday 27 March 2013, Will Deacon wrote:
> The interface is standard. The functions have well-defined headers and can
> be called in the same way between implementations. The difference is in the
> semantics of the parameters. For example:
> 
>   int cpu_off(u32 power_state);

I think that is the opposite of well-defined :(

> If you look at the power_state parameter, it's actually a struct (see struct
> psci_power_state) with a u16 id field. The current specification describes
> that field as `This is platform specific, the number is understood by the
> firmware, and used to program the power controller.'.
> 
> So unless we get everybody to agree on the definition of that field, we
> can't blindly plug the interfaces together. Furthermore, there are other
> parameters like this and, as new functions are specified, I would expect
> them to grow.

I think it's expected that there will be vendor specific extensions,
but any interface that is part of the standard has to be completely
specified there, anything else is pure madness.

Perhaps we could extend the device tree binding to add the missing bits,
and pass the values that you are supposed to pass there as properties
of the node, but it would be much more logical to require the interface
to be well-behaved in the first place.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Will Deacon <will.deacon@arm.com>
Cc: Rob Herring <robherring2@gmail.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"nico@linaro.org" <nico@linaro.org>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3] [RFC] arm: use PSCI if available
Date: Wed, 27 Mar 2013 19:14:13 +0000	[thread overview]
Message-ID: <201303271914.13544.arnd@arndb.de> (raw)
In-Reply-To: <20130327181206.GD20990@mudshark.cambridge.arm.com>

On Wednesday 27 March 2013, Will Deacon wrote:
> The interface is standard. The functions have well-defined headers and can
> be called in the same way between implementations. The difference is in the
> semantics of the parameters. For example:
> 
>   int cpu_off(u32 power_state);

I think that is the opposite of well-defined :(

> If you look at the power_state parameter, it's actually a struct (see struct
> psci_power_state) with a u16 id field. The current specification describes
> that field as `This is platform specific, the number is understood by the
> firmware, and used to program the power controller.'.
> 
> So unless we get everybody to agree on the definition of that field, we
> can't blindly plug the interfaces together. Furthermore, there are other
> parameters like this and, as new functions are specified, I would expect
> them to grow.

I think it's expected that there will be vendor specific extensions,
but any interface that is part of the standard has to be completely
specified there, anything else is pure madness.

Perhaps we could extend the device tree binding to add the missing bits,
and pass the values that you are supposed to pass there as properties
of the node, but it would be much more logical to require the interface
to be well-behaved in the first place.

	Arnd

  parent reply	other threads:[~2013-03-27 19:14 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 12:50 [PATCH v3] [RFC] arm: use PSCI if available Stefano Stabellini
2013-03-27 12:50 ` Stefano Stabellini
2013-03-27 12:50 ` Stefano Stabellini
2013-03-27 13:35 ` Marc Zyngier
2013-03-27 13:35   ` Marc Zyngier
2013-03-27 16:20   ` Rob Herring
2013-03-27 16:20     ` Rob Herring
2013-03-27 13:38 ` Will Deacon
2013-03-27 13:38   ` Will Deacon
2013-03-27 16:23   ` Stefano Stabellini
2013-03-27 16:23     ` Stefano Stabellini
2013-03-27 16:35     ` Rob Herring
2013-03-27 16:35       ` Rob Herring
2013-03-27 17:10       ` Stefano Stabellini
2013-03-27 17:10         ` Stefano Stabellini
2013-03-27 17:24         ` Nicolas Pitre
2013-03-27 17:24           ` Nicolas Pitre
2013-03-27 18:22           ` Stefano Stabellini
2013-03-27 18:22             ` Stefano Stabellini
2013-03-27 17:45         ` Rob Herring
2013-03-27 17:45           ` Rob Herring
2013-03-27 18:03           ` Arnd Bergmann
2013-03-27 18:03             ` Arnd Bergmann
2013-03-27 18:14             ` Stefano Stabellini
2013-03-27 18:14               ` Stefano Stabellini
2013-03-27 17:23     ` Will Deacon
2013-03-27 17:23       ` Will Deacon
2013-03-28 12:48       ` Stefano Stabellini
2013-03-28 12:48         ` Stefano Stabellini
2013-03-28 14:51         ` Nicolas Pitre
2013-03-28 14:51           ` Nicolas Pitre
2013-03-28 15:04           ` Rob Herring
2013-03-28 15:04             ` Rob Herring
2013-03-28 15:36             ` Stefano Stabellini
2013-03-28 15:36               ` Stefano Stabellini
2013-03-28 15:39             ` Nicolas Pitre
2013-03-28 15:39               ` Nicolas Pitre
2013-03-28 16:00               ` Will Deacon
2013-03-28 16:00                 ` Will Deacon
2013-03-28 16:06                 ` Nicolas Pitre
2013-03-28 16:06                   ` Nicolas Pitre
2013-03-28 16:20                 ` Stefano Stabellini
2013-03-28 16:20                   ` Stefano Stabellini
2013-03-28 18:38               ` Rob Herring
2013-03-28 18:38                 ` Rob Herring
2013-03-29 13:22                 ` Stefano Stabellini
2013-03-29 13:22                   ` Stefano Stabellini
2013-03-29 13:54                   ` Rob Herring
2013-03-29 13:54                     ` Rob Herring
2013-03-29 14:47                     ` Stefano Stabellini
2013-03-29 14:47                       ` Stefano Stabellini
2013-03-27 16:33   ` Rob Herring
2013-03-27 16:33     ` Rob Herring
2013-03-27 17:05     ` Will Deacon
2013-03-27 17:05       ` Will Deacon
2013-03-27 17:50       ` Arnd Bergmann
2013-03-27 17:50         ` Arnd Bergmann
2013-03-27 18:12         ` Will Deacon
2013-03-27 18:12           ` Will Deacon
2013-03-27 19:10           ` Rob Herring
2013-03-27 19:10             ` Rob Herring
2013-03-27 19:14           ` Arnd Bergmann [this message]
2013-03-27 19:14             ` Arnd Bergmann
2013-03-27 14:55 ` Rob Herring
2013-03-27 14:55   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303271914.13544.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.