All of lore.kernel.org
 help / color / mirror / Atom feed
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] [RFC] arm: use PSCI if available
Date: Wed, 27 Mar 2013 11:20:32 -0500	[thread overview]
Message-ID: <51531C50.1010106@gmail.com> (raw)
In-Reply-To: <5152F591.40201@arm.com>

On 03/27/2013 08:35 AM, Marc Zyngier wrote:
> On 27/03/13 12:50, Stefano Stabellini wrote:
>> Check for the presence of PSCI before setting smp_ops, use PSCI if it is
>> available.
>>
>> This is useful because at least when running on Xen it's possible to have a
>> PSCI node for example on a Versatile Express or an Exynos5 machine. In these
>> cases the PSCI SMP calls should be the ones to be called.
>>
>> Remove virt_smp_ops and platsmp.c from mach-virt because they aren't needed
>> anymore.

[...]

>> +static void __cpuinit psci_secondary_init(unsigned int cpu)
>> +{
>> +	gic_secondary_init(0);
>> +}
> 
> So here we end-up with a dependency between SMP, PSCI, and GIC.
> I really can't see that being a good idea, even I like the general
> direction of this series.
> 

The GIC dependency should be removed with Catalin's series to use
notifiers for GIC cpu interface init.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"nico@linaro.org" <nico@linaro.org>,
	Will Deacon <Will.Deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v3] [RFC] arm: use PSCI if available
Date: Wed, 27 Mar 2013 11:20:32 -0500	[thread overview]
Message-ID: <51531C50.1010106@gmail.com> (raw)
In-Reply-To: <5152F591.40201@arm.com>

On 03/27/2013 08:35 AM, Marc Zyngier wrote:
> On 27/03/13 12:50, Stefano Stabellini wrote:
>> Check for the presence of PSCI before setting smp_ops, use PSCI if it is
>> available.
>>
>> This is useful because at least when running on Xen it's possible to have a
>> PSCI node for example on a Versatile Express or an Exynos5 machine. In these
>> cases the PSCI SMP calls should be the ones to be called.
>>
>> Remove virt_smp_ops and platsmp.c from mach-virt because they aren't needed
>> anymore.

[...]

>> +static void __cpuinit psci_secondary_init(unsigned int cpu)
>> +{
>> +	gic_secondary_init(0);
>> +}
> 
> So here we end-up with a dependency between SMP, PSCI, and GIC.
> I really can't see that being a good idea, even I like the general
> direction of this series.
> 

The GIC dependency should be removed with Catalin's series to use
notifiers for GIC cpu interface init.

Rob

  reply	other threads:[~2013-03-27 16:20 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 12:50 [PATCH v3] [RFC] arm: use PSCI if available Stefano Stabellini
2013-03-27 12:50 ` Stefano Stabellini
2013-03-27 12:50 ` Stefano Stabellini
2013-03-27 13:35 ` Marc Zyngier
2013-03-27 13:35   ` Marc Zyngier
2013-03-27 16:20   ` Rob Herring [this message]
2013-03-27 16:20     ` Rob Herring
2013-03-27 13:38 ` Will Deacon
2013-03-27 13:38   ` Will Deacon
2013-03-27 16:23   ` Stefano Stabellini
2013-03-27 16:23     ` Stefano Stabellini
2013-03-27 16:35     ` Rob Herring
2013-03-27 16:35       ` Rob Herring
2013-03-27 17:10       ` Stefano Stabellini
2013-03-27 17:10         ` Stefano Stabellini
2013-03-27 17:24         ` Nicolas Pitre
2013-03-27 17:24           ` Nicolas Pitre
2013-03-27 18:22           ` Stefano Stabellini
2013-03-27 18:22             ` Stefano Stabellini
2013-03-27 17:45         ` Rob Herring
2013-03-27 17:45           ` Rob Herring
2013-03-27 18:03           ` Arnd Bergmann
2013-03-27 18:03             ` Arnd Bergmann
2013-03-27 18:14             ` Stefano Stabellini
2013-03-27 18:14               ` Stefano Stabellini
2013-03-27 17:23     ` Will Deacon
2013-03-27 17:23       ` Will Deacon
2013-03-28 12:48       ` Stefano Stabellini
2013-03-28 12:48         ` Stefano Stabellini
2013-03-28 14:51         ` Nicolas Pitre
2013-03-28 14:51           ` Nicolas Pitre
2013-03-28 15:04           ` Rob Herring
2013-03-28 15:04             ` Rob Herring
2013-03-28 15:36             ` Stefano Stabellini
2013-03-28 15:36               ` Stefano Stabellini
2013-03-28 15:39             ` Nicolas Pitre
2013-03-28 15:39               ` Nicolas Pitre
2013-03-28 16:00               ` Will Deacon
2013-03-28 16:00                 ` Will Deacon
2013-03-28 16:06                 ` Nicolas Pitre
2013-03-28 16:06                   ` Nicolas Pitre
2013-03-28 16:20                 ` Stefano Stabellini
2013-03-28 16:20                   ` Stefano Stabellini
2013-03-28 18:38               ` Rob Herring
2013-03-28 18:38                 ` Rob Herring
2013-03-29 13:22                 ` Stefano Stabellini
2013-03-29 13:22                   ` Stefano Stabellini
2013-03-29 13:54                   ` Rob Herring
2013-03-29 13:54                     ` Rob Herring
2013-03-29 14:47                     ` Stefano Stabellini
2013-03-29 14:47                       ` Stefano Stabellini
2013-03-27 16:33   ` Rob Herring
2013-03-27 16:33     ` Rob Herring
2013-03-27 17:05     ` Will Deacon
2013-03-27 17:05       ` Will Deacon
2013-03-27 17:50       ` Arnd Bergmann
2013-03-27 17:50         ` Arnd Bergmann
2013-03-27 18:12         ` Will Deacon
2013-03-27 18:12           ` Will Deacon
2013-03-27 19:10           ` Rob Herring
2013-03-27 19:10             ` Rob Herring
2013-03-27 19:14           ` Arnd Bergmann
2013-03-27 19:14             ` Arnd Bergmann
2013-03-27 14:55 ` Rob Herring
2013-03-27 14:55   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51531C50.1010106@gmail.com \
    --to=robherring2@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.