* [PATCH] drm: don't unlock in the addfb error paths
@ 2013-03-27 20:45 Daniel Vetter
2013-03-28 10:22 ` Ville Syrjälä
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2013-03-27 20:45 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Ray Strode
We don't grab the modeset locks any more since
commit 468174f748603497e73dba9b5c6d1d9f71121486
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Tue Dec 11 00:09:12 2012 +0100
drm: push modeset_lock_all into ->fb_create driver callbacks
Reported-by: Ray Strode <rstrode@redhat.com>
Cc: Ray Strode <rstrode@redhat.com>
Cc: Dave Airlie <airlied@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/drm_crtc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 792c3e3..dd64a06 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -2326,7 +2326,6 @@ int drm_mode_addfb(struct drm_device *dev,
fb = dev->mode_config.funcs->fb_create(dev, file_priv, &r);
if (IS_ERR(fb)) {
DRM_DEBUG_KMS("could not create framebuffer\n");
- drm_modeset_unlock_all(dev);
return PTR_ERR(fb);
}
@@ -2506,7 +2505,6 @@ int drm_mode_addfb2(struct drm_device *dev,
fb = dev->mode_config.funcs->fb_create(dev, file_priv, r);
if (IS_ERR(fb)) {
DRM_DEBUG_KMS("could not create framebuffer\n");
- drm_modeset_unlock_all(dev);
return PTR_ERR(fb);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: don't unlock in the addfb error paths
2013-03-27 20:45 [PATCH] drm: don't unlock in the addfb error paths Daniel Vetter
@ 2013-03-28 10:22 ` Ville Syrjälä
2013-04-11 14:09 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Ville Syrjälä @ 2013-03-28 10:22 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Ray Strode, DRI Development
On Wed, Mar 27, 2013 at 09:45:35PM +0100, Daniel Vetter wrote:
> We don't grab the modeset locks any more since
>
> commit 468174f748603497e73dba9b5c6d1d9f71121486
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Tue Dec 11 00:09:12 2012 +0100
>
> drm: push modeset_lock_all into ->fb_create driver callbacks
>
> Reported-by: Ray Strode <rstrode@redhat.com>
> Cc: Ray Strode <rstrode@redhat.com>
> Cc: Dave Airlie <airlied@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_crtc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 792c3e3..dd64a06 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -2326,7 +2326,6 @@ int drm_mode_addfb(struct drm_device *dev,
> fb = dev->mode_config.funcs->fb_create(dev, file_priv, &r);
> if (IS_ERR(fb)) {
> DRM_DEBUG_KMS("could not create framebuffer\n");
> - drm_modeset_unlock_all(dev);
> return PTR_ERR(fb);
> }
>
> @@ -2506,7 +2505,6 @@ int drm_mode_addfb2(struct drm_device *dev,
> fb = dev->mode_config.funcs->fb_create(dev, file_priv, r);
> if (IS_ERR(fb)) {
> DRM_DEBUG_KMS("could not create framebuffer\n");
> - drm_modeset_unlock_all(dev);
> return PTR_ERR(fb);
> }
>
> --
> 1.7.10.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: don't unlock in the addfb error paths
2013-03-28 10:22 ` Ville Syrjälä
@ 2013-04-11 14:09 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2013-04-11 14:09 UTC (permalink / raw)
To: Ville Syrjälä, Dave Airlie
Cc: Daniel Vetter, Ray Strode, DRI Development
On Thu, Mar 28, 2013 at 12:22:55PM +0200, Ville Syrjälä wrote:
> On Wed, Mar 27, 2013 at 09:45:35PM +0100, Daniel Vetter wrote:
> > We don't grab the modeset locks any more since
> >
> > commit 468174f748603497e73dba9b5c6d1d9f71121486
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date: Tue Dec 11 00:09:12 2012 +0100
> >
> > drm: push modeset_lock_all into ->fb_create driver callbacks
> >
> > Reported-by: Ray Strode <rstrode@redhat.com>
> > Cc: Ray Strode <rstrode@redhat.com>
> > Cc: Dave Airlie <airlied@gmail.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Dave?
>
> > ---
> > drivers/gpu/drm/drm_crtc.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> > index 792c3e3..dd64a06 100644
> > --- a/drivers/gpu/drm/drm_crtc.c
> > +++ b/drivers/gpu/drm/drm_crtc.c
> > @@ -2326,7 +2326,6 @@ int drm_mode_addfb(struct drm_device *dev,
> > fb = dev->mode_config.funcs->fb_create(dev, file_priv, &r);
> > if (IS_ERR(fb)) {
> > DRM_DEBUG_KMS("could not create framebuffer\n");
> > - drm_modeset_unlock_all(dev);
> > return PTR_ERR(fb);
> > }
> >
> > @@ -2506,7 +2505,6 @@ int drm_mode_addfb2(struct drm_device *dev,
> > fb = dev->mode_config.funcs->fb_create(dev, file_priv, r);
> > if (IS_ERR(fb)) {
> > DRM_DEBUG_KMS("could not create framebuffer\n");
> > - drm_modeset_unlock_all(dev);
> > return PTR_ERR(fb);
> > }
> >
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Ville Syrjälä
> Intel OTC
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-11 14:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-27 20:45 [PATCH] drm: don't unlock in the addfb error paths Daniel Vetter
2013-03-28 10:22 ` Ville Syrjälä
2013-04-11 14:09 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.