From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified
Date: Thu, 28 Mar 2013 15:25:42 +0000 [thread overview]
Message-ID: <201303281525.42334.arnd@arndb.de> (raw)
In-Reply-To: <20130328145155.GB3368@n2100.arm.linux.org.uk>
On Thursday 28 March 2013, Russell King - ARM Linux wrote:
> Better:
>
> #ifdef CONFIG_OF
> if (!machine_desc->init_irq)
> irqchip_init();
> else
> #endif
> machine_desc->init_irq();
>
> which means we don't even get the test if !OF, and if someone mistakenly
> sets this to NULL for a !OF platform, they get to know about it.
Right. With the new IS_DEFINED() macro, we could even turn this into
if (IS_DEFINED(CONFIG_OF) && !machine_desc->init_irq)
irqchip_init();
else
machine_desc->init_irq();
to the same effect.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
Cc: Rob Herring <robherring2@gmail.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Olof Johansson <olof@lixom.net>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified
Date: Thu, 28 Mar 2013 15:25:42 +0000 [thread overview]
Message-ID: <201303281525.42334.arnd@arndb.de> (raw)
In-Reply-To: <20130328145155.GB3368@n2100.arm.linux.org.uk>
On Thursday 28 March 2013, Russell King - ARM Linux wrote:
> Better:
>
> #ifdef CONFIG_OF
> if (!machine_desc->init_irq)
> irqchip_init();
> else
> #endif
> machine_desc->init_irq();
>
> which means we don't even get the test if !OF, and if someone mistakenly
> sets this to NULL for a !OF platform, they get to know about it.
Right. With the new IS_DEFINED() macro, we could even turn this into
if (IS_DEFINED(CONFIG_OF) && !machine_desc->init_irq)
irqchip_init();
else
machine_desc->init_irq();
to the same effect.
Arnd
next prev parent reply other threads:[~2013-03-28 15:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 9:41 [PATCH 0/2] ARM: Remove boilerplate irqchip_init code Maxime Ripard
2013-03-28 9:41 ` [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified Maxime Ripard
2013-03-28 9:41 ` Maxime Ripard
2013-03-28 14:48 ` Rob Herring
2013-03-28 14:48 ` Rob Herring
2013-03-28 14:51 ` Russell King - ARM Linux
2013-03-28 14:51 ` Russell King - ARM Linux
2013-03-28 15:25 ` Arnd Bergmann [this message]
2013-03-28 15:25 ` Arnd Bergmann
2013-03-28 15:36 ` Russell King - ARM Linux
2013-03-28 15:36 ` Russell King - ARM Linux
2013-03-28 15:49 ` Arnd Bergmann
2013-03-28 15:49 ` Arnd Bergmann
2013-03-28 18:20 ` Maxime Ripard
2013-03-28 18:20 ` Maxime Ripard
2013-03-28 18:40 ` Rob Herring
2013-03-28 18:40 ` Rob Herring
2013-03-28 19:02 ` Russell King - ARM Linux
2013-03-28 19:02 ` Russell King - ARM Linux
2013-03-28 9:41 ` [PATCH 2/2] ARM: remove mach .init_irq for irqchip_init users Maxime Ripard
2013-03-28 9:41 ` Maxime Ripard
2013-03-28 9:41 ` Maxime Ripard
2013-03-28 12:42 ` Simon Horman
2013-03-28 12:42 ` Simon Horman
2013-03-28 12:42 ` Simon Horman
2013-03-28 18:24 ` Maxime Ripard
2013-03-28 18:24 ` Maxime Ripard
2013-03-28 18:24 ` Maxime Ripard
2013-03-29 3:48 ` Simon Horman
2013-03-29 3:48 ` Simon Horman
2013-03-29 3:48 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2013-03-28 20:46 [PATCHv2 0/2] ARM: Remove boilerplate irqchip_init code Maxime Ripard
2013-03-28 20:46 ` [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified Maxime Ripard
2013-03-28 20:46 ` Maxime Ripard
2013-03-28 22:52 ` Rob Herring
2013-03-28 22:52 ` Rob Herring
2013-04-02 18:23 ` Olof Johansson
2013-04-02 18:23 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303281525.42334.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.