All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified
Date: Thu, 28 Mar 2013 19:20:17 +0100	[thread overview]
Message-ID: <515489E1.6070409@free-electrons.com> (raw)
In-Reply-To: <201303281549.49990.arnd@arndb.de>

Le 28/03/2013 16:49, Arnd Bergmann a ?crit :
> On Thursday 28 March 2013, Russell King - ARM Linux wrote:
>> On Thu, Mar 28, 2013 at 03:25:42PM +0000, Arnd Bergmann wrote:
>>>       if (IS_DEFINED(CONFIG_OF) && !machine_desc->init_irq)
>>>               irqchip_init();
>>>       else
>>>               machine_desc->init_irq();
>>>
>>> to the same effect.
>>
>> Provided irqchip_init() keeps its prototype visible, then yes.
> 
> Yes, I checked that before my reply. We have a few function declarations
> that are unfortunately completely hidden when some config symbol is not
> defined, but this is not one of them.

I'll send a v2 with the suggested change.

Thanks!
Maxime


-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Rob Herring <robherring2@gmail.com>,
	Olof Johansson <olof@lixom.net>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified
Date: Thu, 28 Mar 2013 19:20:17 +0100	[thread overview]
Message-ID: <515489E1.6070409@free-electrons.com> (raw)
In-Reply-To: <201303281549.49990.arnd@arndb.de>

Le 28/03/2013 16:49, Arnd Bergmann a écrit :
> On Thursday 28 March 2013, Russell King - ARM Linux wrote:
>> On Thu, Mar 28, 2013 at 03:25:42PM +0000, Arnd Bergmann wrote:
>>>       if (IS_DEFINED(CONFIG_OF) && !machine_desc->init_irq)
>>>               irqchip_init();
>>>       else
>>>               machine_desc->init_irq();
>>>
>>> to the same effect.
>>
>> Provided irqchip_init() keeps its prototype visible, then yes.
> 
> Yes, I checked that before my reply. We have a few function declarations
> that are unfortunately completely hidden when some config symbol is not
> defined, but this is not one of them.

I'll send a v2 with the suggested change.

Thanks!
Maxime


-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-03-28 18:20 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28  9:41 [PATCH 0/2] ARM: Remove boilerplate irqchip_init code Maxime Ripard
2013-03-28  9:41 ` [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified Maxime Ripard
2013-03-28  9:41   ` Maxime Ripard
2013-03-28 14:48   ` Rob Herring
2013-03-28 14:48     ` Rob Herring
2013-03-28 14:51     ` Russell King - ARM Linux
2013-03-28 14:51       ` Russell King - ARM Linux
2013-03-28 15:25       ` Arnd Bergmann
2013-03-28 15:25         ` Arnd Bergmann
2013-03-28 15:36         ` Russell King - ARM Linux
2013-03-28 15:36           ` Russell King - ARM Linux
2013-03-28 15:49           ` Arnd Bergmann
2013-03-28 15:49             ` Arnd Bergmann
2013-03-28 18:20             ` Maxime Ripard [this message]
2013-03-28 18:20               ` Maxime Ripard
2013-03-28 18:40       ` Rob Herring
2013-03-28 18:40         ` Rob Herring
2013-03-28 19:02         ` Russell King - ARM Linux
2013-03-28 19:02           ` Russell King - ARM Linux
2013-03-28  9:41 ` [PATCH 2/2] ARM: remove mach .init_irq for irqchip_init users Maxime Ripard
2013-03-28  9:41   ` Maxime Ripard
2013-03-28  9:41   ` Maxime Ripard
2013-03-28 12:42   ` Simon Horman
2013-03-28 12:42     ` Simon Horman
2013-03-28 12:42     ` Simon Horman
2013-03-28 18:24     ` Maxime Ripard
2013-03-28 18:24       ` Maxime Ripard
2013-03-28 18:24       ` Maxime Ripard
2013-03-29  3:48       ` Simon Horman
2013-03-29  3:48         ` Simon Horman
2013-03-29  3:48         ` Simon Horman
  -- strict thread matches above, loose matches on Subject: below --
2013-03-28 20:46 [PATCHv2 0/2] ARM: Remove boilerplate irqchip_init code Maxime Ripard
2013-03-28 20:46 ` [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified Maxime Ripard
2013-03-28 20:46   ` Maxime Ripard
2013-03-28 22:52   ` Rob Herring
2013-03-28 22:52     ` Rob Herring
2013-04-02 18:23   ` Olof Johansson
2013-04-02 18:23     ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515489E1.6070409@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.