From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Suravee Suthikulpanit
<suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] iommu/amd: Add logic to decode AMD IOMMU event flag
Date: Tue, 2 Apr 2013 18:06:50 +0200 [thread overview]
Message-ID: <20130402160650.GQ30540@8bytes.org> (raw)
In-Reply-To: <515AFC25.5060501-5C7GfCeVMHo@public.gmane.org>
On Tue, Apr 02, 2013 at 10:41:25AM -0500, Suthikulpanit, Suravee wrote:
> Turning this into WARN_ON() at this point might break a lot of
> systems currently out in the field. However, users can always
> switching to use "intremap=off" but this might not be obvious.
A WARN_ON doesn't break systems, it just creates more noise. Probably
enough noise to get board vendors to fix their stuff up. But there is
more to consider before making more noise, of course :)
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] iommu/amd: Add logic to decode AMD IOMMU event flag
Date: Tue, 2 Apr 2013 18:06:50 +0200 [thread overview]
Message-ID: <20130402160650.GQ30540@8bytes.org> (raw)
In-Reply-To: <515AFC25.5060501@amd.com>
On Tue, Apr 02, 2013 at 10:41:25AM -0500, Suthikulpanit, Suravee wrote:
> Turning this into WARN_ON() at this point might break a lot of
> systems currently out in the field. However, users can always
> switching to use "intremap=off" but this might not be obvious.
A WARN_ON doesn't break systems, it just creates more noise. Probably
enough noise to get board vendors to fix their stuff up. But there is
more to consider before making more noise, of course :)
Joerg
next prev parent reply other threads:[~2013-04-02 16:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 23:51 [PATCH 1/3] iommu/amd: Add logic to decode AMD IOMMU event flag suravee.suthikulpanit
2013-03-27 23:51 ` suravee.suthikulpanit
[not found] ` <1364428283-2548-1-git-send-email-suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2013-04-01 13:47 ` Suravee Suthikulanit
2013-04-01 13:47 ` Suravee Suthikulanit
2013-04-02 14:33 ` Joerg Roedel
2013-04-02 14:33 ` Joerg Roedel
[not found] ` <20130402143335.GB15687-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-02 14:39 ` Suravee Suthikulanit
2013-04-02 14:39 ` Suravee Suthikulanit
2013-04-02 14:40 ` Borislav Petkov
2013-04-02 14:40 ` Borislav Petkov
[not found] ` <20130402144037.GE5488-fF5Pk5pvG8Y@public.gmane.org>
2013-04-02 15:03 ` Joerg Roedel
2013-04-02 15:03 ` Joerg Roedel
[not found] ` <20130402150302.GF15687-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-02 15:29 ` Borislav Petkov
2013-04-02 15:29 ` Borislav Petkov
[not found] ` <20130402152956.GE4391-fF5Pk5pvG8Y@public.gmane.org>
2013-04-02 15:41 ` Suravee Suthikulpanit
2013-04-02 15:41 ` Suravee Suthikulpanit
[not found] ` <515AFC25.5060501-5C7GfCeVMHo@public.gmane.org>
2013-04-02 16:06 ` Joerg Roedel [this message]
2013-04-02 16:06 ` Joerg Roedel
2013-04-02 16:04 ` Joerg Roedel
2013-04-02 16:04 ` Joerg Roedel
[not found] ` <20130402160400.GP30540-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-02 16:17 ` Borislav Petkov
2013-04-02 16:17 ` Borislav Petkov
[not found] ` <20130402161757.GC17519-fF5Pk5pvG8Y@public.gmane.org>
2013-04-02 16:33 ` Joerg Roedel
2013-04-02 16:33 ` Joerg Roedel
[not found] ` <20130402163318.GS30540-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-02 19:32 ` Borislav Petkov
2013-04-02 19:32 ` Borislav Petkov
[not found] ` <20130402193240.GF17675-fF5Pk5pvG8Y@public.gmane.org>
2013-04-02 20:59 ` Joerg Roedel
2013-04-02 20:59 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402160650.GQ30540@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.