From: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] iommu/amd: Add logic to decode AMD IOMMU event flag
Date: Tue, 2 Apr 2013 18:17:57 +0200 [thread overview]
Message-ID: <20130402161757.GC17519@pd.tnic> (raw)
In-Reply-To: <20130402160400.GP30540-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
On Tue, Apr 02, 2013 at 06:04:00PM +0200, Joerg Roedel wrote:
> I can certainly write a patch that works around your particular BIOS
> bug. The problem is that such a fix will most certainly break other
> systems.
>
> Unfortunatly there is no reliable way to fixup the IO-APIC-ID->DEVID
> mapping at runtime when the BIOS messed it up. The only thing I can do
> is to check for potential problems and disable the intremap feature
> then, so that the system will at least boot.
Yeah, that could work:
* do not issue message but try to fixup the mapping
* if it works, fine
* if it doesn't, then give up and disable intremap.
And yes, I'm very sceptical about having a WARN_ON and it starts
screaming on machines all over the place. Good luck explaining to
people that you actually wanted to prod BIOS vendors to fix their
monkey-on-crack code but they weren't listening in the first place.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Joerg Roedel <joro@8bytes.org>
Cc: suravee.suthikulpanit@amd.com, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] iommu/amd: Add logic to decode AMD IOMMU event flag
Date: Tue, 2 Apr 2013 18:17:57 +0200 [thread overview]
Message-ID: <20130402161757.GC17519@pd.tnic> (raw)
In-Reply-To: <20130402160400.GP30540@8bytes.org>
On Tue, Apr 02, 2013 at 06:04:00PM +0200, Joerg Roedel wrote:
> I can certainly write a patch that works around your particular BIOS
> bug. The problem is that such a fix will most certainly break other
> systems.
>
> Unfortunatly there is no reliable way to fixup the IO-APIC-ID->DEVID
> mapping at runtime when the BIOS messed it up. The only thing I can do
> is to check for potential problems and disable the intremap feature
> then, so that the system will at least boot.
Yeah, that could work:
* do not issue message but try to fixup the mapping
* if it works, fine
* if it doesn't, then give up and disable intremap.
And yes, I'm very sceptical about having a WARN_ON and it starts
screaming on machines all over the place. Good luck explaining to
people that you actually wanted to prod BIOS vendors to fix their
monkey-on-crack code but they weren't listening in the first place.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-04-02 16:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 23:51 [PATCH 1/3] iommu/amd: Add logic to decode AMD IOMMU event flag suravee.suthikulpanit
2013-03-27 23:51 ` suravee.suthikulpanit
[not found] ` <1364428283-2548-1-git-send-email-suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2013-04-01 13:47 ` Suravee Suthikulanit
2013-04-01 13:47 ` Suravee Suthikulanit
2013-04-02 14:33 ` Joerg Roedel
2013-04-02 14:33 ` Joerg Roedel
[not found] ` <20130402143335.GB15687-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-02 14:39 ` Suravee Suthikulanit
2013-04-02 14:39 ` Suravee Suthikulanit
2013-04-02 14:40 ` Borislav Petkov
2013-04-02 14:40 ` Borislav Petkov
[not found] ` <20130402144037.GE5488-fF5Pk5pvG8Y@public.gmane.org>
2013-04-02 15:03 ` Joerg Roedel
2013-04-02 15:03 ` Joerg Roedel
[not found] ` <20130402150302.GF15687-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-02 15:29 ` Borislav Petkov
2013-04-02 15:29 ` Borislav Petkov
[not found] ` <20130402152956.GE4391-fF5Pk5pvG8Y@public.gmane.org>
2013-04-02 15:41 ` Suravee Suthikulpanit
2013-04-02 15:41 ` Suravee Suthikulpanit
[not found] ` <515AFC25.5060501-5C7GfCeVMHo@public.gmane.org>
2013-04-02 16:06 ` Joerg Roedel
2013-04-02 16:06 ` Joerg Roedel
2013-04-02 16:04 ` Joerg Roedel
2013-04-02 16:04 ` Joerg Roedel
[not found] ` <20130402160400.GP30540-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-02 16:17 ` Borislav Petkov [this message]
2013-04-02 16:17 ` Borislav Petkov
[not found] ` <20130402161757.GC17519-fF5Pk5pvG8Y@public.gmane.org>
2013-04-02 16:33 ` Joerg Roedel
2013-04-02 16:33 ` Joerg Roedel
[not found] ` <20130402163318.GS30540-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-02 19:32 ` Borislav Petkov
2013-04-02 19:32 ` Borislav Petkov
[not found] ` <20130402193240.GF17675-fF5Pk5pvG8Y@public.gmane.org>
2013-04-02 20:59 ` Joerg Roedel
2013-04-02 20:59 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402161757.GC17519@pd.tnic \
--to=bp-gina5biwoiwzqb+pc5nmwq@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.