From: Arnd Bergmann <arnd@arndb.de>
To: balbi@ti.com
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
gregkh@linuxfoundation.org, akpm@linux-foundation.org,
swarren@wwwdotorg.org, sylvester.nawrocki@gmail.com,
rob@landley.net, netdev@vger.kernel.org, davem@davemloft.net,
cesarb@cesarb.net, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
tony@atomide.com, grant.likely@secretlab.ca,
rob.herring@calxeda.com, b-cousson@ti.com,
linux@arm.linux.org.uk, eballetbo@gmail.com, javier@dowhile0.org,
mchehab@redhat.com, santosh.shilimkar@ti.com,
broonie@opensource.wolfsonmicro.com, swarren@nvidia.com,
linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework
Date: Wed, 3 Apr 2013 14:55:47 +0000 [thread overview]
Message-ID: <201304031455.47864.arnd@arndb.de> (raw)
In-Reply-To: <20130403134827.GF14680@arwen.pp.htv.fi>
On Wednesday 03 April 2013, Felipe Balbi wrote:
> const ? Maybe provide a:
>
> #define DEFINE_PHY_OPS(name) \
> const struct phy_ops #name_phy_ops = {
>
> macro ? This will force people to add the const keyword :-)
Forcing people to use const structures is good, but I think it would be
better without the macro, just by marking the argument in
devm_phy_create() as const.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework
Date: Wed, 3 Apr 2013 14:55:47 +0000 [thread overview]
Message-ID: <201304031455.47864.arnd@arndb.de> (raw)
In-Reply-To: <20130403134827.GF14680@arwen.pp.htv.fi>
On Wednesday 03 April 2013, Felipe Balbi wrote:
> const ? Maybe provide a:
>
> #define DEFINE_PHY_OPS(name) \
> const struct phy_ops #name_phy_ops = {
>
> macro ? This will force people to add the const keyword :-)
Forcing people to use const structures is good, but I think it would be
better without the macro, just by marking the argument in
devm_phy_create() as const.
Arnd
next prev parent reply other threads:[~2013-04-03 14:55 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 12:53 [PATCH v5 0/6] Generic PHY Framework Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
[not found] ` <1364993634-6378-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-04-03 12:53 ` [PATCH v5 1/6] drivers: phy: add generic PHY framework Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 21:46 ` Sylwester Nawrocki
2013-04-03 21:46 ` Sylwester Nawrocki
2013-04-04 9:21 ` Kishon Vijay Abraham I
2013-04-04 9:21 ` Kishon Vijay Abraham I
2013-04-04 9:21 ` Kishon Vijay Abraham I
[not found] ` <515D462F.9050109-l0cyMroinI0@public.gmane.org>
2013-04-04 10:41 ` Sylwester Nawrocki
2013-04-04 10:41 ` Sylwester Nawrocki
2013-04-04 10:41 ` Sylwester Nawrocki
2013-04-04 11:11 ` Kishon Vijay Abraham I
2013-04-04 11:11 ` Kishon Vijay Abraham I
2013-04-04 11:11 ` Kishon Vijay Abraham I
[not found] ` <1364993634-6378-2-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-04-03 13:42 ` Felipe Balbi
2013-04-03 13:42 ` Felipe Balbi
2013-04-03 13:42 ` Felipe Balbi
[not found] ` <20130403134102.GC14680-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-04-03 14:18 ` Kishon Vijay Abraham I
2013-04-03 14:18 ` Kishon Vijay Abraham I
2013-04-03 14:18 ` Kishon Vijay Abraham I
[not found] ` <515C3A42.4020404-l0cyMroinI0@public.gmane.org>
2013-04-03 14:27 ` Felipe Balbi
2013-04-03 14:27 ` Felipe Balbi
2013-04-03 14:27 ` Felipe Balbi
2013-04-03 14:32 ` Kishon Vijay Abraham I
2013-04-03 14:32 ` Kishon Vijay Abraham I
2013-04-03 14:32 ` Kishon Vijay Abraham I
[not found] ` <515C3D94.1060000-l0cyMroinI0@public.gmane.org>
2013-04-03 15:47 ` Felipe Balbi
2013-04-03 15:47 ` Felipe Balbi
2013-04-03 15:47 ` Felipe Balbi
[not found] ` <20130403154704.GD19093-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-04-04 8:56 ` Kishon Vijay Abraham I
2013-04-04 8:56 ` Kishon Vijay Abraham I
2013-04-04 8:56 ` Kishon Vijay Abraham I
2013-04-03 23:54 ` Stephen Warren
2013-04-03 23:54 ` Stephen Warren
2013-04-03 23:54 ` Stephen Warren
[not found] ` <515CC123.4060402-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-04-04 7:15 ` Felipe Balbi
2013-04-04 7:15 ` Felipe Balbi
2013-04-04 7:15 ` Felipe Balbi
2013-04-08 13:21 ` Kishon Vijay Abraham I
2013-04-08 13:21 ` Kishon Vijay Abraham I
2013-04-08 13:21 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` [PATCH v5 2/6] usb: phy: omap-usb2: use the new " Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
[not found] ` <1364993634-6378-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-04-03 13:48 ` Felipe Balbi
2013-04-03 13:48 ` Felipe Balbi
2013-04-03 13:48 ` Felipe Balbi
2013-04-03 14:55 ` Arnd Bergmann [this message]
2013-04-03 14:55 ` Arnd Bergmann
2013-04-03 15:48 ` Felipe Balbi
2013-04-03 15:48 ` Felipe Balbi
2013-04-03 15:48 ` Felipe Balbi
2013-04-03 12:53 ` [PATCH v5 3/6] usb: otg: twl4030: " Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` [PATCH v5 6/6] usb: musb: omap2430: " Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 23:42 ` [PATCH v5 0/6] Generic PHY Framework Stephen Warren
2013-04-03 23:42 ` Stephen Warren
2013-04-03 23:42 ` Stephen Warren
2013-04-03 12:53 ` [PATCH v5 4/6] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` [PATCH v5 5/6] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304031455.47864.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cesarb@cesarb.net \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=eballetbo@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=javier@dowhile0.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mchehab@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.