From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
Cc: broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org,
mchehab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org,
cesarb-PWySMVKUnqmsTnJN9+BGXg@public.gmane.org,
eballetbo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
santosh.shilimkar-l0cyMroinI0@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework
Date: Wed, 3 Apr 2013 18:47:04 +0300 [thread overview]
Message-ID: <20130403154704.GD19093@arwen.pp.htv.fi> (raw)
In-Reply-To: <515C3D94.1060000-l0cyMroinI0@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 794 bytes --]
Hi,
On Wed, Apr 03, 2013 at 08:02:52PM +0530, Kishon Vijay Abraham I wrote:
> >>>>+ ret = -EINVAL;
> >>>>+ goto err0;
> >>>>+ }
> >>>>+
> >>>>+ if (!phy_class)
> >>>>+ phy_core_init();
> >>>
> >>>why don't you setup the class on module_init ? Then this would be a
> >>>terrible error condition here :-)
> >>
> >>This is for the case where the PHY driver gets loaded before the PHY
> >>framework. I could have returned EPROBE_DEFER here instead I thought
> >>will have it this way.
> >
> >looks a bit weird IMO. Is it really possible for PHY to load before ?
>
> yeah. it actually happened when I tried with beagle and had all the
> modules as built-in. Because twl4030 has subsys_initcall(), it loads
> before PHY framework.
that's a bug in twl4030.
--
balbi
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/6] drivers: phy: add generic PHY framework
Date: Wed, 3 Apr 2013 18:47:04 +0300 [thread overview]
Message-ID: <20130403154704.GD19093@arwen.pp.htv.fi> (raw)
In-Reply-To: <515C3D94.1060000@ti.com>
Hi,
On Wed, Apr 03, 2013 at 08:02:52PM +0530, Kishon Vijay Abraham I wrote:
> >>>>+ ret = -EINVAL;
> >>>>+ goto err0;
> >>>>+ }
> >>>>+
> >>>>+ if (!phy_class)
> >>>>+ phy_core_init();
> >>>
> >>>why don't you setup the class on module_init ? Then this would be a
> >>>terrible error condition here :-)
> >>
> >>This is for the case where the PHY driver gets loaded before the PHY
> >>framework. I could have returned EPROBE_DEFER here instead I thought
> >>will have it this way.
> >
> >looks a bit weird IMO. Is it really possible for PHY to load before ?
>
> yeah. it actually happened when I tried with beagle and had all the
> modules as built-in. Because twl4030 has subsys_initcall(), it loads
> before PHY framework.
that's a bug in twl4030.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130403/494c6f11/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: <balbi@ti.com>, <gregkh@linuxfoundation.org>, <arnd@arndb.de>,
<akpm@linux-foundation.org>, <swarren@wwwdotorg.org>,
<sylvester.nawrocki@gmail.com>, <rob@landley.net>,
<netdev@vger.kernel.org>, <davem@davemloft.net>,
<cesarb@cesarb.net>, <linux-usb@vger.kernel.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<tony@atomide.com>, <grant.likely@secretlab.ca>,
<rob.herring@calxeda.com>, <b-cousson@ti.com>,
<linux@arm.linux.org.uk>, <eballetbo@gmail.com>,
<javier@dowhile0.org>, <mchehab@redhat.com>,
<santosh.shilimkar@ti.com>, <broonie@opensource.wolfsonmicro.com>,
<swarren@nvidia.com>, <linux-doc@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework
Date: Wed, 3 Apr 2013 18:47:04 +0300 [thread overview]
Message-ID: <20130403154704.GD19093@arwen.pp.htv.fi> (raw)
In-Reply-To: <515C3D94.1060000@ti.com>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
Hi,
On Wed, Apr 03, 2013 at 08:02:52PM +0530, Kishon Vijay Abraham I wrote:
> >>>>+ ret = -EINVAL;
> >>>>+ goto err0;
> >>>>+ }
> >>>>+
> >>>>+ if (!phy_class)
> >>>>+ phy_core_init();
> >>>
> >>>why don't you setup the class on module_init ? Then this would be a
> >>>terrible error condition here :-)
> >>
> >>This is for the case where the PHY driver gets loaded before the PHY
> >>framework. I could have returned EPROBE_DEFER here instead I thought
> >>will have it this way.
> >
> >looks a bit weird IMO. Is it really possible for PHY to load before ?
>
> yeah. it actually happened when I tried with beagle and had all the
> modules as built-in. Because twl4030 has subsys_initcall(), it loads
> before PHY framework.
that's a bug in twl4030.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-03 15:47 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 12:53 [PATCH v5 0/6] Generic PHY Framework Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` [PATCH v5 4/6] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` [PATCH v5 5/6] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
[not found] ` <1364993634-6378-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-04-03 12:53 ` [PATCH v5 1/6] drivers: phy: add generic PHY framework Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 21:46 ` Sylwester Nawrocki
2013-04-03 21:46 ` Sylwester Nawrocki
2013-04-04 9:21 ` Kishon Vijay Abraham I
2013-04-04 9:21 ` Kishon Vijay Abraham I
2013-04-04 9:21 ` Kishon Vijay Abraham I
[not found] ` <515D462F.9050109-l0cyMroinI0@public.gmane.org>
2013-04-04 10:41 ` Sylwester Nawrocki
2013-04-04 10:41 ` Sylwester Nawrocki
2013-04-04 10:41 ` Sylwester Nawrocki
2013-04-04 11:11 ` Kishon Vijay Abraham I
2013-04-04 11:11 ` Kishon Vijay Abraham I
2013-04-04 11:11 ` Kishon Vijay Abraham I
[not found] ` <1364993634-6378-2-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-04-03 13:42 ` Felipe Balbi
2013-04-03 13:42 ` Felipe Balbi
2013-04-03 13:42 ` Felipe Balbi
[not found] ` <20130403134102.GC14680-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-04-03 14:18 ` Kishon Vijay Abraham I
2013-04-03 14:18 ` Kishon Vijay Abraham I
2013-04-03 14:18 ` Kishon Vijay Abraham I
[not found] ` <515C3A42.4020404-l0cyMroinI0@public.gmane.org>
2013-04-03 14:27 ` Felipe Balbi
2013-04-03 14:27 ` Felipe Balbi
2013-04-03 14:27 ` Felipe Balbi
2013-04-03 14:32 ` Kishon Vijay Abraham I
2013-04-03 14:32 ` Kishon Vijay Abraham I
2013-04-03 14:32 ` Kishon Vijay Abraham I
[not found] ` <515C3D94.1060000-l0cyMroinI0@public.gmane.org>
2013-04-03 15:47 ` Felipe Balbi [this message]
2013-04-03 15:47 ` Felipe Balbi
2013-04-03 15:47 ` Felipe Balbi
[not found] ` <20130403154704.GD19093-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-04-04 8:56 ` Kishon Vijay Abraham I
2013-04-04 8:56 ` Kishon Vijay Abraham I
2013-04-04 8:56 ` Kishon Vijay Abraham I
2013-04-03 23:54 ` Stephen Warren
2013-04-03 23:54 ` Stephen Warren
2013-04-03 23:54 ` Stephen Warren
[not found] ` <515CC123.4060402-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-04-04 7:15 ` Felipe Balbi
2013-04-04 7:15 ` Felipe Balbi
2013-04-04 7:15 ` Felipe Balbi
2013-04-08 13:21 ` Kishon Vijay Abraham I
2013-04-08 13:21 ` Kishon Vijay Abraham I
2013-04-08 13:21 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` [PATCH v5 2/6] usb: phy: omap-usb2: use the new " Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
[not found] ` <1364993634-6378-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-04-03 13:48 ` Felipe Balbi
2013-04-03 13:48 ` Felipe Balbi
2013-04-03 13:48 ` Felipe Balbi
2013-04-03 14:55 ` Arnd Bergmann
2013-04-03 14:55 ` Arnd Bergmann
2013-04-03 15:48 ` Felipe Balbi
2013-04-03 15:48 ` Felipe Balbi
2013-04-03 15:48 ` Felipe Balbi
2013-04-03 12:53 ` [PATCH v5 3/6] usb: otg: twl4030: " Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` [PATCH v5 6/6] usb: musb: omap2430: " Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 12:53 ` Kishon Vijay Abraham I
2013-04-03 23:42 ` [PATCH v5 0/6] Generic PHY Framework Stephen Warren
2013-04-03 23:42 ` Stephen Warren
2013-04-03 23:42 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130403154704.GD19093@arwen.pp.htv.fi \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=cesarb-PWySMVKUnqmsTnJN9+BGXg@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=eballetbo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mchehab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=santosh.shilimkar-l0cyMroinI0@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.