* [RFC] drivers/staging/silicom/bp_proc.c removal
@ 2013-04-04 19:12 Al Viro
[not found] ` <CAN4nR9cuvPgNK++N2=Mz3sifeuBfRtKdAEQ8m6MhcSvQVKn-Sg@mail.gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Al Viro @ 2013-04-04 19:12 UTC (permalink / raw)
To: Daniel Cotey; +Cc: Greg Kroah-Hartman, linux-kernel
It's all ifdefed out (on BYPASS_SUPPORT), severely bitrotten (try
to remove the ifdef and watch what happens on attempt to build) and, AFAICS,
it's a duplicate of the stuff in bp_mod.c.
Is there any reason to keep it around? IOW, how about
git rm drivers/staging/silicom/bp_proc.c
git mv drivers/staging/silicom/bp{,ctl}_mod.c
ed drivers/staging/silicom/Makefile <<EOF
/bp_proc/d
wq
EOF
and if anybody needs to see what used to be there, git history is enough...
Another thing: please, check the vfs.git patches to bp_mod.c
in linux-next. I think they are safe, but I don't have the hardware
to test them on...
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <CAN4nR9cuvPgNK++N2=Mz3sifeuBfRtKdAEQ8m6MhcSvQVKn-Sg@mail.gmail.com>]
* Re: [RFC] drivers/staging/silicom/bp_proc.c removal [not found] ` <CAN4nR9cuvPgNK++N2=Mz3sifeuBfRtKdAEQ8m6MhcSvQVKn-Sg@mail.gmail.com> @ 2013-04-05 17:37 ` Greg Kroah-Hartman 2013-04-05 17:48 ` Al Viro 1 sibling, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2013-04-05 17:37 UTC (permalink / raw) To: Puff .; +Cc: Al Viro, linux-kernel On Fri, Apr 05, 2013 at 10:31:56AM -0700, Puff . wrote: > No reason not to. > > ~~~~~~ > DanielC > > On Thu, Apr 4, 2013 at 12:12 PM, Al Viro <viro@zeniv.linux.org.uk> wrote: > > It's all ifdefed out (on BYPASS_SUPPORT), severely bitrotten (try > to remove the ifdef and watch what happens on attempt to build) and, > AFAICS, > it's a duplicate of the stuff in bp_mod.c. > > Is there any reason to keep it around? IOW, how about > git rm drivers/staging/silicom/bp_proc.c > git mv drivers/staging/silicom/bp{,ctl}_mod.c > ed drivers/staging/silicom/Makefile <<EOF > /bp_proc/d > wq > EOF > and if anybody needs to see what used to be there, git history is enough... Ok, I'll go do that later today, thanks. greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC] drivers/staging/silicom/bp_proc.c removal [not found] ` <CAN4nR9cuvPgNK++N2=Mz3sifeuBfRtKdAEQ8m6MhcSvQVKn-Sg@mail.gmail.com> 2013-04-05 17:37 ` Greg Kroah-Hartman @ 2013-04-05 17:48 ` Al Viro 2013-04-05 22:01 ` Greg Kroah-Hartman 1 sibling, 1 reply; 4+ messages in thread From: Al Viro @ 2013-04-05 17:48 UTC (permalink / raw) To: Puff .; +Cc: Greg Kroah-Hartman, linux-kernel On Fri, Apr 05, 2013 at 10:31:56AM -0700, Puff . wrote: > No reason not to. Done (in vfs.git#for-next, should propagate in a few) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC] drivers/staging/silicom/bp_proc.c removal 2013-04-05 17:48 ` Al Viro @ 2013-04-05 22:01 ` Greg Kroah-Hartman 0 siblings, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2013-04-05 22:01 UTC (permalink / raw) To: Al Viro; +Cc: Puff ., linux-kernel On Fri, Apr 05, 2013 at 06:48:02PM +0100, Al Viro wrote: > On Fri, Apr 05, 2013 at 10:31:56AM -0700, Puff . wrote: > > No reason not to. > > Done (in vfs.git#for-next, should propagate in a few) Thanks for doing that, you beat me to it. greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-05 22:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-04 19:12 [RFC] drivers/staging/silicom/bp_proc.c removal Al Viro
[not found] ` <CAN4nR9cuvPgNK++N2=Mz3sifeuBfRtKdAEQ8m6MhcSvQVKn-Sg@mail.gmail.com>
2013-04-05 17:37 ` Greg Kroah-Hartman
2013-04-05 17:48 ` Al Viro
2013-04-05 22:01 ` Greg Kroah-Hartman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.