From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] dmaengine: ste_dma40: Only configure a channel during a configure request
Date: Mon, 8 Apr 2013 18:19:46 +0200 [thread overview]
Message-ID: <201304081819.46377.arnd@arndb.de> (raw)
In-Reply-To: <1365434591-21569-4-git-send-email-lee.jones@linaro.org>
On Monday 08 April 2013, Lee Jones wrote:
> According to the DMA documentation allocating a channel and configuring
> it are two separate actions. By moving the configuration code into the
> correct code path we lighten the burden on the information required to
> successfully allocate a channel.
>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Dan Williams <djbw@fb.com>
> Cc: Per Forlin <per.forlin@stericsson.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
I think the patch doesn't match the description. You only remove
the calls to configure the channel but don't add it in a proper
place.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@stericsson.com,
Vinod Koul <vinod.koul@intel.com>, Dan Williams <djbw@fb.com>,
Per Forlin <per.forlin@stericsson.com>
Subject: Re: [PATCH 4/5] dmaengine: ste_dma40: Only configure a channel during a configure request
Date: Mon, 8 Apr 2013 18:19:46 +0200 [thread overview]
Message-ID: <201304081819.46377.arnd@arndb.de> (raw)
In-Reply-To: <1365434591-21569-4-git-send-email-lee.jones@linaro.org>
On Monday 08 April 2013, Lee Jones wrote:
> According to the DMA documentation allocating a channel and configuring
> it are two separate actions. By moving the configuration code into the
> correct code path we lighten the burden on the information required to
> successfully allocate a channel.
>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Dan Williams <djbw@fb.com>
> Cc: Per Forlin <per.forlin@stericsson.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
I think the patch doesn't match the description. You only remove
the calls to configure the channel but don't add it in a proper
place.
Arnd
next prev parent reply other threads:[~2013-04-08 16:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 15:23 [PATCH 1/5] ARM: ux500: Move DMA40 platform data includes file out to include/ Lee Jones
2013-04-08 15:23 ` Lee Jones
2013-04-08 15:23 ` [PATCH 2/5] dmaengine: ste_dma40: Assign memcpy channels in the driver Lee Jones
2013-04-08 15:23 ` Lee Jones
2013-04-08 16:13 ` Arnd Bergmann
2013-04-08 16:13 ` Arnd Bergmann
2013-04-08 15:23 ` [PATCH 3/5] dmaengine: ste_dma40: Move default memcpy configs into " Lee Jones
2013-04-08 15:23 ` Lee Jones
2013-04-08 16:14 ` Arnd Bergmann
2013-04-08 16:14 ` Arnd Bergmann
2013-04-08 15:23 ` [PATCH 4/5] dmaengine: ste_dma40: Only configure a channel during a configure request Lee Jones
2013-04-08 15:23 ` Lee Jones
2013-04-08 16:19 ` Arnd Bergmann [this message]
2013-04-08 16:19 ` Arnd Bergmann
2013-04-09 7:11 ` [PATCH 4/5] dmaengine: ste_dma40: Do not configure channels during an channel allocation Lee Jones
2013-04-09 7:11 ` Lee Jones
2013-04-09 9:36 ` Arnd Bergmann
2013-04-09 9:36 ` Arnd Bergmann
2013-04-09 10:04 ` Lee Jones
2013-04-09 10:04 ` Lee Jones
2013-04-09 10:28 ` Arnd Bergmann
2013-04-09 10:28 ` Arnd Bergmann
2013-04-08 15:23 ` [PATCH 5/5] dmaengine: ste_dma40: Move LCPA allocation and real-time config Lee Jones
2013-04-08 15:23 ` Lee Jones
2013-04-08 16:17 ` [PATCH 1/5] ARM: ux500: Move DMA40 platform data includes file out to include/ Arnd Bergmann
2013-04-08 16:17 ` Arnd Bergmann
2013-04-09 7:05 ` Lee Jones
2013-04-09 7:05 ` Lee Jones
2013-04-09 9:35 ` Arnd Bergmann
2013-04-09 9:35 ` Arnd Bergmann
2013-04-15 10:47 ` Linus Walleij
2013-04-15 10:47 ` Linus Walleij
2013-04-15 10:58 ` Lee Jones
2013-04-15 10:58 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304081819.46377.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.