All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] dmaengine: ste_dma40: Do not configure channels during an channel allocation
Date: Tue, 9 Apr 2013 08:11:54 +0100	[thread overview]
Message-ID: <20130409071154.GH3084@gmail.com> (raw)
In-Reply-To: <1365434591-21569-4-git-send-email-lee.jones@linaro.org>

According to the DMA documentation allocating a channel and configuring
it are two separate actions. By removing the configuration code from the
channel allocation path we lighten the burden on the information required to
successfully allocate a channel.

Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <djbw@fb.com>
Cc: Per Forlin <per.forlin@stericsson.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/dma/ste_dma40.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index ecca492..3543ea4 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -2471,16 +2471,10 @@ static int d40_alloc_chan_resources(struct dma_chan *chan)
 	}
 
 	pm_runtime_get_sync(d40c->base->dev);
-	/* Fill in basic CFG register values */
-	d40_phy_cfg(&d40c->dma_cfg, &d40c->src_def_cfg,
-		    &d40c->dst_def_cfg, chan_is_logical(d40c));
 
 	d40_set_prio_realtime(d40c);
 
 	if (chan_is_logical(d40c)) {
-		d40_log_cfg(&d40c->dma_cfg,
-			    &d40c->log_def.lcsp1, &d40c->log_def.lcsp3);
-
 		if (d40c->dma_cfg.dir == STEDMA40_PERIPH_TO_MEM)
 			d40c->lcpa = d40c->base->lcpa_base +
 				d40c->dma_cfg.src_dev_type * D40_LCPA_CHAN_SIZE;
-- 
1.7.10.4

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, linus.walleij@stericsson.com,
	Vinod Koul <vinod.koul@intel.com>, Dan Williams <djbw@fb.com>,
	Per Forlin <per.forlin@stericsson.com>
Subject: [PATCH 4/5] dmaengine: ste_dma40: Do not configure channels during an channel allocation
Date: Tue, 9 Apr 2013 08:11:54 +0100	[thread overview]
Message-ID: <20130409071154.GH3084@gmail.com> (raw)
In-Reply-To: <1365434591-21569-4-git-send-email-lee.jones@linaro.org>

According to the DMA documentation allocating a channel and configuring
it are two separate actions. By removing the configuration code from the
channel allocation path we lighten the burden on the information required to
successfully allocate a channel.

Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <djbw@fb.com>
Cc: Per Forlin <per.forlin@stericsson.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/dma/ste_dma40.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index ecca492..3543ea4 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -2471,16 +2471,10 @@ static int d40_alloc_chan_resources(struct dma_chan *chan)
 	}
 
 	pm_runtime_get_sync(d40c->base->dev);
-	/* Fill in basic CFG register values */
-	d40_phy_cfg(&d40c->dma_cfg, &d40c->src_def_cfg,
-		    &d40c->dst_def_cfg, chan_is_logical(d40c));
 
 	d40_set_prio_realtime(d40c);
 
 	if (chan_is_logical(d40c)) {
-		d40_log_cfg(&d40c->dma_cfg,
-			    &d40c->log_def.lcsp1, &d40c->log_def.lcsp3);
-
 		if (d40c->dma_cfg.dir == STEDMA40_PERIPH_TO_MEM)
 			d40c->lcpa = d40c->base->lcpa_base +
 				d40c->dma_cfg.src_dev_type * D40_LCPA_CHAN_SIZE;
-- 
1.7.10.4

  parent reply	other threads:[~2013-04-09  7:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 15:23 [PATCH 1/5] ARM: ux500: Move DMA40 platform data includes file out to include/ Lee Jones
2013-04-08 15:23 ` Lee Jones
2013-04-08 15:23 ` [PATCH 2/5] dmaengine: ste_dma40: Assign memcpy channels in the driver Lee Jones
2013-04-08 15:23   ` Lee Jones
2013-04-08 16:13   ` Arnd Bergmann
2013-04-08 16:13     ` Arnd Bergmann
2013-04-08 15:23 ` [PATCH 3/5] dmaengine: ste_dma40: Move default memcpy configs into " Lee Jones
2013-04-08 15:23   ` Lee Jones
2013-04-08 16:14   ` Arnd Bergmann
2013-04-08 16:14     ` Arnd Bergmann
2013-04-08 15:23 ` [PATCH 4/5] dmaengine: ste_dma40: Only configure a channel during a configure request Lee Jones
2013-04-08 15:23   ` Lee Jones
2013-04-08 16:19   ` Arnd Bergmann
2013-04-08 16:19     ` Arnd Bergmann
2013-04-09  7:11   ` Lee Jones [this message]
2013-04-09  7:11     ` [PATCH 4/5] dmaengine: ste_dma40: Do not configure channels during an channel allocation Lee Jones
2013-04-09  9:36     ` Arnd Bergmann
2013-04-09  9:36       ` Arnd Bergmann
2013-04-09 10:04       ` Lee Jones
2013-04-09 10:04         ` Lee Jones
2013-04-09 10:28     ` Arnd Bergmann
2013-04-09 10:28       ` Arnd Bergmann
2013-04-08 15:23 ` [PATCH 5/5] dmaengine: ste_dma40: Move LCPA allocation and real-time config Lee Jones
2013-04-08 15:23   ` Lee Jones
2013-04-08 16:17 ` [PATCH 1/5] ARM: ux500: Move DMA40 platform data includes file out to include/ Arnd Bergmann
2013-04-08 16:17   ` Arnd Bergmann
2013-04-09  7:05   ` Lee Jones
2013-04-09  7:05     ` Lee Jones
2013-04-09  9:35     ` Arnd Bergmann
2013-04-09  9:35       ` Arnd Bergmann
2013-04-15 10:47 ` Linus Walleij
2013-04-15 10:47   ` Linus Walleij
2013-04-15 10:58   ` Lee Jones
2013-04-15 10:58     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130409071154.GH3084@gmail.com \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.