All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>,
	dm-crypt@saout.de, Christian Schmidt <schmidt@digadd.de>,
	linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	dm-devel@redhat.com, Andi Kleen <andi@firstfloor.org>,
	Mikulas Patocka <mpatocka@redhat.com>,
	Milan Broz <gmazyland@gmail.com>
Subject: Re: [dm-crypt] dm-crypt parallelization patches
Date: Tue, 9 Apr 2013 15:13:39 -0400	[thread overview]
Message-ID: <20130409191339.GP6320@redhat.com> (raw)
In-Reply-To: <20130409185721.GF6186@mtj.dyndns.org>

On Tue, Apr 09, 2013 at 11:57:21AM -0700, Tejun Heo wrote:

[..]
> And destroy all per-ioc and cgroup logics in block layer in the
> process.

Oh, I am in no-way suggesting don't use bio_associate_current(). I am 
just trying to analyze the performance issue right now and saying that
as far as performance is concenred, one will get it back even if one
does not use bio_associate_current().

Yes but one needs to use bio_associate_current() to make sure bio's
are attributed to right cgroup and associate bio to right task. This
should help solving the long standing issue of task losing its ioprio
if dm-crypt target is in the stack.

Thanks
Vivek

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
	Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>,
	Milan Broz <gmazyland@gmail.com>,
	dm-devel@redhat.com, Andi Kleen <andi@firstfloor.org>,
	dm-crypt@saout.de, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Christian Schmidt <schmidt@digadd.de>
Subject: Re: dm-crypt parallelization patches
Date: Tue, 9 Apr 2013 15:13:39 -0400	[thread overview]
Message-ID: <20130409191339.GP6320@redhat.com> (raw)
In-Reply-To: <20130409185721.GF6186@mtj.dyndns.org>

On Tue, Apr 09, 2013 at 11:57:21AM -0700, Tejun Heo wrote:

[..]
> And destroy all per-ioc and cgroup logics in block layer in the
> process.

Oh, I am in no-way suggesting don't use bio_associate_current(). I am 
just trying to analyze the performance issue right now and saying that
as far as performance is concenred, one will get it back even if one
does not use bio_associate_current().

Yes but one needs to use bio_associate_current() to make sure bio's
are attributed to right cgroup and associate bio to right task. This
should help solving the long standing issue of task losing its ioprio
if dm-crypt target is in the stack.

Thanks
Vivek

  reply	other threads:[~2013-04-09 19:14 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26  3:47 dm-crypt performance Mikulas Patocka
2013-03-26  6:52 ` Christoph Hellwig
2013-03-26 12:27 ` [dm-crypt] [dm-devel] " Alasdair G Kergon
2013-03-26 12:27   ` Alasdair G Kergon
2013-03-26 20:05   ` [dm-crypt] " Milan Broz
2013-03-26 20:05     ` Milan Broz
2013-03-26 20:28     ` [dm-crypt] " Mike Snitzer
2013-03-26 20:28       ` Mike Snitzer
2013-03-26 20:58       ` [dm-crypt] " Milan Broz
2013-03-26 20:58         ` Milan Broz
2013-03-28 18:53       ` [dm-crypt] " Tejun Heo
2013-03-28 18:53         ` Tejun Heo
2013-03-28 19:33         ` [dm-crypt] " Vivek Goyal
2013-03-28 19:33           ` Vivek Goyal
2013-03-28 19:44           ` [dm-crypt] " Tejun Heo
2013-03-28 19:44             ` Tejun Heo
2013-03-28 20:38             ` [dm-crypt] " Vivek Goyal
2013-03-28 20:38               ` Vivek Goyal
2013-03-28 20:45               ` Tejun Heo
2013-04-09 17:51                 ` [dm-crypt] dm-crypt parallelization patches Mikulas Patocka
2013-04-09 17:51                   ` Mikulas Patocka
2013-04-09 17:57                   ` Tejun Heo
2013-04-09 18:08                     ` [dm-crypt] " Mikulas Patocka
2013-04-09 18:08                       ` Mikulas Patocka
2013-04-09 18:10                       ` Tejun Heo
2013-04-09 18:42                         ` [dm-crypt] " Vivek Goyal
2013-04-09 18:42                           ` Vivek Goyal
2013-04-09 18:57                           ` Tejun Heo
2013-04-09 19:13                             ` Vivek Goyal [this message]
2013-04-09 19:13                               ` Vivek Goyal
2013-04-09 19:42                         ` [dm-crypt] " Mikulas Patocka
2013-04-09 19:42                           ` Mikulas Patocka
2013-04-09 19:52                           ` Tejun Heo
2013-04-09 20:32                             ` [dm-crypt] " Mikulas Patocka
2013-04-09 20:32                               ` Mikulas Patocka
2013-04-09 21:02                               ` Tejun Heo
2013-04-09 21:03                                 ` Tejun Heo
2013-04-09 21:07                               ` [dm-crypt] " Vivek Goyal
2013-04-09 21:07                                 ` Vivek Goyal
2013-04-09 21:18                                 ` [dm-crypt] " Mikulas Patocka
2013-04-09 21:18                                   ` Mikulas Patocka
2013-04-10 19:24                                   ` [dm-crypt] " Vivek Goyal
2013-04-10 19:24                                     ` Vivek Goyal
2013-04-10 23:42                                     ` [dm-crypt] [PATCH] make dm and dm-crypt forward cgroup context (was: dm-crypt parallelization patches) Mikulas Patocka
2013-04-10 23:42                                       ` Mikulas Patocka
2013-04-10 23:50                                       ` Tejun Heo
2013-04-11 19:49                                         ` [dm-crypt] [PATCH v2] " Mikulas Patocka
2013-04-11 19:49                                           ` Mikulas Patocka
2013-04-11 19:52                                           ` Tejun Heo
2013-04-11 20:00                                             ` Tejun Heo
2013-04-12  0:06                                               ` [dm-crypt] " Mikulas Patocka
2013-04-12  0:06                                                 ` Mikulas Patocka
2013-04-12  0:22                                                 ` Tejun Heo
2013-04-12  5:59                                                   ` [dm-crypt] [PATCH v2] make dm and dm-crypt forward cgroup context Milan Broz
2013-04-12  5:59                                                     ` Milan Broz
2013-04-12 18:17                                                   ` [dm-crypt] [PATCH v2] make dm and dm-crypt forward cgroup context (was: dm-crypt parallelization patches) Mikulas Patocka
2013-04-12 18:17                                                     ` Mikulas Patocka
2013-04-12 18:01                                               ` [dm-crypt] " Mikulas Patocka
2013-04-12 18:01                                                 ` Mikulas Patocka
2013-04-12 18:29                                                 ` Tejun Heo
2013-04-15 13:02                                                   ` [dm-crypt] " Mikulas Patocka
2013-04-15 13:02                                                     ` Mikulas Patocka
2013-04-16 17:24                                                     ` Tejun Heo
2013-04-16 19:41                                                       ` [dm-crypt] " Mikulas Patocka
2013-04-16 19:41                                                         ` Mikulas Patocka
2013-04-18 16:47                                                       ` [dm-crypt] " Mike Snitzer
2013-04-18 16:47                                                         ` Mike Snitzer
2013-04-18 17:03                                                         ` Tejun Heo
2013-05-22 18:50                                                           ` [dm-crypt] " Mike Snitzer
2013-05-22 18:50                                                             ` Mike Snitzer
2013-05-22 19:48                                                             ` Tejun Heo
2013-04-09 18:36                   ` [dm-crypt] dm-crypt parallelization patches Vivek Goyal
2013-04-09 18:36                     ` Vivek Goyal
2013-04-09 18:08     ` [dm-crypt] [dm-devel] dm-crypt performance Mikulas Patocka
2013-04-09 18:08       ` Mikulas Patocka
2013-04-09 18:08       ` Mikulas Patocka
2013-04-09 18:40       ` [dm-crypt] " Arno Wagner
2013-04-21 20:38         ` Yves-Alexis Perez
2013-04-22  2:28           ` Arno Wagner
2013-04-09 18:59       ` Milan Broz
2013-04-09 18:59         ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130409191339.GP6320@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=axboe@kernel.dk \
    --cc=dm-crypt@saout.de \
    --cc=dm-devel@redhat.com \
    --cc=gmazyland@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=schmidt@digadd.de \
    --cc=snitzer@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.