* Patch to minimize noise with snapshots in emc_clariion checker
@ 2013-04-22 20:34 Levy, Jerome
2013-04-23 10:45 ` Rediff: " Levy, Jerome
2013-04-23 13:26 ` Mike Snitzer
0 siblings, 2 replies; 5+ messages in thread
From: Levy, Jerome @ 2013-04-22 20:34 UTC (permalink / raw)
To: dm-devel@redhat.com
Patch to stop emc_clariion_checker from logging messages when probes
to snapshot LUNs occur. Notification is still available if logging is
turned up (see condlog()) but normal probing of snapshots will no
longer produce status messages. Path functionality on snapshot probes
is unchanged.
Signed-off-by: Jerry Levy <jerome.levy@emc.com>
--- ./libmultipath/checkers/emc_clariion.c 2013-04-22 15:50:19.081555624 -0400
+++ ./libmultipath/checkers/emc_clariion.c.orig 2013-04-22 14:07:36.966548097 -0400
@@ -15,7 +15,6 @@
#include "../libmultipath/sg_include.h"
#include "libsg.h"
#include "checkers.h"
-#include "debug.h"
#define INQUIRY_CMD 0x12
#define INQUIRY_CMDLEN 6
@@ -199,8 +198,9 @@ int libcheck_check (struct checker * c)
* 02/04/03 not 05/25/01 on read.
*/
SET_INACTIVE_SNAP(c);
- condlog(3, "emc_clariion_checker: Active path to "
- "inactive snapshot WWN %s.", wwnstr);
+ MSG(c, "emc_clariion_checker: Active "
+ "path to inactive snapshot WWN %s.",
+ wwnstr);
} else
MSG(c, "emc_clariion_checker: Read "
"error for WWN %s. Sense data are "
@@ -219,8 +219,9 @@ int libcheck_check (struct checker * c)
} else {
if (IS_INACTIVE_SNAP(c)) {
hexadecimal_to_ascii(ct->wwn, wwnstr);
- condlog(3, "emc_clariion_checker: Passive path to "
- "inactive snapshot WWN %s.", wwnstr);
+ MSG(c, "emc_clariion_checker: Passive "
+ "path to inactive snapshot WWN %s.",
+ wwnstr);
ret = PATH_DOWN;
} else {
MSG(c,
^ permalink raw reply [flat|nested] 5+ messages in thread* Rediff: Patch to minimize noise with snapshots in emc_clariion checker
2013-04-22 20:34 Patch to minimize noise with snapshots in emc_clariion checker Levy, Jerome
@ 2013-04-23 10:45 ` Levy, Jerome
2013-04-27 7:59 ` Christophe Varoqui
2013-04-23 13:26 ` Mike Snitzer
1 sibling, 1 reply; 5+ messages in thread
From: Levy, Jerome @ 2013-04-23 10:45 UTC (permalink / raw)
To: 'dm-devel@redhat.com'
Looks like the diff went the wrong way. Sorry for the inconvenience, resubmitting:
---
Patch to stop emc_clariion_checker from logging messages when probes to snapshot LUNs occur. Notification is still available if logging is turned up (see condlog()) but normal probing of snapshots will no longer produce status messages. Path functionality on snapshot probes is unchanged.
Signed-off-by: Jerry Levy <jerome.levy@emc.com>
--- ./libmultipath/checkers/emc_clariion.c.orig 2013-04-22 14:07:36.966548097 -0400
+++ ./libmultipath/checkers/emc_clariion.c 2013-04-22 15:50:19.081555624 -0400
@@ -15,6 +15,7 @@
#include "../libmultipath/sg_include.h"
#include "libsg.h"
#include "checkers.h"
+#include "debug.h"
#define INQUIRY_CMD 0x12
#define INQUIRY_CMDLEN 6
@@ -198,9 +199,8 @@ int libcheck_check (struct checker * c)
* 02/04/03 not 05/25/01 on read.
*/
SET_INACTIVE_SNAP(c);
- MSG(c, "emc_clariion_checker: Active "
- "path to inactive snapshot WWN %s.",
- wwnstr);
+ condlog(3, "emc_clariion_checker: Active path to "
+ "inactive snapshot WWN %s.", wwnstr);
} else
MSG(c, "emc_clariion_checker: Read "
"error for WWN %s. Sense data are "
@@ -219,9 +219,8 @@ int libcheck_check (struct checker * c)
} else {
if (IS_INACTIVE_SNAP(c)) {
hexadecimal_to_ascii(ct->wwn, wwnstr);
- MSG(c, "emc_clariion_checker: Passive "
- "path to inactive snapshot WWN %s.",
- wwnstr);
+ condlog(3, "emc_clariion_checker: Passive path to "
+ "inactive snapshot WWN %s.", wwnstr);
ret = PATH_DOWN;
} else {
MSG(c,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Rediff: Patch to minimize noise with snapshots in emc_clariion checker
2013-04-23 10:45 ` Rediff: " Levy, Jerome
@ 2013-04-27 7:59 ` Christophe Varoqui
0 siblings, 0 replies; 5+ messages in thread
From: Christophe Varoqui @ 2013-04-27 7:59 UTC (permalink / raw)
To: device-mapper development
On mar., 2013-04-23 at 10:45 +0000, Levy, Jerome wrote:
> Looks like the diff went the wrong way. Sorry for the inconvenience, resubmitting:
>
Applied manually.
You definitively have a problem with your way to generate 'git am'-able
mails. You could try to apply those mails to a fresh clone to verify and
diagnose this problem.
Thanks all the same.
> ---
>
> Patch to stop emc_clariion_checker from logging messages when probes to snapshot LUNs occur. Notification is still available if logging is turned up (see condlog()) but normal probing of snapshots will no longer produce status messages. Path functionality on snapshot probes is unchanged.
>
> Signed-off-by: Jerry Levy <jerome.levy@emc.com>
>
>
> --- ./libmultipath/checkers/emc_clariion.c.orig 2013-04-22 14:07:36.966548097 -0400
> +++ ./libmultipath/checkers/emc_clariion.c 2013-04-22 15:50:19.081555624 -0400
> @@ -15,6 +15,7 @@
> #include "../libmultipath/sg_include.h"
> #include "libsg.h"
> #include "checkers.h"
> +#include "debug.h"
>
> #define INQUIRY_CMD 0x12
> #define INQUIRY_CMDLEN 6
> @@ -198,9 +199,8 @@ int libcheck_check (struct checker * c)
> * 02/04/03 not 05/25/01 on read.
> */
> SET_INACTIVE_SNAP(c);
> - MSG(c, "emc_clariion_checker: Active "
> - "path to inactive snapshot WWN %s.",
> - wwnstr);
> + condlog(3, "emc_clariion_checker: Active path to "
> + "inactive snapshot WWN %s.", wwnstr);
> } else
> MSG(c, "emc_clariion_checker: Read "
> "error for WWN %s. Sense data are "
> @@ -219,9 +219,8 @@ int libcheck_check (struct checker * c)
> } else {
> if (IS_INACTIVE_SNAP(c)) {
> hexadecimal_to_ascii(ct->wwn, wwnstr);
> - MSG(c, "emc_clariion_checker: Passive "
> - "path to inactive snapshot WWN %s.",
> - wwnstr);
> + condlog(3, "emc_clariion_checker: Passive path to "
> + "inactive snapshot WWN %s.", wwnstr);
> ret = PATH_DOWN;
> } else {
> MSG(c,
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch to minimize noise with snapshots in emc_clariion checker
2013-04-22 20:34 Patch to minimize noise with snapshots in emc_clariion checker Levy, Jerome
2013-04-23 10:45 ` Rediff: " Levy, Jerome
@ 2013-04-23 13:26 ` Mike Snitzer
2013-04-23 13:34 ` [PATCH v3] libmultipath: " Levy, Jerome
1 sibling, 1 reply; 5+ messages in thread
From: Mike Snitzer @ 2013-04-23 13:26 UTC (permalink / raw)
To: Levy, Jerome; +Cc: dm-devel@redhat.com
On Mon, Apr 22 2013 at 4:34pm -0400,
Levy, Jerome <jerome.levy@emc.com> wrote:
> Patch to stop emc_clariion_checker from logging messages when probes
> to snapshot LUNs occur. Notification is still available if logging is
> turned up (see condlog()) but normal probing of snapshots will no
> longer produce status messages. Path functionality on snapshot probes
> is unchanged.
>
> Signed-off-by: Jerry Levy <jerome.levy@emc.com>
>
> --- ./libmultipath/checkers/emc_clariion.c 2013-04-22 15:50:19.081555624 -0400
> +++ ./libmultipath/checkers/emc_clariion.c.orig 2013-04-22 14:07:36.966548097 -0400
> @@ -15,7 +15,6 @@
> #include "../libmultipath/sg_include.h"
> #include "libsg.h"
> #include "checkers.h"
> -#include "debug.h"
>
> #define INQUIRY_CMD 0x12
> #define INQUIRY_CMDLEN 6
> @@ -199,8 +198,9 @@ int libcheck_check (struct checker * c)
> * 02/04/03 not 05/25/01 on read.
> */
> SET_INACTIVE_SNAP(c);
> - condlog(3, "emc_clariion_checker: Active path to "
> - "inactive snapshot WWN %s.", wwnstr);
> + MSG(c, "emc_clariion_checker: Active "
> + "path to inactive snapshot WWN %s.",
> + wwnstr);
> } else
> MSG(c, "emc_clariion_checker: Read "
> "error for WWN %s. Sense data are "
> @@ -219,8 +219,9 @@ int libcheck_check (struct checker * c)
> } else {
> if (IS_INACTIVE_SNAP(c)) {
> hexadecimal_to_ascii(ct->wwn, wwnstr);
> - condlog(3, "emc_clariion_checker: Passive path to "
> - "inactive snapshot WWN %s.", wwnstr);
> + MSG(c, "emc_clariion_checker: Passive "
> + "path to inactive snapshot WWN %s.",
> + wwnstr);
> ret = PATH_DOWN;
> } else {
> MSG(c,
>
Hmm, something happened with your patch... this is actually the inverse
of what you wanted ;)
Also, the #include should be: #include "../libmultipath/debug.h"
Please send v2 and use a subject like:
[PATCH v2] libmultipath: minimize noise with snapshots in emc_clariion checker
(Also wouldn't hurt to cc Christophe Varoqui <christophe.varoqui@gmail.com>)
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v3] libmultipath: minimize noise with snapshots in emc_clariion checker
2013-04-23 13:26 ` Mike Snitzer
@ 2013-04-23 13:34 ` Levy, Jerome
0 siblings, 0 replies; 5+ messages in thread
From: Levy, Jerome @ 2013-04-23 13:34 UTC (permalink / raw)
To: dm-devel@redhat.com; +Cc: Mike Snitzer, christophe.varoqui@gmail.com
Corrections noted. Sorry for the inconvenience... changing include and inverting diff.
Thanks, Mike!!!!
---
Patch to stop emc_clariion_checker from logging messages when probes to snapshot LUNs occur. Notification is still available if logging is turned up (see condlog()) but normal probing of snapshots will no longer produce status messages. Path functionality on snapshot probes is unchanged.
Signed-off-by: Jerry Levy <jerome.levy@emc.com>
--- ./libmultipath/checkers/emc_clariion.c.orig 2013-04-22 14:07:36.966548097 -0400
+++ ./libmultipath/checkers/emc_clariion.c 2013-04-22 15:50:19.081555624 -0400
@@ -15,6 +15,7 @@
#include "../libmultipath/sg_include.h"
#include "libsg.h"
#include "checkers.h"
+#include "../libmultipath/debug.h"
#define INQUIRY_CMD 0x12
#define INQUIRY_CMDLEN 6
@@ -198,9 +199,8 @@ int libcheck_check (struct checker * c)
* 02/04/03 not 05/25/01 on read.
*/
SET_INACTIVE_SNAP(c);
- MSG(c, "emc_clariion_checker: Active "
- "path to inactive snapshot WWN %s.",
- wwnstr);
+ condlog(3, "emc_clariion_checker: Active path to "
+ "inactive snapshot WWN %s.", wwnstr);
} else
MSG(c, "emc_clariion_checker: Read "
"error for WWN %s. Sense data are "
@@ -219,9 +219,8 @@ int libcheck_check (struct checker * c)
} else {
if (IS_INACTIVE_SNAP(c)) {
hexadecimal_to_ascii(ct->wwn, wwnstr);
- MSG(c, "emc_clariion_checker: Passive "
- "path to inactive snapshot WWN %s.",
- wwnstr);
+ condlog(3, "emc_clariion_checker: Passive path to "
+ "inactive snapshot WWN %s.", wwnstr);
ret = PATH_DOWN;
} else {
MSG(c,
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-27 7:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-22 20:34 Patch to minimize noise with snapshots in emc_clariion checker Levy, Jerome
2013-04-23 10:45 ` Rediff: " Levy, Jerome
2013-04-27 7:59 ` Christophe Varoqui
2013-04-23 13:26 ` Mike Snitzer
2013-04-23 13:34 ` [PATCH v3] libmultipath: " Levy, Jerome
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.