radeon pm questions

radeon pm questions

[Sylvain BERTRAND]

Hi,

I have a few questions about radeon pm code:

----
In radeon_atombios.c, radeon_atombios_parse_power_table_6
function, power_state->v2.nonClockInfoIndex for non_clock_info of
one state is ignored and replaced by the state index, referencing
an iguana bug.

Is it still buggy from southern island and we must keep ignoring
power_state->v2.nonClockInfoIndex for good and use the state
index to reference the right state description in non clock array
table?
----

----
The same does happen for the clock info index which can be out of
range. Same treat as above?
----

----
In radeon_atombios.c, radeon_atombios_parse_pplib_clock_info
function, code paths are selected based on DCE generation. The
same happens in radeon_atombios_parse_pplib_non_clock_info
function.  Should it rather be the chip family? Or current
powerplay code does deal only with the DCE block??
----

regards,

-- 
Sylvain

Re: radeon pm questions

[Alex Deucher]

On Sun, Apr 28, 2013 at 9:26 PM, Sylvain BERTRAND <sylware@legeek.net> wrote:
> Hi,
>
> I have a few questions about radeon pm code:
>
> ----
> In radeon_atombios.c, radeon_atombios_parse_power_table_6
> function, power_state->v2.nonClockInfoIndex for non_clock_info of
> one state is ignored and replaced by the state index, referencing
> an iguana bug.
>
> Is it still buggy from southern island and we must keep ignoring
> power_state->v2.nonClockInfoIndex for good and use the state
> index to reference the right state description in non clock array
> table?

nonClockInfoIndex isn't used and produces bogus tables.  The index
should be used.

> ----
>
> ----
> The same does happen for the clock info index which can be out of
> range. Same treat as above?


Yes, although, at this point, it's mostly for safety.  You shouldn't
see it in practice.

> ----
>
> ----
> In radeon_atombios.c, radeon_atombios_parse_pplib_clock_info
> function, code paths are selected based on DCE generation. The
> same happens in radeon_atombios_parse_pplib_non_clock_info
> function.  Should it rather be the chip family? Or current
> powerplay code does deal only with the DCE block??

It should be chip family.  I just used the DCE check since it
corresponds to the same relevant families.  I'll fix that.

Alex

> ----
>
> regards,
>
> --
> Sylvain
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel