From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Thommy Jakobsson <thommyj@gmail.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, piotras@gmail.com,
Larry.Finger@lwfinger.net
Subject: [PATCH] B43: Handle DMA RX descriptor underrun
Date: Sun, 5 May 2013 19:24:05 +0200 [thread overview]
Message-ID: <20130505192405.0cf4350e@milhouse> (raw)
In-Reply-To: <CACna6ry+F45PhCXahPpJtzu-w+vLE29ksHo9njXfTcfY3Av6LA@mail.gmail.com>
On Sun, 5 May 2013 18:31:20 +0200
Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> Still worth considering is my previous e-mail. Why writing (for
> example) 1 to RXSTOPINDEX doesn't stop firmware from using slot 1?
What makes you think this register does not work?
Do you write a 1 to the register, or do you mean "the offset that
corresponds to slot 1"?
> Can it be because it's "too late"? For example:
> 1) Firmware writes to slot 0, changes "curr descr" to 1
> 2) Firmware grabs slot 1
> 3) Firmware generates IRQ
> 4) Driver reads slot 0
> 5) Driver writes RX stop index 1
The stop index is the index that the firmware does _not_ write to.
If you set it _after_ it already wrote, you clearly are too late (for
this ring wrapping).
--
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20130505/847ac76c/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Thommy Jakobsson <thommyj@gmail.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, piotras@gmail.com,
Larry.Finger@lwfinger.net
Subject: Re: [PATCH] B43: Handle DMA RX descriptor underrun
Date: Sun, 5 May 2013 19:24:05 +0200 [thread overview]
Message-ID: <20130505192405.0cf4350e@milhouse> (raw)
In-Reply-To: <CACna6ry+F45PhCXahPpJtzu-w+vLE29ksHo9njXfTcfY3Av6LA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On Sun, 5 May 2013 18:31:20 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> Still worth considering is my previous e-mail. Why writing (for
> example) 1 to RXSTOPINDEX doesn't stop firmware from using slot 1?
What makes you think this register does not work?
Do you write a 1 to the register, or do you mean "the offset that
corresponds to slot 1"?
> Can it be because it's "too late"? For example:
> 1) Firmware writes to slot 0, changes "curr descr" to 1
> 2) Firmware grabs slot 1
> 3) Firmware generates IRQ
> 4) Driver reads slot 0
> 5) Driver writes RX stop index 1
The stop index is the index that the firmware does _not_ write to.
If you set it _after_ it already wrote, you clearly are too late (for
this ring wrapping).
--
Michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-05-05 17:24 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 19:45 [PATCH] B43: Handle DMA RX descriptor underrun Thommy Jakobsson
2013-04-23 20:33 ` [PATCH] b43: rename stop-index DMA op Michael Büsch
2013-04-23 20:33 ` Michael Büsch
2013-04-24 7:00 ` [PATCH] B43: Handle DMA RX descriptor underrun Rafał Miłecki
2013-04-24 7:00 ` Rafał Miłecki
2013-05-03 17:35 ` John W. Linville
2013-05-03 19:40 ` Thommy Jakobsson
2013-05-03 19:40 ` Thommy Jakobsson
2013-05-02 13:06 ` Michael Büsch
2013-05-02 13:06 ` Michael Büsch
2013-05-02 15:01 ` Larry Finger
2013-05-02 15:01 ` Larry Finger
2013-05-05 12:44 ` Rafał Miłecki
2013-05-05 12:44 ` Rafał Miłecki
2013-05-05 13:56 ` Michael Büsch
2013-05-05 13:56 ` Michael Büsch
2013-05-05 15:34 ` Rafał Miłecki
2013-05-05 15:34 ` Rafał Miłecki
2013-05-05 19:09 ` Thommy Jakobsson
2013-05-05 19:09 ` Thommy Jakobsson
2013-05-05 15:43 ` Rafał Miłecki
2013-05-05 15:43 ` Rafał Miłecki
2013-05-05 16:31 ` Rafał Miłecki
2013-05-05 16:31 ` Rafał Miłecki
2013-05-05 17:24 ` Michael Büsch [this message]
2013-05-05 17:24 ` Michael Büsch
2013-05-05 19:50 ` Rafał Miłecki
2013-05-05 19:50 ` Rafał Miłecki
2013-05-05 19:58 ` Michael Büsch
2013-05-05 19:58 ` Michael Büsch
2013-05-05 20:06 ` Thommy Jakobsson
2013-05-05 20:06 ` Thommy Jakobsson
2013-05-05 19:59 ` Thommy Jakobsson
2013-05-05 19:59 ` Thommy Jakobsson
2013-05-05 19:22 ` Larry Finger
2013-05-05 19:22 ` Larry Finger
2013-05-13 18:27 ` Thommy Jakobsson
2013-05-13 18:27 ` Thommy Jakobsson
2013-05-24 16:49 ` John W. Linville
2013-05-24 16:49 ` John W. Linville
2013-05-25 19:02 ` Thommy Jakobsson
2013-05-25 19:02 ` Thommy Jakobsson
2013-05-25 19:37 ` Hauke Mehrtens
2013-05-25 19:37 ` Hauke Mehrtens
2013-05-25 19:42 ` Michael Büsch
2013-05-25 19:42 ` Michael Büsch
2013-05-25 20:37 ` Larry Finger
2013-05-25 20:37 ` Larry Finger
2013-05-28 17:37 ` John W. Linville
2013-05-28 17:37 ` John W. Linville
2013-06-10 9:40 ` Rafał Miłecki
2013-06-10 9:40 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130505192405.0cf4350e@milhouse \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=piotras@gmail.com \
--cc=thommyj@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.