From: "J. Bruce Fields" <bfields@fieldses.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Simo Sorce <simo@redhat.com>,
Stanislav Kinsbursky <skinsbursky@parallels.com>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] svcauth_gss: fix error code in use_gss_proxy()
Date: Sat, 11 May 2013 18:43:35 +0000 [thread overview]
Message-ID: <20130511184335.GD15765@fieldses.org> (raw)
In-Reply-To: <20130511161349.GA20451@elgon.mountain>
On Sat, May 11, 2013 at 07:13:49PM +0300, Dan Carpenter wrote:
> This should return zero on success and -EBUSY on error so the type
> needs to be int instead of bool.
Oops, you're right--thanks. Applying.--b.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
> index 871c73c..2c6a1ec 100644
> --- a/net/sunrpc/auth_gss/svcauth_gss.c
> +++ b/net/sunrpc/auth_gss/svcauth_gss.c
> @@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)
>
> #ifdef CONFIG_PROC_FS
>
> -static bool set_gss_proxy(struct net *net, int type)
> +static int set_gss_proxy(struct net *net, int type)
> {
> struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
> int ret = 0;
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Simo Sorce <simo@redhat.com>,
Stanislav Kinsbursky <skinsbursky@parallels.com>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] svcauth_gss: fix error code in use_gss_proxy()
Date: Sat, 11 May 2013 14:43:35 -0400 [thread overview]
Message-ID: <20130511184335.GD15765@fieldses.org> (raw)
In-Reply-To: <20130511161349.GA20451@elgon.mountain>
On Sat, May 11, 2013 at 07:13:49PM +0300, Dan Carpenter wrote:
> This should return zero on success and -EBUSY on error so the type
> needs to be int instead of bool.
Oops, you're right--thanks. Applying.--b.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
> index 871c73c..2c6a1ec 100644
> --- a/net/sunrpc/auth_gss/svcauth_gss.c
> +++ b/net/sunrpc/auth_gss/svcauth_gss.c
> @@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)
>
> #ifdef CONFIG_PROC_FS
>
> -static bool set_gss_proxy(struct net *net, int type)
> +static int set_gss_proxy(struct net *net, int type)
> {
> struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
> int ret = 0;
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Trond Myklebust
<Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
Simo Sorce <simo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Stanislav Kinsbursky
<skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>,
Wei Yongjun
<yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] svcauth_gss: fix error code in use_gss_proxy()
Date: Sat, 11 May 2013 14:43:35 -0400 [thread overview]
Message-ID: <20130511184335.GD15765@fieldses.org> (raw)
In-Reply-To: <20130511161349.GA20451-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
On Sat, May 11, 2013 at 07:13:49PM +0300, Dan Carpenter wrote:
> This should return zero on success and -EBUSY on error so the type
> needs to be int instead of bool.
Oops, you're right--thanks. Applying.--b.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
> index 871c73c..2c6a1ec 100644
> --- a/net/sunrpc/auth_gss/svcauth_gss.c
> +++ b/net/sunrpc/auth_gss/svcauth_gss.c
> @@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)
>
> #ifdef CONFIG_PROC_FS
>
> -static bool set_gss_proxy(struct net *net, int type)
> +static int set_gss_proxy(struct net *net, int type)
> {
> struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
> int ret = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-05-11 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 16:13 [patch] svcauth_gss: fix error code in use_gss_proxy() Dan Carpenter
2013-05-11 16:13 ` Dan Carpenter
2013-05-11 18:43 ` J. Bruce Fields [this message]
2013-05-11 18:43 ` J. Bruce Fields
2013-05-11 18:43 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130511184335.GD15765@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simo@redhat.com \
--cc=skinsbursky@parallels.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.