* [patch] svcauth_gss: fix error code in use_gss_proxy()
@ 2013-05-11 16:13 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2013-05-11 16:13 UTC (permalink / raw)
To: J. Bruce Fields
Cc: Trond Myklebust, David S. Miller, Eric W. Biederman, Simo Sorce,
Stanislav Kinsbursky, Wei Yongjun, linux-nfs, netdev,
kernel-janitors
This should return zero on success and -EBUSY on error so the type
needs to be int instead of bool.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
index 871c73c..2c6a1ec 100644
--- a/net/sunrpc/auth_gss/svcauth_gss.c
+++ b/net/sunrpc/auth_gss/svcauth_gss.c
@@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)
#ifdef CONFIG_PROC_FS
-static bool set_gss_proxy(struct net *net, int type)
+static int set_gss_proxy(struct net *net, int type)
{
struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
int ret = 0;
^ permalink raw reply related [flat|nested] 5+ messages in thread* [patch] svcauth_gss: fix error code in use_gss_proxy()
@ 2013-05-11 16:13 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2013-05-11 16:13 UTC (permalink / raw)
To: J. Bruce Fields
Cc: Trond Myklebust, David S. Miller, Eric W. Biederman, Simo Sorce,
Stanislav Kinsbursky, Wei Yongjun, linux-nfs, netdev,
kernel-janitors
This should return zero on success and -EBUSY on error so the type
needs to be int instead of bool.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
index 871c73c..2c6a1ec 100644
--- a/net/sunrpc/auth_gss/svcauth_gss.c
+++ b/net/sunrpc/auth_gss/svcauth_gss.c
@@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)
#ifdef CONFIG_PROC_FS
-static bool set_gss_proxy(struct net *net, int type)
+static int set_gss_proxy(struct net *net, int type)
{
struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
int ret = 0;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [patch] svcauth_gss: fix error code in use_gss_proxy()
2013-05-11 16:13 ` Dan Carpenter
(?)
@ 2013-05-11 18:43 ` J. Bruce Fields
-1 siblings, 0 replies; 5+ messages in thread
From: J. Bruce Fields @ 2013-05-11 18:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Trond Myklebust, David S. Miller, Eric W. Biederman, Simo Sorce,
Stanislav Kinsbursky, Wei Yongjun, linux-nfs, netdev,
kernel-janitors
On Sat, May 11, 2013 at 07:13:49PM +0300, Dan Carpenter wrote:
> This should return zero on success and -EBUSY on error so the type
> needs to be int instead of bool.
Oops, you're right--thanks. Applying.--b.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
> index 871c73c..2c6a1ec 100644
> --- a/net/sunrpc/auth_gss/svcauth_gss.c
> +++ b/net/sunrpc/auth_gss/svcauth_gss.c
> @@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)
>
> #ifdef CONFIG_PROC_FS
>
> -static bool set_gss_proxy(struct net *net, int type)
> +static int set_gss_proxy(struct net *net, int type)
> {
> struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
> int ret = 0;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] svcauth_gss: fix error code in use_gss_proxy()
@ 2013-05-11 18:43 ` J. Bruce Fields
0 siblings, 0 replies; 5+ messages in thread
From: J. Bruce Fields @ 2013-05-11 18:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Trond Myklebust, David S. Miller, Eric W. Biederman, Simo Sorce,
Stanislav Kinsbursky, Wei Yongjun,
linux-nfs-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Sat, May 11, 2013 at 07:13:49PM +0300, Dan Carpenter wrote:
> This should return zero on success and -EBUSY on error so the type
> needs to be int instead of bool.
Oops, you're right--thanks. Applying.--b.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
> index 871c73c..2c6a1ec 100644
> --- a/net/sunrpc/auth_gss/svcauth_gss.c
> +++ b/net/sunrpc/auth_gss/svcauth_gss.c
> @@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)
>
> #ifdef CONFIG_PROC_FS
>
> -static bool set_gss_proxy(struct net *net, int type)
> +static int set_gss_proxy(struct net *net, int type)
> {
> struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
> int ret = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] svcauth_gss: fix error code in use_gss_proxy()
@ 2013-05-11 18:43 ` J. Bruce Fields
0 siblings, 0 replies; 5+ messages in thread
From: J. Bruce Fields @ 2013-05-11 18:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Trond Myklebust, David S. Miller, Eric W. Biederman, Simo Sorce,
Stanislav Kinsbursky, Wei Yongjun, linux-nfs, netdev,
kernel-janitors
On Sat, May 11, 2013 at 07:13:49PM +0300, Dan Carpenter wrote:
> This should return zero on success and -EBUSY on error so the type
> needs to be int instead of bool.
Oops, you're right--thanks. Applying.--b.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
> index 871c73c..2c6a1ec 100644
> --- a/net/sunrpc/auth_gss/svcauth_gss.c
> +++ b/net/sunrpc/auth_gss/svcauth_gss.c
> @@ -1287,7 +1287,7 @@ static bool use_gss_proxy(struct net *net)
>
> #ifdef CONFIG_PROC_FS
>
> -static bool set_gss_proxy(struct net *net, int type)
> +static int set_gss_proxy(struct net *net, int type)
> {
> struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
> int ret = 0;
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-11 18:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-11 16:13 [patch] svcauth_gss: fix error code in use_gss_proxy() Dan Carpenter
2013-05-11 16:13 ` Dan Carpenter
2013-05-11 18:43 ` J. Bruce Fields
2013-05-11 18:43 ` J. Bruce Fields
2013-05-11 18:43 ` J. Bruce Fields
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.