All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rafael Aquini <aquini@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, riel@redhat.com, amit.shah@redhat.com,
	anton@enomsg.org
Subject: Re: [RFC 2/2] virtio_balloon: auto-ballooning support
Date: Mon, 13 May 2013 16:01:26 -0400	[thread overview]
Message-ID: <20130513160126.4d196719@redhat.com> (raw)
In-Reply-To: <20130513190250.GA2496@redhat.com>

On Mon, 13 May 2013 22:02:50 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, May 13, 2013 at 02:25:11PM -0400, Luiz Capitulino wrote:
> > On Mon, 13 May 2013 11:34:41 -0300
> > Rafael Aquini <aquini@redhat.com> wrote:
> > 
> > > You're right, and the host's member is used to communicate the configured size
> > > to guest's balloon device, however, by not changing it when the shrinker causes 
> > > the balloon to deflate will make the balloon thread to be woken up again 
> > > in order to chase the balloon size target again, won't it? Check
> > 
> > I don't see the balloon thread waking up after the shrinker executes in my
> > testing. Maybe this is so because it will only wake up when QEMU notifies
> > a config change.
> 
> Well that's also a problem.
> Need some mechanism to re-inflate balloon

In this implemention this is done by QEMU, have you looked at the QEMU
patch yet?

 https://lists.gnu.org/archive/html/qemu-devel/2013-05/msg01295.html

> when guest memory pressure is down.

In this implementation we do this when there's pressure in the host. I expect
things to balance over time, and this seems to be what I'm observing in my
testing, but of course we need more testing.

> virtio fs mechanism worth a look?

Can you elaborate?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Luiz Capitulino <lcapitulino@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rafael Aquini <aquini@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, riel@redhat.com, amit.shah@redhat.com,
	anton@enomsg.org
Subject: Re: [RFC 2/2] virtio_balloon: auto-ballooning support
Date: Mon, 13 May 2013 16:01:26 -0400	[thread overview]
Message-ID: <20130513160126.4d196719@redhat.com> (raw)
In-Reply-To: <20130513190250.GA2496@redhat.com>

On Mon, 13 May 2013 22:02:50 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, May 13, 2013 at 02:25:11PM -0400, Luiz Capitulino wrote:
> > On Mon, 13 May 2013 11:34:41 -0300
> > Rafael Aquini <aquini@redhat.com> wrote:
> > 
> > > You're right, and the host's member is used to communicate the configured size
> > > to guest's balloon device, however, by not changing it when the shrinker causes 
> > > the balloon to deflate will make the balloon thread to be woken up again 
> > > in order to chase the balloon size target again, won't it? Check
> > 
> > I don't see the balloon thread waking up after the shrinker executes in my
> > testing. Maybe this is so because it will only wake up when QEMU notifies
> > a config change.
> 
> Well that's also a problem.
> Need some mechanism to re-inflate balloon

In this implemention this is done by QEMU, have you looked at the QEMU
patch yet?

 https://lists.gnu.org/archive/html/qemu-devel/2013-05/msg01295.html

> when guest memory pressure is down.

In this implementation we do this when there's pressure in the host. I expect
things to balance over time, and this seems to be what I'm observing in my
testing, but of course we need more testing.

> virtio fs mechanism worth a look?

Can you elaborate?

  reply	other threads:[~2013-05-13 20:01 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09 14:53 [RFC v2 0/2] virtio_balloon: auto-ballooning support Luiz Capitulino
2013-05-09 14:53 ` Luiz Capitulino
2013-05-09 14:53 ` [RFC 1/2] virtio_balloon: move balloon_lock mutex to callers Luiz Capitulino
2013-05-09 14:53   ` Luiz Capitulino
2013-05-09 21:03   ` Rafael Aquini
2013-05-09 21:03     ` Rafael Aquini
2013-05-10 12:52     ` Luiz Capitulino
2013-05-10 12:52       ` Luiz Capitulino
2013-05-09 14:53 ` [RFC 2/2] virtio_balloon: auto-ballooning support Luiz Capitulino
2013-05-09 14:53   ` Luiz Capitulino
2013-05-09 21:15   ` Rafael Aquini
2013-05-09 21:15     ` Rafael Aquini
2013-05-10 13:20     ` Luiz Capitulino
2013-05-10 13:20       ` Luiz Capitulino
2013-05-10 13:28       ` Luiz Capitulino
2013-05-10 13:28         ` Luiz Capitulino
2013-05-13 14:34       ` Rafael Aquini
2013-05-13 14:34         ` Rafael Aquini
2013-05-13 18:25         ` Luiz Capitulino
2013-05-13 18:25           ` Luiz Capitulino
2013-05-13 19:02           ` Michael S. Tsirkin
2013-05-13 19:02             ` Michael S. Tsirkin
2013-05-13 20:01             ` Luiz Capitulino [this message]
2013-05-13 20:01               ` Luiz Capitulino
2013-05-12 14:30   ` Michael S. Tsirkin
2013-05-12 14:30     ` Michael S. Tsirkin
2013-05-12 16:36     ` Rik van Riel
2013-05-12 16:36       ` Rik van Riel
2013-05-12 18:49       ` Michael S. Tsirkin
2013-05-12 18:49         ` Michael S. Tsirkin
2013-05-13 15:03         ` Luiz Capitulino
2013-05-13 15:03           ` Luiz Capitulino
2013-05-13 15:16           ` Michael S. Tsirkin
2013-05-13 15:16             ` Michael S. Tsirkin
2013-05-13 15:22             ` Rik van Riel
2013-05-13 15:22               ` Rik van Riel
2013-05-13 15:35               ` Michael S. Tsirkin
2013-05-13 15:35                 ` Michael S. Tsirkin
2013-05-13 19:10                 ` Rik van Riel
2013-05-13 19:10                   ` Rik van Riel
2013-05-13 19:21                   ` Michael S. Tsirkin
2013-05-13 19:21                     ` Michael S. Tsirkin
2013-05-16 20:56 ` [RFC v2 0/2] " Sasha Levin
2013-05-16 20:56   ` Sasha Levin
2013-05-16 21:04   ` Luiz Capitulino
2013-05-16 21:04     ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130513160126.4d196719@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=anton@enomsg.org \
    --cc=aquini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mst@redhat.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.