From: Vivek Goyal <vgoyal@redhat.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: Rik Van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
lisa.mitchell@hp.com, linux-mm@kvack.org,
kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com,
zhangyanfei@cn.fujitsu.com, akpm@linux-foundation.org,
Michel Lespinasse <walken@google.com>,
cpw@sgi.com, jingbai.ma@hp.com
Subject: Re: [PATCH v5 3/8] vmalloc: make find_vm_area check in range
Date: Tue, 14 May 2013 10:50:03 -0400 [thread overview]
Message-ID: <20130514145003.GC16772@redhat.com> (raw)
In-Reply-To: <20130514015723.18697.34468.stgit@localhost6.localdomain6>
On Tue, May 14, 2013 at 10:57:23AM +0900, HATAYAMA Daisuke wrote:
> Currently, __find_vmap_area searches for the kernel VM area starting
> at a given address. This patch changes this behavior so that it
> searches for the kernel VM area to which the address belongs. This
> change is needed by remap_vmalloc_range_partial to be introduced in
> later patch that receives any position of kernel VM area as target
> address.
>
> This patch changes the condition (addr > va->va_start) to the
> equivalent (addr >= va->va_end) by taking advantage of the fact that
> each kernel VM area is non-overlapping.
>
> Signed-off-by: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
This will require ack from mm folks. CCing some of them.
Thanks
Vivek
> ---
>
> mm/vmalloc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index d365724..3875fa2 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -292,7 +292,7 @@ static struct vmap_area *__find_vmap_area(unsigned long addr)
> va = rb_entry(n, struct vmap_area, rb_node);
> if (addr < va->va_start)
> n = n->rb_left;
> - else if (addr > va->va_start)
> + else if (addr >= va->va_end)
> n = n->rb_right;
> else
> return va;
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com,
kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
zhangyanfei@cn.fujitsu.com, jingbai.ma@hp.com,
linux-mm@kvack.org, Rik Van Riel <riel@redhat.com>,
Michel Lespinasse <walken@google.com>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v5 3/8] vmalloc: make find_vm_area check in range
Date: Tue, 14 May 2013 10:50:03 -0400 [thread overview]
Message-ID: <20130514145003.GC16772@redhat.com> (raw)
In-Reply-To: <20130514015723.18697.34468.stgit@localhost6.localdomain6>
On Tue, May 14, 2013 at 10:57:23AM +0900, HATAYAMA Daisuke wrote:
> Currently, __find_vmap_area searches for the kernel VM area starting
> at a given address. This patch changes this behavior so that it
> searches for the kernel VM area to which the address belongs. This
> change is needed by remap_vmalloc_range_partial to be introduced in
> later patch that receives any position of kernel VM area as target
> address.
>
> This patch changes the condition (addr > va->va_start) to the
> equivalent (addr >= va->va_end) by taking advantage of the fact that
> each kernel VM area is non-overlapping.
>
> Signed-off-by: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
This will require ack from mm folks. CCing some of them.
Thanks
Vivek
> ---
>
> mm/vmalloc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index d365724..3875fa2 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -292,7 +292,7 @@ static struct vmap_area *__find_vmap_area(unsigned long addr)
> va = rb_entry(n, struct vmap_area, rb_node);
> if (addr < va->va_start)
> n = n->rb_left;
> - else if (addr > va->va_start)
> + else if (addr >= va->va_end)
> n = n->rb_right;
> else
> return va;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com,
kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
zhangyanfei@cn.fujitsu.com, jingbai.ma@hp.com,
linux-mm@kvack.org, Rik Van Riel <riel@redhat.com>,
Michel Lespinasse <walken@google.com>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v5 3/8] vmalloc: make find_vm_area check in range
Date: Tue, 14 May 2013 10:50:03 -0400 [thread overview]
Message-ID: <20130514145003.GC16772@redhat.com> (raw)
In-Reply-To: <20130514015723.18697.34468.stgit@localhost6.localdomain6>
On Tue, May 14, 2013 at 10:57:23AM +0900, HATAYAMA Daisuke wrote:
> Currently, __find_vmap_area searches for the kernel VM area starting
> at a given address. This patch changes this behavior so that it
> searches for the kernel VM area to which the address belongs. This
> change is needed by remap_vmalloc_range_partial to be introduced in
> later patch that receives any position of kernel VM area as target
> address.
>
> This patch changes the condition (addr > va->va_start) to the
> equivalent (addr >= va->va_end) by taking advantage of the fact that
> each kernel VM area is non-overlapping.
>
> Signed-off-by: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
This will require ack from mm folks. CCing some of them.
Thanks
Vivek
> ---
>
> mm/vmalloc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index d365724..3875fa2 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -292,7 +292,7 @@ static struct vmap_area *__find_vmap_area(unsigned long addr)
> va = rb_entry(n, struct vmap_area, rb_node);
> if (addr < va->va_start)
> n = n->rb_left;
> - else if (addr > va->va_start)
> + else if (addr >= va->va_end)
> n = n->rb_right;
> else
> return va;
next prev parent reply other threads:[~2013-05-14 14:50 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 1:57 [PATCH v5 0/8] kdump, vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 1:57 ` [PATCH v5 1/8] vmcore: allocate buffer for ELF headers on page-size alignment HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 14:45 ` Vivek Goyal
2013-05-14 14:45 ` Vivek Goyal
2013-05-14 14:45 ` Vivek Goyal
2013-05-14 1:57 ` [PATCH v5 2/8] vmcore: clean up read_vmcore() HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 14:46 ` Vivek Goyal
2013-05-14 14:46 ` Vivek Goyal
2013-05-14 14:46 ` Vivek Goyal
2013-05-14 1:57 ` [PATCH v5 3/8] vmalloc: make find_vm_area check in range HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 14:50 ` Vivek Goyal [this message]
2013-05-14 14:50 ` Vivek Goyal
2013-05-14 14:50 ` Vivek Goyal
2013-05-14 1:57 ` [PATCH v5 4/8] vmalloc: introduce remap_vmalloc_range_partial HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 14:59 ` Vivek Goyal
2013-05-14 14:59 ` Vivek Goyal
2013-05-14 14:59 ` Vivek Goyal
2013-05-14 1:57 ` [PATCH v5 5/8] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 15:35 ` Vivek Goyal
2013-05-14 15:35 ` Vivek Goyal
2013-05-14 15:35 ` Vivek Goyal
2013-05-15 8:29 ` HATAYAMA Daisuke
2013-05-15 8:29 ` HATAYAMA Daisuke
2013-05-15 8:29 ` HATAYAMA Daisuke
2013-05-14 15:57 ` Vivek Goyal
2013-05-14 15:57 ` Vivek Goyal
2013-05-14 15:57 ` Vivek Goyal
2013-05-14 1:57 ` [PATCH v5 6/8] vmcore: treat memory chunks referenced by PT_LOAD program header entries in page-size boundary in vmcore_list HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 16:42 ` Vivek Goyal
2013-05-14 16:42 ` Vivek Goyal
2013-05-14 16:42 ` Vivek Goyal
2013-05-14 1:57 ` [PATCH v5 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 16:47 ` Vivek Goyal
2013-05-14 16:47 ` Vivek Goyal
2013-05-14 16:47 ` Vivek Goyal
2013-05-15 8:25 ` HATAYAMA Daisuke
2013-05-15 8:25 ` HATAYAMA Daisuke
2013-05-15 8:25 ` HATAYAMA Daisuke
2013-05-14 1:57 ` [PATCH v5 8/8] vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
2013-05-14 1:57 ` HATAYAMA Daisuke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130514145003.GC16772@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cpw@sgi.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=ebiederm@xmission.com \
--cc=hughd@google.com \
--cc=jingbai.ma@hp.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lisa.mitchell@hp.com \
--cc=riel@redhat.com \
--cc=walken@google.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.