Re: [PATCH v5 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects

All of lore.kernel.org
 help / color / mirror / Atom feed

From: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	lisa.mitchell@hp.com, linux-mm@kvack.org,
	kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com,
	zhangyanfei@cn.fujitsu.com, akpm@linux-foundation.org,
	cpw@sgi.com, jingbai.ma@hp.com
Subject: Re: [PATCH v5 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects
Date: Wed, 15 May 2013 17:25:41 +0900	[thread overview]
Message-ID: <51934685.9080909@jp.fujitsu.com> (raw)
In-Reply-To: <20130514164739.GJ13674@redhat.com>

(2013/05/15 1:47), Vivek Goyal wrote:
> On Tue, May 14, 2013 at 10:57:46AM +0900, HATAYAMA Daisuke wrote:
>> The previous patches newly added holes before each chunk of memory and
>> the holes need to be count in vmcore file size. There are two ways to
>> count file size in such a way:
>>
>> 1) supporse p as a poitner to the last program header entry with
>> PT_LOAD type, then roundup(p->p_offset + p->p_memsz, PAGE_SIZE), or

This part was wrong. This should have been:

1) support m as a pointer to the last vmcore object in vmcore_list, then 
file size is (m->offset + m->size), or

I'll correct this way in next patch.

Note that no functional change, only description is wrong here.

-- 
Thanks.
HATAYAMA, Daisuke


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)

From: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com,
	kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	zhangyanfei@cn.fujitsu.com, jingbai.ma@hp.com,
	linux-mm@kvack.org
Subject: Re: [PATCH v5 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects
Date: Wed, 15 May 2013 17:25:41 +0900	[thread overview]
Message-ID: <51934685.9080909@jp.fujitsu.com> (raw)
In-Reply-To: <20130514164739.GJ13674@redhat.com>

(2013/05/15 1:47), Vivek Goyal wrote:
> On Tue, May 14, 2013 at 10:57:46AM +0900, HATAYAMA Daisuke wrote:
>> The previous patches newly added holes before each chunk of memory and
>> the holes need to be count in vmcore file size. There are two ways to
>> count file size in such a way:
>>
>> 1) supporse p as a poitner to the last program header entry with
>> PT_LOAD type, then roundup(p->p_offset + p->p_memsz, PAGE_SIZE), or

This part was wrong. This should have been:

1) support m as a pointer to the last vmcore object in vmcore_list, then 
file size is (m->offset + m->size), or

I'll correct this way in next patch.

Note that no functional change, only description is wrong here.

-- 
Thanks.
HATAYAMA, Daisuke

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)

From: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com,
	kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	zhangyanfei@cn.fujitsu.com, jingbai.ma@hp.com,
	linux-mm@kvack.org
Subject: Re: [PATCH v5 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects
Date: Wed, 15 May 2013 17:25:41 +0900	[thread overview]
Message-ID: <51934685.9080909@jp.fujitsu.com> (raw)
In-Reply-To: <20130514164739.GJ13674@redhat.com>

(2013/05/15 1:47), Vivek Goyal wrote:
> On Tue, May 14, 2013 at 10:57:46AM +0900, HATAYAMA Daisuke wrote:
>> The previous patches newly added holes before each chunk of memory and
>> the holes need to be count in vmcore file size. There are two ways to
>> count file size in such a way:
>>
>> 1) supporse p as a poitner to the last program header entry with
>> PT_LOAD type, then roundup(p->p_offset + p->p_memsz, PAGE_SIZE), or

This part was wrong. This should have been:

1) support m as a pointer to the last vmcore object in vmcore_list, then 
file size is (m->offset + m->size), or

I'll correct this way in next patch.

Note that no functional change, only description is wrong here.

-- 
Thanks.
HATAYAMA, Daisuke

next prev parent reply	other threads:[~2013-05-15  8:26 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14  1:57 [PATCH v5 0/8] kdump, vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-05-14  1:57 ` HATAYAMA Daisuke
2013-05-14  1:57 ` HATAYAMA Daisuke
2013-05-14  1:57 ` [PATCH v5 1/8] vmcore: allocate buffer for ELF headers on page-size alignment HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14 14:45   ` Vivek Goyal
2013-05-14 14:45     ` Vivek Goyal
2013-05-14 14:45     ` Vivek Goyal
2013-05-14  1:57 ` [PATCH v5 2/8] vmcore: clean up read_vmcore() HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14 14:46   ` Vivek Goyal
2013-05-14 14:46     ` Vivek Goyal
2013-05-14 14:46     ` Vivek Goyal
2013-05-14  1:57 ` [PATCH v5 3/8] vmalloc: make find_vm_area check in range HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14 14:50   ` Vivek Goyal
2013-05-14 14:50     ` Vivek Goyal
2013-05-14 14:50     ` Vivek Goyal
2013-05-14  1:57 ` [PATCH v5 4/8] vmalloc: introduce remap_vmalloc_range_partial HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14 14:59   ` Vivek Goyal
2013-05-14 14:59     ` Vivek Goyal
2013-05-14 14:59     ` Vivek Goyal
2013-05-14  1:57 ` [PATCH v5 5/8] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14 15:35   ` Vivek Goyal
2013-05-14 15:35     ` Vivek Goyal
2013-05-14 15:35     ` Vivek Goyal
2013-05-15  8:29     ` HATAYAMA Daisuke
2013-05-15  8:29       ` HATAYAMA Daisuke
2013-05-15  8:29       ` HATAYAMA Daisuke
2013-05-14 15:57   ` Vivek Goyal
2013-05-14 15:57     ` Vivek Goyal
2013-05-14 15:57     ` Vivek Goyal
2013-05-14  1:57 ` [PATCH v5 6/8] vmcore: treat memory chunks referenced by PT_LOAD program header entries in page-size boundary in vmcore_list HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14 16:42   ` Vivek Goyal
2013-05-14 16:42     ` Vivek Goyal
2013-05-14 16:42     ` Vivek Goyal
2013-05-14  1:57 ` [PATCH v5 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14 16:47   ` Vivek Goyal
2013-05-14 16:47     ` Vivek Goyal
2013-05-14 16:47     ` Vivek Goyal
2013-05-15  8:25     ` HATAYAMA Daisuke [this message]
2013-05-15  8:25       ` HATAYAMA Daisuke
2013-05-15  8:25       ` HATAYAMA Daisuke
2013-05-14  1:57 ` [PATCH v5 8/8] vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke
2013-05-14  1:57   ` HATAYAMA Daisuke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51934685.9080909@jp.fujitsu.com \
    --to=d.hatayama@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=cpw@sgi.com \
    --cc=ebiederm@xmission.com \
    --cc=jingbai.ma@hp.com \
    --cc=kexec@lists.infradead.org \
    --cc=kumagai-atsushi@mxc.nes.nec.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lisa.mitchell@hp.com \
    --cc=vgoyal@redhat.com \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.