All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Libo Chen <libo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Sonic.Zhang-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org,
	uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v2 0/2] i2c: fix two wrong mem release
Date: Fri, 17 May 2013 11:43:04 +0200	[thread overview]
Message-ID: <20130517094301.GH17056@katana> (raw)
In-Reply-To: <1368088044-20408-1-git-send-email-libo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

On Thu, May 09, 2013 at 04:27:22PM +0800, Libo Chen wrote:
> fix two wrong mem release
> 
> * Changelog from v1:
>   * exchange out_error_no_irq and out_error_pin_mux  suggested by Sonic <Sonic.Zhang-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>  
>   * add some new tag , make code cleanly

Thanks for the submission. I do think the proper solution would be to
convert the drivers to use the devm_* mechanisms, though. You can check
commit 857968434bb6dbda0911f38ec46b0c3d0c963771 ("i2c: davinci: update
to devm_* API") as a reference.

Thanks,

   Wolfram

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Libo Chen <libo.chen@huawei.com>
Cc: Sonic.Zhang@analog.com, uclinux-dist-devel@blackfin.uclinux.org,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
	lizefan@huawei.com
Subject: Re: [PATCH v2 0/2] i2c: fix two wrong mem release
Date: Fri, 17 May 2013 11:43:04 +0200	[thread overview]
Message-ID: <20130517094301.GH17056@katana> (raw)
In-Reply-To: <1368088044-20408-1-git-send-email-libo.chen@huawei.com>

On Thu, May 09, 2013 at 04:27:22PM +0800, Libo Chen wrote:
> fix two wrong mem release
> 
> * Changelog from v1:
>   * exchange out_error_no_irq and out_error_pin_mux  suggested by Sonic <Sonic.Zhang@analog.com>  
>   * add some new tag , make code cleanly

Thanks for the submission. I do think the proper solution would be to
convert the drivers to use the devm_* mechanisms, though. You can check
commit 857968434bb6dbda0911f38ec46b0c3d0c963771 ("i2c: davinci: update
to devm_* API") as a reference.

Thanks,

   Wolfram

  parent reply	other threads:[~2013-05-17  9:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09  8:27 [PATCH v2 0/2] i2c: fix two wrong mem release Libo Chen
2013-05-09  8:27 ` Libo Chen
2013-05-09  8:27 ` [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init successful Libo Chen
2013-05-09  8:27   ` Libo Chen
     [not found]   ` <1368088044-20408-2-git-send-email-libo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-09  8:31     ` Zhang, Sonic
2013-05-09  8:31       ` Zhang, Sonic
2013-05-09  8:33     ` Zhang, Sonic
2013-05-09  8:33       ` Zhang, Sonic
     [not found]       ` <B168F8A49F4BCF4C84FD23DA5F6363EEAD57-Nxh9ahLCS6GuVPpjEGsWsTcYPEmu4y7e@public.gmane.org>
2013-05-10  1:01         ` Libo Chen
2013-05-10  1:01           ` Libo Chen
2013-05-13  8:52           ` Zhang, Sonic
2013-05-09  8:34   ` Zhang, Sonic
2013-05-09  8:27 ` [PATCH v2 2/2] i2c: pxa: no need release_mem_region before request_mem_region successful Libo Chen
2013-05-09  8:27   ` Libo Chen
     [not found] ` <1368088044-20408-1-git-send-email-libo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-17  9:43   ` Wolfram Sang [this message]
2013-05-17  9:43     ` [PATCH v2 0/2] i2c: fix two wrong mem release Wolfram Sang
2013-05-19  2:13     ` Libo Chen
2013-05-19  2:13       ` Libo Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130517094301.GH17056@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=Sonic.Zhang-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \
    --cc=libo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.