From: Vivek Goyal <vgoyal@redhat.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: riel@redhat.com, hughd@google.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, lisa.mitchell@hp.com,
linux-mm@kvack.org, kumagai-atsushi@mxc.nes.nec.co.jp,
ebiederm@xmission.com, kosaki.motohiro@jp.fujitsu.com,
zhangyanfei@cn.fujitsu.com, akpm@linux-foundation.org,
walken@google.com, cpw@sgi.com, jingbai.ma@hp.com
Subject: Re: [PATCH v7 2/8] vmcore: allocate buffer for ELF headers on page-size alignment
Date: Wed, 22 May 2013 10:01:42 -0400 [thread overview]
Message-ID: <20130522140142.GD5332@redhat.com> (raw)
In-Reply-To: <20130522025543.12215.27624.stgit@localhost6.localdomain6>
On Wed, May 22, 2013 at 11:55:43AM +0900, HATAYAMA Daisuke wrote:
[..]
> /* Sets offset fields of vmcore elements. */
> -static void __init set_vmcore_list_offsets_elf64(char *elfptr,
> +static void __init set_vmcore_list_offsets_elf64(char *elfptr, size_t elfsz,
> struct list_head *vc_list)
> {
> loff_t vmcore_off;
> @@ -469,8 +472,7 @@ static void __init set_vmcore_list_offsets_elf64(char *elfptr,
> ehdr_ptr = (Elf64_Ehdr *)elfptr;
>
> /* Skip Elf header and program headers. */
> - vmcore_off = sizeof(Elf64_Ehdr) +
> - (ehdr_ptr->e_phnum) * sizeof(Elf64_Phdr);
> + vmcore_off = elfsz;
As you are passing in size of elf headers, I think some of the code
has become redundant in this function. (ehdr_ptr = (Elf64_Ehdr *)elfptr;).
We can remove it and now we should be able to merge
set_vmcore_list_offsets_elf32() and set_vmcore_list_offsets_elf64()
functions.
Vivek
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com,
kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
zhangyanfei@cn.fujitsu.com, jingbai.ma@hp.com,
linux-mm@kvack.org, riel@redhat.com, walken@google.com,
hughd@google.com, kosaki.motohiro@jp.fujitsu.com
Subject: Re: [PATCH v7 2/8] vmcore: allocate buffer for ELF headers on page-size alignment
Date: Wed, 22 May 2013 10:01:42 -0400 [thread overview]
Message-ID: <20130522140142.GD5332@redhat.com> (raw)
In-Reply-To: <20130522025543.12215.27624.stgit@localhost6.localdomain6>
On Wed, May 22, 2013 at 11:55:43AM +0900, HATAYAMA Daisuke wrote:
[..]
> /* Sets offset fields of vmcore elements. */
> -static void __init set_vmcore_list_offsets_elf64(char *elfptr,
> +static void __init set_vmcore_list_offsets_elf64(char *elfptr, size_t elfsz,
> struct list_head *vc_list)
> {
> loff_t vmcore_off;
> @@ -469,8 +472,7 @@ static void __init set_vmcore_list_offsets_elf64(char *elfptr,
> ehdr_ptr = (Elf64_Ehdr *)elfptr;
>
> /* Skip Elf header and program headers. */
> - vmcore_off = sizeof(Elf64_Ehdr) +
> - (ehdr_ptr->e_phnum) * sizeof(Elf64_Phdr);
> + vmcore_off = elfsz;
As you are passing in size of elf headers, I think some of the code
has become redundant in this function. (ehdr_ptr = (Elf64_Ehdr *)elfptr;).
We can remove it and now we should be able to merge
set_vmcore_list_offsets_elf32() and set_vmcore_list_offsets_elf64()
functions.
Vivek
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com,
kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
zhangyanfei@cn.fujitsu.com, jingbai.ma@hp.com,
linux-mm@kvack.org, riel@redhat.com, walken@google.com,
hughd@google.com, kosaki.motohiro@jp.fujitsu.com
Subject: Re: [PATCH v7 2/8] vmcore: allocate buffer for ELF headers on page-size alignment
Date: Wed, 22 May 2013 10:01:42 -0400 [thread overview]
Message-ID: <20130522140142.GD5332@redhat.com> (raw)
In-Reply-To: <20130522025543.12215.27624.stgit@localhost6.localdomain6>
On Wed, May 22, 2013 at 11:55:43AM +0900, HATAYAMA Daisuke wrote:
[..]
> /* Sets offset fields of vmcore elements. */
> -static void __init set_vmcore_list_offsets_elf64(char *elfptr,
> +static void __init set_vmcore_list_offsets_elf64(char *elfptr, size_t elfsz,
> struct list_head *vc_list)
> {
> loff_t vmcore_off;
> @@ -469,8 +472,7 @@ static void __init set_vmcore_list_offsets_elf64(char *elfptr,
> ehdr_ptr = (Elf64_Ehdr *)elfptr;
>
> /* Skip Elf header and program headers. */
> - vmcore_off = sizeof(Elf64_Ehdr) +
> - (ehdr_ptr->e_phnum) * sizeof(Elf64_Phdr);
> + vmcore_off = elfsz;
As you are passing in size of elf headers, I think some of the code
has become redundant in this function. (ehdr_ptr = (Elf64_Ehdr *)elfptr;).
We can remove it and now we should be able to merge
set_vmcore_list_offsets_elf32() and set_vmcore_list_offsets_elf64()
functions.
Vivek
next prev parent reply other threads:[~2013-05-22 14:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 2:55 [PATCH v7 0/8] kdump, vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-05-22 2:55 ` HATAYAMA Daisuke
2013-05-22 2:55 ` HATAYAMA Daisuke
2013-05-22 2:55 ` [PATCH v7 1/8] vmcore: clean up read_vmcore() HATAYAMA Daisuke
2013-05-22 2:55 ` HATAYAMA Daisuke
2013-05-22 2:55 ` HATAYAMA Daisuke
2013-05-22 2:55 ` [PATCH v7 2/8] vmcore: allocate buffer for ELF headers on page-size alignment HATAYAMA Daisuke
2013-05-22 2:55 ` HATAYAMA Daisuke
2013-05-22 2:55 ` HATAYAMA Daisuke
2013-05-22 14:01 ` Vivek Goyal [this message]
2013-05-22 14:01 ` Vivek Goyal
2013-05-22 14:01 ` Vivek Goyal
2013-05-22 2:55 ` [PATCH v7 3/8] vmcore: treat memory chunks referenced by PT_LOAD program header entries in page-size boundary in vmcore_list HATAYAMA Daisuke
2013-05-22 2:55 ` HATAYAMA Daisuke
2013-05-22 2:55 ` HATAYAMA Daisuke
2013-05-22 2:55 ` [PATCH v7 4/8] vmalloc: make find_vm_area check in range HATAYAMA Daisuke
2013-05-22 2:55 ` HATAYAMA Daisuke
2013-05-22 2:55 ` HATAYAMA Daisuke
2013-05-22 2:56 ` [PATCH v7 5/8] vmalloc: introduce remap_vmalloc_range_partial HATAYAMA Daisuke
2013-05-22 2:56 ` HATAYAMA Daisuke
2013-05-22 2:56 ` HATAYAMA Daisuke
2013-05-22 2:56 ` [PATCH v7 6/8] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory HATAYAMA Daisuke
2013-05-22 2:56 ` HATAYAMA Daisuke
2013-05-22 2:56 ` HATAYAMA Daisuke
2013-05-22 19:21 ` Vivek Goyal
2013-05-22 19:21 ` Vivek Goyal
2013-05-22 19:21 ` Vivek Goyal
2013-05-22 2:56 ` [PATCH v7 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects HATAYAMA Daisuke
2013-05-22 2:56 ` HATAYAMA Daisuke
2013-05-22 2:56 ` HATAYAMA Daisuke
2013-05-22 20:46 ` Vivek Goyal
2013-05-22 20:46 ` Vivek Goyal
2013-05-22 20:46 ` Vivek Goyal
2013-05-22 2:56 ` [PATCH v7 8/8] vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-05-22 2:56 ` HATAYAMA Daisuke
2013-05-22 2:56 ` HATAYAMA Daisuke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522140142.GD5332@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cpw@sgi.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=ebiederm@xmission.com \
--cc=hughd@google.com \
--cc=jingbai.ma@hp.com \
--cc=kexec@lists.infradead.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lisa.mitchell@hp.com \
--cc=riel@redhat.com \
--cc=walken@google.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.