From: Tony Lindgren <tony@atomide.com>
To: Florian Vaussard <florian.vaussard@epfl.ch>
Cc: Benoit Cousson <b-cousson@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/5] ARM: dts: OMAP2+: use existing constants for GPIOs
Date: Thu, 23 May 2013 11:47:28 -0700 [thread overview]
Message-ID: <20130523184727.GF13507@atomide.com> (raw)
In-Reply-To: <1369323421-4180-3-git-send-email-florian.vaussard@epfl.ch>
* Florian Vaussard <florian.vaussard@epfl.ch> [130523 08:42]:
> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
> @@ -29,13 +29,13 @@
>
> heartbeat {
> label = "beagleboard::usr0";
> - gpios = <&gpio5 22 0>; /* 150 -> D6 LED */
> + gpios = <&gpio5 22 GPIO_ACTIVE_HIGH>; /* 150 -> D6 LED */
> linux,default-trigger = "heartbeat";
> };
>
> mmc {
> label = "beagleboard::usr1";
> - gpios = <&gpio5 21 0>; /* 149 -> D7 LED */
> + gpios = <&gpio5 21 GPIO_ACTIVE_HIGH>; /* 149 -> D7 LED */
> linux,default-trigger = "mmc0";
> };
> };
Great yeah this is the way to go instead of the fixed numbering.
Thanks for doing this.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] ARM: dts: OMAP2+: use existing constants for GPIOs
Date: Thu, 23 May 2013 11:47:28 -0700 [thread overview]
Message-ID: <20130523184727.GF13507@atomide.com> (raw)
In-Reply-To: <1369323421-4180-3-git-send-email-florian.vaussard@epfl.ch>
* Florian Vaussard <florian.vaussard@epfl.ch> [130523 08:42]:
> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
> @@ -29,13 +29,13 @@
>
> heartbeat {
> label = "beagleboard::usr0";
> - gpios = <&gpio5 22 0>; /* 150 -> D6 LED */
> + gpios = <&gpio5 22 GPIO_ACTIVE_HIGH>; /* 150 -> D6 LED */
> linux,default-trigger = "heartbeat";
> };
>
> mmc {
> label = "beagleboard::usr1";
> - gpios = <&gpio5 21 0>; /* 149 -> D7 LED */
> + gpios = <&gpio5 21 GPIO_ACTIVE_HIGH>; /* 149 -> D7 LED */
> linux,default-trigger = "mmc0";
> };
> };
Great yeah this is the way to go instead of the fixed numbering.
Thanks for doing this.
Regards,
Tony
next prev parent reply other threads:[~2013-05-23 18:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 15:36 [PATCH v2 0/5] ARM: dts: OMAP2+: use preprocessor for device trees Florian Vaussard
2013-05-23 15:36 ` Florian Vaussard
2013-05-23 15:36 ` [PATCH v2 1/5] ARM: dts: OMAP2+: use #include for all " Florian Vaussard
2013-05-23 15:36 ` Florian Vaussard
2013-05-23 15:36 ` [PATCH v2 2/5] ARM: dts: OMAP2+: use existing constants for GPIOs Florian Vaussard
2013-05-23 15:36 ` Florian Vaussard
2013-05-23 18:47 ` Tony Lindgren [this message]
2013-05-23 18:47 ` Tony Lindgren
2013-05-23 15:36 ` [PATCH v2 3/5] ARM: dts: OMAP4/5: use existing constants for IRQs Florian Vaussard
2013-05-23 15:36 ` Florian Vaussard
2013-05-23 15:37 ` [PATCH v2 4/5] ARM: dts: OMAP2+: header file for pinctrl constants Florian Vaussard
2013-05-23 15:37 ` Florian Vaussard
2013-05-23 15:37 ` [PATCH v2 5/5] ARM: dts: OMAP2+: use " Florian Vaussard
2013-05-23 15:37 ` Florian Vaussard
2013-05-23 18:46 ` Tony Lindgren
2013-05-23 18:46 ` Tony Lindgren
2013-05-27 11:11 ` Florian Vaussard
2013-05-27 11:11 ` Florian Vaussard
2013-05-23 16:00 ` [PATCH v2 0/5] ARM: dts: OMAP2+: use preprocessor for device trees Santosh Shilimkar
2013-05-23 16:00 ` Santosh Shilimkar
2013-05-27 11:14 ` Florian Vaussard
2013-05-27 11:14 ` Florian Vaussard
2013-05-28 15:07 ` Stephen Warren
2013-05-28 15:07 ` Stephen Warren
2013-05-28 15:13 ` Florian Vaussard
2013-05-28 15:13 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523184727.GF13507@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=florian.vaussard@epfl.ch \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.