From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Benoit Cousson <b-cousson@ti.com>,
Tony Lindgren <tony@atomide.com>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/5] ARM: dts: OMAP2+: use preprocessor for device trees
Date: Mon, 27 May 2013 13:14:52 +0200 [thread overview]
Message-ID: <51A3402C.8090103@epfl.ch> (raw)
In-Reply-To: <519E3D16.2090003@ti.com>
Hello Santosh,
Thank you for your review.
On 05/23/2013 06:00 PM, Santosh Shilimkar wrote:
> On Thursday 23 May 2013 11:36 AM, Florian Vaussard wrote:
>> Hello,
>>
>> Following a similar proposal by Stephen Warren for tegra [1], this series
>> makes use of the C preprocessor when compiling OMAP DT files, and
>> accomplishes some improvements to improve overall readability.
>>
>> Patch 1 is a preparation for the rest of the series.
>> Patch 2 uses existing constants for GPIOs. Patch 3 does the same for
>> IRQs. Patch 4 creates a new header for OMAP's padmux, and patch 5 uses
>> it to simplify pinctrl DT.
>>
>> For all targets, the .dtb files were diff-tested before and after
>> applying the series to guarantee identity.
>>
>
>>
>> Florian Vaussard (5):
>> ARM: dts: OMAP2+: use #include for all device trees
>> ARM: dts: OMAP2+: use existing constants for GPIOs
>> ARM: dts: OMAP4/5: use existing constants for IRQs
>> ARM: dts: OMAP2+: header file for pinctrl constants
>> ARM: dts: OMAP2+: use pinctrl constants
>>
> I just quickly scanned the series and patches looks
> good to my eyes. Its a nice clean-up to align OMAP
> dts files with others.
>
> FWIW,
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
I will send a v3 with minor changes to address Tony's comments, with
your Ack if ok for you.
Regards,
Florian
WARNING: multiple messages have this Message-ID (diff)
From: florian.vaussard@epfl.ch (Florian Vaussard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/5] ARM: dts: OMAP2+: use preprocessor for device trees
Date: Mon, 27 May 2013 13:14:52 +0200 [thread overview]
Message-ID: <51A3402C.8090103@epfl.ch> (raw)
In-Reply-To: <519E3D16.2090003@ti.com>
Hello Santosh,
Thank you for your review.
On 05/23/2013 06:00 PM, Santosh Shilimkar wrote:
> On Thursday 23 May 2013 11:36 AM, Florian Vaussard wrote:
>> Hello,
>>
>> Following a similar proposal by Stephen Warren for tegra [1], this series
>> makes use of the C preprocessor when compiling OMAP DT files, and
>> accomplishes some improvements to improve overall readability.
>>
>> Patch 1 is a preparation for the rest of the series.
>> Patch 2 uses existing constants for GPIOs. Patch 3 does the same for
>> IRQs. Patch 4 creates a new header for OMAP's padmux, and patch 5 uses
>> it to simplify pinctrl DT.
>>
>> For all targets, the .dtb files were diff-tested before and after
>> applying the series to guarantee identity.
>>
>
>>
>> Florian Vaussard (5):
>> ARM: dts: OMAP2+: use #include for all device trees
>> ARM: dts: OMAP2+: use existing constants for GPIOs
>> ARM: dts: OMAP4/5: use existing constants for IRQs
>> ARM: dts: OMAP2+: header file for pinctrl constants
>> ARM: dts: OMAP2+: use pinctrl constants
>>
> I just quickly scanned the series and patches looks
> good to my eyes. Its a nice clean-up to align OMAP
> dts files with others.
>
> FWIW,
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
I will send a v3 with minor changes to address Tony's comments, with
your Ack if ok for you.
Regards,
Florian
next prev parent reply other threads:[~2013-05-27 11:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 15:36 [PATCH v2 0/5] ARM: dts: OMAP2+: use preprocessor for device trees Florian Vaussard
2013-05-23 15:36 ` Florian Vaussard
2013-05-23 15:36 ` [PATCH v2 1/5] ARM: dts: OMAP2+: use #include for all " Florian Vaussard
2013-05-23 15:36 ` Florian Vaussard
2013-05-23 15:36 ` [PATCH v2 2/5] ARM: dts: OMAP2+: use existing constants for GPIOs Florian Vaussard
2013-05-23 15:36 ` Florian Vaussard
2013-05-23 18:47 ` Tony Lindgren
2013-05-23 18:47 ` Tony Lindgren
2013-05-23 15:36 ` [PATCH v2 3/5] ARM: dts: OMAP4/5: use existing constants for IRQs Florian Vaussard
2013-05-23 15:36 ` Florian Vaussard
2013-05-23 15:37 ` [PATCH v2 4/5] ARM: dts: OMAP2+: header file for pinctrl constants Florian Vaussard
2013-05-23 15:37 ` Florian Vaussard
2013-05-23 15:37 ` [PATCH v2 5/5] ARM: dts: OMAP2+: use " Florian Vaussard
2013-05-23 15:37 ` Florian Vaussard
2013-05-23 18:46 ` Tony Lindgren
2013-05-23 18:46 ` Tony Lindgren
2013-05-27 11:11 ` Florian Vaussard
2013-05-27 11:11 ` Florian Vaussard
2013-05-23 16:00 ` [PATCH v2 0/5] ARM: dts: OMAP2+: use preprocessor for device trees Santosh Shilimkar
2013-05-23 16:00 ` Santosh Shilimkar
2013-05-27 11:14 ` Florian Vaussard [this message]
2013-05-27 11:14 ` Florian Vaussard
2013-05-28 15:07 ` Stephen Warren
2013-05-28 15:07 ` Stephen Warren
2013-05-28 15:13 ` Florian Vaussard
2013-05-28 15:13 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A3402C.8090103@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.