From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: ux500: regulators: Remove misleading comment
Date: Fri, 24 May 2013 12:26:27 +0100 [thread overview]
Message-ID: <20130524112627.GY22683@gmail.com> (raw)
In-Reply-To: <1369227995-17142-1-git-send-email-lee.jones@linaro.org>
On Wed, 22 May 2013, Lee Jones wrote:
> This patch removes a comment which explains that the ab8505 platform
> uses the same initialisation settings as the ab8500. Well when this
> changed and the ab8505 started using its own set of initialisation
> values, someone forgot to remove it.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> arch/arm/mach-ux500/board-mop500-regulators.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-ux500/board-mop500-regulators.c b/arch/arm/mach-ux500/board-mop500-regulators.c
> index 33c353b..b34441b 100644
> --- a/arch/arm/mach-ux500/board-mop500-regulators.c
> +++ b/arch/arm/mach-ux500/board-mop500-regulators.c
> @@ -996,7 +996,6 @@ struct ab8500_regulator_platform_data ab8500_regulator_plat_data = {
> .num_ext_regulator = ARRAY_SIZE(ab8500_ext_regulators),
> };
>
> -/* Use the AB8500 init settings for AB8505 as they are the same right now */
> struct ab8500_regulator_platform_data ab8505_regulator_plat_data = {
> .reg_init = ab8505_reg_init,
> .num_reg_init = ARRAY_SIZE(ab8505_reg_init),
This patch still stands though.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, linus.walleij@stericsson.com,
srinidhi.kasagar@stericsson.com
Subject: Re: [PATCH] ARM: ux500: regulators: Remove misleading comment
Date: Fri, 24 May 2013 12:26:27 +0100 [thread overview]
Message-ID: <20130524112627.GY22683@gmail.com> (raw)
In-Reply-To: <1369227995-17142-1-git-send-email-lee.jones@linaro.org>
On Wed, 22 May 2013, Lee Jones wrote:
> This patch removes a comment which explains that the ab8505 platform
> uses the same initialisation settings as the ab8500. Well when this
> changed and the ab8505 started using its own set of initialisation
> values, someone forgot to remove it.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> arch/arm/mach-ux500/board-mop500-regulators.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-ux500/board-mop500-regulators.c b/arch/arm/mach-ux500/board-mop500-regulators.c
> index 33c353b..b34441b 100644
> --- a/arch/arm/mach-ux500/board-mop500-regulators.c
> +++ b/arch/arm/mach-ux500/board-mop500-regulators.c
> @@ -996,7 +996,6 @@ struct ab8500_regulator_platform_data ab8500_regulator_plat_data = {
> .num_ext_regulator = ARRAY_SIZE(ab8500_ext_regulators),
> };
>
> -/* Use the AB8500 init settings for AB8505 as they are the same right now */
> struct ab8500_regulator_platform_data ab8505_regulator_plat_data = {
> .reg_init = ab8505_reg_init,
> .num_reg_init = ARRAY_SIZE(ab8505_reg_init),
This patch still stands though.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-05-24 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 13:06 [PATCH] ARM: ux500: regulators: Remove misleading comment Lee Jones
2013-05-22 13:06 ` Lee Jones
2013-05-24 11:26 ` Lee Jones [this message]
2013-05-24 11:26 ` Lee Jones
2013-05-27 11:39 ` Linus Walleij
2013-05-27 11:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524112627.GY22683@gmail.com \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.