Re: Should LDM check be less aggressive?

[Andrey Borzenkov <arvidjaar@gmail.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

В Tue, 28 May 2013 10:34:39 -0400
Phillip Susi <psusi@ubuntu.com> пишет:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Did this ever get applied?
> 

Yes

> On 1/21/2013 1:50 PM, Andrey Borzenkov wrote:
> > В Sun, 20 Jan 2013 22:58:26 +0100 Vladimir 'φ-coder/phcoder'
> > Serbinenko <phcoder@gmail.com> пишет:
> > 
> >> On 21.11.2012 03:58, Andrey Borzenkov wrote:
> >> 
> >>> +    if (p->msdostype == GRUB_PC_PARTITION_TYPE_SFS)
> >> 
> >> SFS is confusing as the partition in question isn't SFS, it just
> >> happens that LDM and SFS ids collide. Also another problem is
> >> that of booting in case of corrupted msdos table if LDM is intact
> >> but given that the kernels won't be able to recognize such a case
> >> anyway it's a minor one. Could you update the patch not to 
> >> mention SFS?
> >> 
> > 
> > Done. Also updated for new hook API.
> > 
> > 
> > From: Andrey Borzenkov <arvidjaar@gmail.com> Subject: [PATCH] check
> > for LDM partition before checking LDM label
> > 
> > There are several reports of leftover LDM label at the end of disk 
> > blocking installation of grub. Check for existence of LDM
> > partition before checking for LDM label validity. This is the same
> > check as done by Linux kernel.
> > 
> > Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>
> > 
> > --- ChangeLog                      |    7 +++++++ Makefile.util.def
> > |    2 +- grub-core/disk/ldm.c           |   42
> > ++++++++++++++++++++++++++++++++++++++-- 
> > include/grub/msdos_partition.h |    1 + 4 files changed, 49
> > insertions(+), 3 deletions(-)
> > 
> > diff --git a/ChangeLog b/ChangeLog index 32b891a..dccdcc1 100644 
> > --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2013-01-21
> > Andrey Borzenkov <arvidjaar@gmail.com> + +	* Makefile.util.def: add
> > partmap/msdos.c to common library +	*
> > include/grub/msdos_partition.h: add GRUB_PC_PARTITION_TYPE_LDM +	*
> > grub-core/disk/ldm.c: check for existence of +
> > GRUB_PC_PARTITION_TYPE_LDM
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.17 (MingW32)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
> 
> iQEcBAEBAgAGBQJRpMB/AAoJEJrBOlT6nu75QfQH+gI7iPowpcB9UbPWHT2aOWkb
> 3mjdKlBkZVJbZOm2jn1kMBiNutxcVlNiuE4XT2oiaCWhWI2q6yqBbkXXHUqE+uif
> huSPxm/czh8mVz7FNSxmos8pJjsXFQ7tX1jI6ByoDqLjwTvnXXYfxgY6L5t/Bo1P
> +tFrdUBC0rAwFq99tKXkQQ802YbJ+eiLMehn0CQu2GggVsvnXGZkWb4trYr99ySw
> /eFQjW8mCVarbV1YH3MpLG/Jdevs0war0VmB5BrsxQ1pARiMI5aLhDENGGTJwc6X
> ucSJYplHdBRjSCr4ukdQNOzr3s/5wPwK9ZDaeOYkVDClnDK54fM8QBya+y6ZKAg=
> =rKy2
> -----END PGP SIGNATURE-----

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iEYEARECAAYFAlGkx6cACgkQR6LMutpd94yrxQCgwlcSMgwqlno8mywJ3fjX0RvU
AcUAn2redHsk3y/qly1UzlXv8mRQuZRi
=nlEF
-----END PGP SIGNATURE-----