All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Should LDM check be less aggressive?
Date: Sun, 20 Jan 2013 22:58:26 +0100	[thread overview]
Message-ID: <50FC6882.3030703@gmail.com> (raw)
In-Reply-To: <20121121065833.7497e7e8@opensuse.site>

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

On 21.11.2012 03:58, Andrey Borzenkov wrote:

> +    if (p->msdostype == GRUB_PC_PARTITION_TYPE_SFS)

SFS is confusing as the partition in question isn't SFS, it just happens
that LDM and SFS ids collide.
Also another problem is that of booting in case of corrupted msdos table
if LDM is intact but given that the kernels won't be able to recognize
such a case anyway it's a minor one. Could you update the patch not to
mention SFS?

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

  parent reply	other threads:[~2013-01-20 21:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  2:58 Should LDM check be less aggressive? Andrey Borzenkov
2012-11-21 21:23 ` Phillip Susi
2013-01-20 21:58 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-01-21 18:50   ` Andrey Borzenkov
2013-05-28 14:34     ` Phillip Susi
2013-05-28 15:05       ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FC6882.3030703@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.