From: Phillip Susi <psusi@ubuntu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Andrey Borzenkov <arvidjaar@gmail.com>
Subject: Re: Should LDM check be less aggressive?
Date: Wed, 21 Nov 2012 16:23:45 -0500 [thread overview]
Message-ID: <50AD4661.8080408@ubuntu.com> (raw)
In-Reply-To: <20121121065833.7497e7e8@opensuse.site>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/20/2012 9:58 PM, Andrey Borzenkov wrote:
> There are multiple reports of GRUB2 refusing to install on disk
> which was used for LDM in the past. Example is:
> https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1061255
>
> I tested behavior of Windows and Linux on a disk with valid LDM
> signature but manually modified partition table. Both ignore LDM
> labels if disk does not contain SFS partition (0x42) and treat is
> as pure MBR disk. This differs from GRUB2 behavior which always
> checks for LDM label whether SFS partition exists or not.
>
> Would the following be appropriate? It adds additional check for
> partition 0x42 before checking for LDM labels.
Looks nice to me. The kernel has this requirement so grub should as well.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with undefined - http://www.enigmail.net/
iQEcBAEBAgAGBQJQrUZhAAoJEJrBOlT6nu759uEH/RuU97hAKP2GcAHTkKjvcZqg
Jih1USVExNW/CYzXglXXg8KjYOv7J5xQsj00KZ8LW8f0X+ns76kV1NsrraeJFETI
repkr9FX55+qvUYzbl7PiykoWnC3RUp+TUzZYotZcfc0j1YraDzhAtNsZmDPfvwq
n9Ljo0py/HBPrWU6rjE31voVA8tkYOUz6ztldghDT3x+OJI7w5KnXJgXEOYxqVoJ
Sx9dHsCd/AKO68CwCjVuRHUeQQV1EIlVDKX0ZG21ZM2q79YEJnIChXVSvxbaySRD
yB6W9BNg7hOtFPkJs9pr81qWu3YE9RwyreOLfgGR4qzPpMBQkGsdEMJqlQytq4k=
=2Eyx
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-11-21 21:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 2:58 Should LDM check be less aggressive? Andrey Borzenkov
2012-11-21 21:23 ` Phillip Susi [this message]
2013-01-20 21:58 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-01-21 18:50 ` Andrey Borzenkov
2013-05-28 14:34 ` Phillip Susi
2013-05-28 15:05 ` Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AD4661.8080408@ubuntu.com \
--to=psusi@ubuntu.com \
--cc=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.