From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Sage Weil <sage@inktank.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Emil Goode <emilgoode@gmail.com>
Subject: Re: [patch] ceph: tidy ceph_mdsmap_decode() a little
Date: Wed, 29 May 2013 10:55:38 +0300 [thread overview]
Message-ID: <20130529075538.GE23987@mwanda> (raw)
In-Reply-To: <51A5AB81.5070908@bfs.de>
On Wed, May 29, 2013 at 09:17:21AM +0200, walter harms wrote:
> personally i would go for:
> info->export_targets = NULL;
> and remove the else below.
>
I don't have strong feelings one way or the other, but honestly, I
think the way I sent it is more clear.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Sage Weil <sage@inktank.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Emil Goode <emilgoode@gmail.com>
Subject: Re: [patch] ceph: tidy ceph_mdsmap_decode() a little
Date: Wed, 29 May 2013 07:55:38 +0000 [thread overview]
Message-ID: <20130529075538.GE23987@mwanda> (raw)
In-Reply-To: <51A5AB81.5070908@bfs.de>
On Wed, May 29, 2013 at 09:17:21AM +0200, walter harms wrote:
> personally i would go for:
> info->export_targets = NULL;
> and remove the else below.
>
I don't have strong feelings one way or the other, but honestly, I
think the way I sent it is more clear.
regards,
dan carpenter
next prev parent reply other threads:[~2013-05-29 7:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 14:59 [PATCH] ceph: improve error handling in ceph_mdsmap_decode Emil Goode
2013-05-28 14:59 ` Emil Goode
2013-05-28 15:54 ` Sage Weil
2013-05-28 15:54 ` Sage Weil
2013-05-29 6:22 ` [patch] ceph: tidy ceph_mdsmap_decode() a little Dan Carpenter
2013-05-29 6:22 ` Dan Carpenter
2013-05-29 7:17 ` walter harms
2013-05-29 7:17 ` walter harms
2013-05-29 7:55 ` Dan Carpenter [this message]
2013-05-29 7:55 ` Dan Carpenter
2013-05-29 11:45 ` Alex Elder
2013-05-29 11:45 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529075538.GE23987@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ceph-devel@vger.kernel.org \
--cc=emilgoode@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@inktank.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.