From: Alex Elder <elder@inktank.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sage Weil <sage@inktank.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Emil Goode <emilgoode@gmail.com>
Subject: Re: [patch] ceph: tidy ceph_mdsmap_decode() a little
Date: Wed, 29 May 2013 06:45:33 -0500 [thread overview]
Message-ID: <51A5EA5D.6010408@inktank.com> (raw)
In-Reply-To: <20130529062213.GF23932@mwanda>
On 05/29/2013 01:22 AM, Dan Carpenter wrote:
> I introduced a new temporary variable "info" instead of
> "m->m_info[mds]". Also I reversed the if condition and pulled
> everything in one indent level.
Looks good. I will apply this for you.
Reviewed-by: Alex Elder <elder@inktank.com>
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This goes on top of Emil Goode's patch.
>
> diff --git a/fs/ceph/mdsmap.c b/fs/ceph/mdsmap.c
> index d4d3897..132b64e 100644
> --- a/fs/ceph/mdsmap.c
> +++ b/fs/ceph/mdsmap.c
> @@ -92,6 +92,7 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end)
> u32 num_export_targets;
> void *pexport_targets = NULL;
> struct ceph_timespec laggy_since;
> + struct ceph_mds_info *info;
>
> ceph_decode_need(p, end, sizeof(u64)*2 + 1 + sizeof(u32), bad);
> global_id = ceph_decode_64(p);
. . .
WARNING: multiple messages have this Message-ID (diff)
From: Alex Elder <elder@inktank.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sage Weil <sage@inktank.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Emil Goode <emilgoode@gmail.com>
Subject: Re: [patch] ceph: tidy ceph_mdsmap_decode() a little
Date: Wed, 29 May 2013 11:45:33 +0000 [thread overview]
Message-ID: <51A5EA5D.6010408@inktank.com> (raw)
In-Reply-To: <20130529062213.GF23932@mwanda>
On 05/29/2013 01:22 AM, Dan Carpenter wrote:
> I introduced a new temporary variable "info" instead of
> "m->m_info[mds]". Also I reversed the if condition and pulled
> everything in one indent level.
Looks good. I will apply this for you.
Reviewed-by: Alex Elder <elder@inktank.com>
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This goes on top of Emil Goode's patch.
>
> diff --git a/fs/ceph/mdsmap.c b/fs/ceph/mdsmap.c
> index d4d3897..132b64e 100644
> --- a/fs/ceph/mdsmap.c
> +++ b/fs/ceph/mdsmap.c
> @@ -92,6 +92,7 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end)
> u32 num_export_targets;
> void *pexport_targets = NULL;
> struct ceph_timespec laggy_since;
> + struct ceph_mds_info *info;
>
> ceph_decode_need(p, end, sizeof(u64)*2 + 1 + sizeof(u32), bad);
> global_id = ceph_decode_64(p);
. . .
next prev parent reply other threads:[~2013-05-29 11:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 14:59 [PATCH] ceph: improve error handling in ceph_mdsmap_decode Emil Goode
2013-05-28 14:59 ` Emil Goode
2013-05-28 15:54 ` Sage Weil
2013-05-28 15:54 ` Sage Weil
2013-05-29 6:22 ` [patch] ceph: tidy ceph_mdsmap_decode() a little Dan Carpenter
2013-05-29 6:22 ` Dan Carpenter
2013-05-29 7:17 ` walter harms
2013-05-29 7:17 ` walter harms
2013-05-29 7:55 ` Dan Carpenter
2013-05-29 7:55 ` Dan Carpenter
2013-05-29 11:45 ` Alex Elder [this message]
2013-05-29 11:45 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A5EA5D.6010408@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=emilgoode@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.