From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Stepan Moskovchenko <stepanm@codeaurora.org>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
David Brown <davidb@codeaurora.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>
Subject: Re: [PATCH] arm: Prevent memory aliasing on non-LPAE kernels
Date: Thu, 30 May 2013 16:10:54 -0600 [thread overview]
Message-ID: <20130530221054.GA31643@obsidianresearch.com> (raw)
In-Reply-To: <1369950320-22784-1-git-send-email-stepanm@codeaurora.org>
On Thu, May 30, 2013 at 02:45:20PM -0700, Stepan Moskovchenko wrote:
> void __init early_init_dt_add_memory_arch(u64 base, u64 size)
> {
> +#ifndef CONFIG_ARM_LPAE
> + if (base > ((phys_addr_t)~0)) {
The #ifdef is probably not necessary here, simply checking that
base/size can be represented in a phys_addr_t is enough.
> + pr_crit("Ignoring memory at 0x%08llx due to lack of LPAE support\n",
> + base);
> + return;
> + }
> +
> + if (size > ((phys_addr_t)~0))
> + size = ((phys_addr_t)~0);
A similar printk as arm_add_memory for this one too?
printk(KERN_CRIT "Truncating memory at 0x%08llx to fit in "
"32-bit physical address space\n", (long long)start);
Regards,
Jason
WARNING: multiple messages have this Message-ID (diff)
From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Prevent memory aliasing on non-LPAE kernels
Date: Thu, 30 May 2013 16:10:54 -0600 [thread overview]
Message-ID: <20130530221054.GA31643@obsidianresearch.com> (raw)
In-Reply-To: <1369950320-22784-1-git-send-email-stepanm@codeaurora.org>
On Thu, May 30, 2013 at 02:45:20PM -0700, Stepan Moskovchenko wrote:
> void __init early_init_dt_add_memory_arch(u64 base, u64 size)
> {
> +#ifndef CONFIG_ARM_LPAE
> + if (base > ((phys_addr_t)~0)) {
The #ifdef is probably not necessary here, simply checking that
base/size can be represented in a phys_addr_t is enough.
> + pr_crit("Ignoring memory at 0x%08llx due to lack of LPAE support\n",
> + base);
> + return;
> + }
> +
> + if (size > ((phys_addr_t)~0))
> + size = ((phys_addr_t)~0);
A similar printk as arm_add_memory for this one too?
printk(KERN_CRIT "Truncating memory at 0x%08llx to fit in "
"32-bit physical address space\n", (long long)start);
Regards,
Jason
next prev parent reply other threads:[~2013-05-30 22:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 21:45 [PATCH] arm: Prevent memory aliasing on non-LPAE kernels Stepan Moskovchenko
2013-05-30 21:45 ` Stepan Moskovchenko
2013-05-30 21:45 ` Stepan Moskovchenko
2013-05-30 22:10 ` Jason Gunthorpe [this message]
2013-05-30 22:10 ` Jason Gunthorpe
2013-05-30 22:24 ` Arnd Bergmann
2013-05-30 22:24 ` Arnd Bergmann
2013-06-01 1:30 ` Stepan Moskovchenko
2013-06-01 1:30 ` Stepan Moskovchenko
2013-06-10 5:24 ` Magnus Damm
2013-06-10 5:24 ` Magnus Damm
2013-08-29 7:08 ` takashi.yoshii.zj
2013-08-29 7:08 ` takashi.yoshii.zj at renesas.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530221054.GA31643@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=stepanm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.