From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: twl-core: convert to module_init()
Date: Fri, 31 May 2013 14:20:04 -0700 [thread overview]
Message-ID: <20130531212003.GR6467@atomide.com> (raw)
In-Reply-To: <1370033794-5357-1-git-send-email-khilman@linaro.org>
* Kevin Hilman <khilman@linaro.org> [130531 14:02]:
> There's no reason for twl-core to be subsys_inicall anymore. Anything
> using twl that early needs a rethink, or deferred probe changes.
>
> Boot tested and RTC wake tested (via TWL RTC) on OMAP platforms:
> 3530/Beagle, 3730/Beagle-xM, 3530/Overo, 3730/Overo-STORM, 4430/Panda,
> 4460/Panda-ES.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
Totally agree:
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/mfd/twl-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
> index 89ab4d9..7749b9e 100644
> --- a/drivers/mfd/twl-core.c
> +++ b/drivers/mfd/twl-core.c
> @@ -1309,7 +1309,7 @@ static int __init twl_init(void)
> {
> return i2c_add_driver(&twl_driver);
> }
> -subsys_initcall(twl_init);
> +module_init(twl_init);
>
> static void __exit twl_exit(void)
> {
> --
> 1.8.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: twl-core: convert to module_init()
Date: Fri, 31 May 2013 14:20:04 -0700 [thread overview]
Message-ID: <20130531212003.GR6467@atomide.com> (raw)
In-Reply-To: <1370033794-5357-1-git-send-email-khilman@linaro.org>
* Kevin Hilman <khilman@linaro.org> [130531 14:02]:
> There's no reason for twl-core to be subsys_inicall anymore. Anything
> using twl that early needs a rethink, or deferred probe changes.
>
> Boot tested and RTC wake tested (via TWL RTC) on OMAP platforms:
> 3530/Beagle, 3730/Beagle-xM, 3530/Overo, 3730/Overo-STORM, 4430/Panda,
> 4460/Panda-ES.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
Totally agree:
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/mfd/twl-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
> index 89ab4d9..7749b9e 100644
> --- a/drivers/mfd/twl-core.c
> +++ b/drivers/mfd/twl-core.c
> @@ -1309,7 +1309,7 @@ static int __init twl_init(void)
> {
> return i2c_add_driver(&twl_driver);
> }
> -subsys_initcall(twl_init);
> +module_init(twl_init);
>
> static void __exit twl_exit(void)
> {
> --
> 1.8.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-05-31 21:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 20:56 [PATCH] mfd: twl-core: convert to module_init() Kevin Hilman
2013-05-31 20:56 ` Kevin Hilman
2013-05-31 20:56 ` Kevin Hilman
2013-05-31 21:20 ` Tony Lindgren [this message]
2013-05-31 21:20 ` Tony Lindgren
2013-06-01 7:59 ` Strashko, Grygorii
2013-06-01 7:59 ` Strashko, Grygorii
2013-06-01 7:59 ` Strashko, Grygorii
2013-06-03 20:58 ` Kevin Hilman
2013-06-03 20:58 ` Kevin Hilman
2013-06-03 20:58 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531212003.GR6467@atomide.com \
--to=tony@atomide.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.