From: Kevin Hilman <khilman@linaro.org>
To: "Strashko, Grygorii" <grygorii.strashko@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: twl-core: convert to module_init()
Date: Mon, 03 Jun 2013 13:58:03 -0700 [thread overview]
Message-ID: <87li6qlxno.fsf@linaro.org> (raw)
In-Reply-To: <902E09E6452B0E43903E4F2D568737AB31F402@DNCE04.ent.ti.com> (Grygorii Strashko's message of "Sat, 1 Jun 2013 07:59:03 +0000")
"Strashko, Grygorii" <grygorii.strashko@ti.com> writes:
> Hi Kevin,
>
> It's done alreday here:
> https://patchwork.kernel.org/patch/2477541/ - mfd: twl-core: convert to module_i2c_driver()
> (Samuel has taken this one)
Excellent, thanks for pointing it out, somehow I missed that thread. My
patch can be ignored.
> - and -
> https://patchwork.kernel.org/patch/2477561/ - i2c: omap: convert to module_platform_driver()
> (you can vote here - TWL can't be shifted without I2C)
This one (combined with the first one) makes twl_rtc fail to initialize
properly on OMAP3 DT boot, with an error like this:
twl_rtc rtc.22: hctosys: invalid date/time
Reverting that you get the expected result:
twl_rtc rtc.22: setting system clock to 2000-01-01 00:00:00 UTC (946684800)
I didn't debug any further, but for now, at least patch 2 needs a little
more work/debug.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: twl-core: convert to module_init()
Date: Mon, 03 Jun 2013 13:58:03 -0700 [thread overview]
Message-ID: <87li6qlxno.fsf@linaro.org> (raw)
In-Reply-To: <902E09E6452B0E43903E4F2D568737AB31F402@DNCE04.ent.ti.com> (Grygorii Strashko's message of "Sat, 1 Jun 2013 07:59:03 +0000")
"Strashko, Grygorii" <grygorii.strashko@ti.com> writes:
> Hi Kevin,
>
> It's done alreday here:
> https://patchwork.kernel.org/patch/2477541/ - mfd: twl-core: convert to module_i2c_driver()
> (Samuel has taken this one)
Excellent, thanks for pointing it out, somehow I missed that thread. My
patch can be ignored.
> - and -
> https://patchwork.kernel.org/patch/2477561/ - i2c: omap: convert to module_platform_driver()
> (you can vote here - TWL can't be shifted without I2C)
This one (combined with the first one) makes twl_rtc fail to initialize
properly on OMAP3 DT boot, with an error like this:
twl_rtc rtc.22: hctosys: invalid date/time
Reverting that you get the expected result:
twl_rtc rtc.22: setting system clock to 2000-01-01 00:00:00 UTC (946684800)
I didn't debug any further, but for now, at least patch 2 needs a little
more work/debug.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@linaro.org>
To: "Strashko\, Grygorii" <grygorii.strashko@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>,
"linux-omap\@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: twl-core: convert to module_init()
Date: Mon, 03 Jun 2013 13:58:03 -0700 [thread overview]
Message-ID: <87li6qlxno.fsf@linaro.org> (raw)
In-Reply-To: <902E09E6452B0E43903E4F2D568737AB31F402@DNCE04.ent.ti.com> (Grygorii Strashko's message of "Sat, 1 Jun 2013 07:59:03 +0000")
"Strashko, Grygorii" <grygorii.strashko@ti.com> writes:
> Hi Kevin,
>
> It's done alreday here:
> https://patchwork.kernel.org/patch/2477541/ - mfd: twl-core: convert to module_i2c_driver()
> (Samuel has taken this one)
Excellent, thanks for pointing it out, somehow I missed that thread. My
patch can be ignored.
> - and -
> https://patchwork.kernel.org/patch/2477561/ - i2c: omap: convert to module_platform_driver()
> (you can vote here - TWL can't be shifted without I2C)
This one (combined with the first one) makes twl_rtc fail to initialize
properly on OMAP3 DT boot, with an error like this:
twl_rtc rtc.22: hctosys: invalid date/time
Reverting that you get the expected result:
twl_rtc rtc.22: setting system clock to 2000-01-01 00:00:00 UTC (946684800)
I didn't debug any further, but for now, at least patch 2 needs a little
more work/debug.
Kevin
next prev parent reply other threads:[~2013-06-03 20:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 20:56 [PATCH] mfd: twl-core: convert to module_init() Kevin Hilman
2013-05-31 20:56 ` Kevin Hilman
2013-05-31 20:56 ` Kevin Hilman
2013-05-31 21:20 ` Tony Lindgren
2013-05-31 21:20 ` Tony Lindgren
2013-06-01 7:59 ` Strashko, Grygorii
2013-06-01 7:59 ` Strashko, Grygorii
2013-06-01 7:59 ` Strashko, Grygorii
2013-06-03 20:58 ` Kevin Hilman [this message]
2013-06-03 20:58 ` Kevin Hilman
2013-06-03 20:58 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li6qlxno.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.