[PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

[PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

[Ben Chan]

The gdm72xx driver needs to have either the USB or SDIO implementation
enabled to provide useful functionalities, so the driver should depend
on either USB or MMC.

Signed-off-by: Ben Chan <benchan@chromium.org>
Cc: Sage Ahn <syahn@gctsemi.com>
---
 drivers/staging/gdm72xx/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
index 6905913..8af0dd4 100644
--- a/drivers/staging/gdm72xx/Kconfig
+++ b/drivers/staging/gdm72xx/Kconfig
@@ -4,7 +4,7 @@
 
 menuconfig WIMAX_GDM72XX
 	tristate "GCT GDM72xx WiMAX support"
-	depends on NET
+	depends on NET && (USB || MMC)
 	help
 	  Support for the GCT GDM72xx WiMAX chip
 
-- 
1.8.2.1

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

[Greg Kroah-Hartman]

On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
> The gdm72xx driver needs to have either the USB or SDIO implementation
> enabled to provide useful functionalities, so the driver should depend
> on either USB or MMC.
> 
> Signed-off-by: Ben Chan <benchan@chromium.org>
> Cc: Sage Ahn <syahn@gctsemi.com>
> ---
>  drivers/staging/gdm72xx/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
> index 6905913..8af0dd4 100644
> --- a/drivers/staging/gdm72xx/Kconfig
> +++ b/drivers/staging/gdm72xx/Kconfig
> @@ -4,7 +4,7 @@
>  
>  menuconfig WIMAX_GDM72XX
>  	tristate "GCT GDM72xx WiMAX support"
> -	depends on NET
> +	depends on NET && (USB || MMC)

Alan Stern already told you how this would not solve the problem, why
did you resend it to me again?

And you forgot the "Reported-by:" line above, giving proper credit to
the person who told you about this problem.

Please fix both of them and resend.

thanks,

greg k-h

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

[Ben Chan]

Sorry, I meant to send the revised patch but got the wrong file.

I'll add the Reported-by field.

Thanks,
Ben

On Mon, Jun 3, 2013 at 10:48 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
>> The gdm72xx driver needs to have either the USB or SDIO implementation
>> enabled to provide useful functionalities, so the driver should depend
>> on either USB or MMC.
>>
>> Signed-off-by: Ben Chan <benchan@chromium.org>
>> Cc: Sage Ahn <syahn@gctsemi.com>
>> ---
>>  drivers/staging/gdm72xx/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
>> index 6905913..8af0dd4 100644
>> --- a/drivers/staging/gdm72xx/Kconfig
>> +++ b/drivers/staging/gdm72xx/Kconfig
>> @@ -4,7 +4,7 @@
>>
>>  menuconfig WIMAX_GDM72XX
>>       tristate "GCT GDM72xx WiMAX support"
>> -     depends on NET
>> +     depends on NET && (USB || MMC)
>
> Alan Stern already told you how this would not solve the problem, why
> did you resend it to me again?
>
> And you forgot the "Reported-by:" line above, giving proper credit to
> the person who told you about this problem.
>
> Please fix both of them and resend.
>
> thanks,
>
> greg k-h

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

[Greg Kroah-Hartman]

On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
> The gdm72xx driver needs to have either the USB or SDIO implementation
> enabled to provide useful functionalities, so the driver should depend
> on either USB or MMC.
> 
> Signed-off-by: Ben Chan <benchan@chromium.org>
> Cc: Sage Ahn <syahn@gctsemi.com>
> ---
>  drivers/staging/gdm72xx/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
> index 6905913..8af0dd4 100644
> --- a/drivers/staging/gdm72xx/Kconfig
> +++ b/drivers/staging/gdm72xx/Kconfig
> @@ -4,7 +4,7 @@
>  
>  menuconfig WIMAX_GDM72XX
>  	tristate "GCT GDM72xx WiMAX support"
> -	depends on NET
> +	depends on NET && (USB || MMC)

Really?  Again?

Are you trying to just get me to ignore your patches?

If so, you just did a good job, please take a day or two to relax and
get it right.

greg k-h

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

[Ben Chan]

Nope... I didn't resend the patch but replied to the thread.

Ben

On Mon, Jun 3, 2013 at 11:18 AM, Ben Chan <benchan@chromium.org> wrote:
> Sorry, I meant to send the revised patch but got the wrong file.
>
> I'll add the Reported-by field.
>
> Thanks,
> Ben
>

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

[Greg Kroah-Hartman]

On Mon, Jun 03, 2013 at 11:30:45AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
> > The gdm72xx driver needs to have either the USB or SDIO implementation
> > enabled to provide useful functionalities, so the driver should depend
> > on either USB or MMC.
> > 
> > Signed-off-by: Ben Chan <benchan@chromium.org>
> > Cc: Sage Ahn <syahn@gctsemi.com>
> > ---
> >  drivers/staging/gdm72xx/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
> > index 6905913..8af0dd4 100644
> > --- a/drivers/staging/gdm72xx/Kconfig
> > +++ b/drivers/staging/gdm72xx/Kconfig
> > @@ -4,7 +4,7 @@
> >  
> >  menuconfig WIMAX_GDM72XX
> >  	tristate "GCT GDM72xx WiMAX support"
> > -	depends on NET
> > +	depends on NET && (USB || MMC)
> 
> Really?  Again?
> 
> Are you trying to just get me to ignore your patches?
> 
> If so, you just did a good job, please take a day or two to relax and
> get it right.

Crap, slow mailing list, just decided to spit out the second copy of
this to me, sorry for the rant, I need more coffee.

Or maybe less...

My apologies.

greg k-h

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

[Ben Chan]

No worries. I've attached a revised patch to the original email
thread, which includes Alan.

Thanks again,
Ben