From: "John W. Linville" <linville@tuxdriver.com>
To: Yunlian Jiang <yunlian@google.com>
Cc: linux-wireless@vger.kernel.org, Larry.Finger@lwfinger.net,
chaoming_li@realsil.com.cn, davem@davemloft.net
Subject: Re: [PATCH] rtlwifi: initialize local array and set value.
Date: Mon, 3 Jun 2013 15:39:47 -0400 [thread overview]
Message-ID: <20130603193947.GH2727@tuxdriver.com> (raw)
In-Reply-To: <1370036721-18164-1-git-send-email-yunlian@google.com>
This patch is missing a Signed-off-by line...
On Fri, May 31, 2013 at 02:45:21PM -0700, Yunlian Jiang wrote:
> GCC 4.8 is spitting out uninitialized-variable warnings against
> "drivers/net/wireless/rtlwifi/rtl8192de/dm.c".
>
> drivers/net/wireless/rtlwifi/rtl8192de/dm.c:941:31:
> error: 'ofdm_index_old[1]' may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
> rtlpriv->dm.ofdm_index[i] = ofdm_index_old[i];
>
> This patch adds initialization to the variable and properly sets its value.
> ---
> drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> index 19a7655..47875ba 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> @@ -842,7 +842,7 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(
> long val_y, ele_c = 0;
> u8 ofdm_index[2];
> s8 cck_index = 0;
> - u8 ofdm_index_old[2];
> + u8 ofdm_index_old[2] = {0, 0};
> s8 cck_index_old = 0;
> u8 index;
> int i;
> --
> 1.8.2.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2013-06-03 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 21:45 [PATCH] rtlwifi: initialize local array and set value Yunlian Jiang
2013-05-31 22:08 ` Larry Finger
2013-06-03 19:39 ` John W. Linville [this message]
[not found] ` <CAMsPy2sqS8frL+Ybq2YT83ehfZ9bSgyfwuZmfDf1R4tCre8O1g@mail.gmail.com>
2013-06-03 21:07 ` John W. Linville
[not found] ` <CAMsPy2vQzhdy9xzUzk+xWt_EXDbFmGUStJPRXvr1LG85v-NVRQ@mail.gmail.com>
[not found] ` <CAMsPy2ufj3TjdWbpPKq7QqS_ELAmqhA_Djo6dwcevLym2PCkDQ@mail.gmail.com>
2013-06-11 20:59 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603193947.GH2727@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=yunlian@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.