Re: [PATCH] rtlwifi: initialize local array and set value.

["John W. Linville" <linville@tuxdriver.com>]

That would be perfectly fine.  Or, you can just acknowledge that you
intended for it to be there and I can add it myself.

John

On Mon, Jun 03, 2013 at 12:48:31PM -0700, Yunlian Jiang wrote:
> Sorry, can I re-upload the patch and set Signed-off-by me?
> 
> Thanks
> 
> 
> On Mon, Jun 3, 2013 at 12:39 PM, John W. Linville <linville@tuxdriver.com>wrote:
> 
> > This patch is missing a Signed-off-by line...
> >
> > On Fri, May 31, 2013 at 02:45:21PM -0700, Yunlian Jiang wrote:
> > > GCC 4.8 is spitting out uninitialized-variable warnings against
> > > "drivers/net/wireless/rtlwifi/rtl8192de/dm.c".
> > >
> > > drivers/net/wireless/rtlwifi/rtl8192de/dm.c:941:31:
> > > error: 'ofdm_index_old[1]' may be used uninitialized in this
> > > function [-Werror=maybe-uninitialized]
> > >      rtlpriv->dm.ofdm_index[i] = ofdm_index_old[i];
> > >
> > > This patch adds initialization to the variable and properly sets its
> > value.
> > > ---
> > >  drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> > b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> > > index 19a7655..47875ba 100644
> > > --- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> > > +++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> > > @@ -842,7 +842,7 @@ static void
> > rtl92d_dm_txpower_tracking_callback_thermalmeter(
> > >       long val_y, ele_c = 0;
> > >       u8 ofdm_index[2];
> > >       s8 cck_index = 0;
> > > -     u8 ofdm_index_old[2];
> > > +     u8 ofdm_index_old[2] = {0, 0};
> > >       s8 cck_index_old = 0;
> > >       u8 index;
> > >       int i;
> > > --
> > > 1.8.2.1
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> > linux-wireless" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > >
> >
> > --
> > John W. Linville                Someday the world will need a hero, and you
> > linville@tuxdriver.com                  might be all we have.  Be ready.
> >

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.