Re: [PATCH] rtlwifi: initialize local array and set value.

[Larry Finger <Larry.Finger@lwfinger.net>]

On 05/31/2013 04:45 PM, Yunlian Jiang wrote:
> GCC 4.8 is spitting out uninitialized-variable warnings against
> "drivers/net/wireless/rtlwifi/rtl8192de/dm.c".
>
> drivers/net/wireless/rtlwifi/rtl8192de/dm.c:941:31:
> error: 'ofdm_index_old[1]' may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
>       rtlpriv->dm.ofdm_index[i] = ofdm_index_old[i];
>
> This patch adds initialization to the variable and properly sets its value.
> ---
>   drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

I thought this had already been fixed, but apparently not.

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks,

Larry

>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> index 19a7655..47875ba 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> @@ -842,7 +842,7 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(
>   	long val_y, ele_c = 0;
>   	u8 ofdm_index[2];
>   	s8 cck_index = 0;
> -	u8 ofdm_index_old[2];
> +	u8 ofdm_index_old[2] = {0, 0};
>   	s8 cck_index_old = 0;
>   	u8 index;
>   	int i;
>