From: Arnd Bergmann <arnd@arndb.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sourav Poddar <sourav.poddar@ti.com>,
Kevin Hilman <khilman@linaro.org>, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH] serial: omap: repair building without PM_SLEEP
Date: Mon, 3 Jun 2013 20:43:38 +0200 [thread overview]
Message-ID: <201306032043.38656.arnd@arndb.de> (raw)
In-Reply-To: <20130603170730.GA30767@kroah.com>
On Monday 03 June 2013, Greg Kroah-Hartman wrote:
> On Sat, Jun 01, 2013 at 11:18:13AM +0200, Arnd Bergmann wrote:
> > A recent bug fix in 3.10, ddd85e225c "serial: omap: prevent runtime PM for
> > "no_console_suspend"", introduced a regression from an obvious typo:
>
> I don't see that commit id, or commit, in Linus's tree at all. Where do
> you see it?
>
> > drivers/tty/serial/omap-serial.c:1677:14: error: 'serial_omap_complete'
> > undeclared here (not in a function)
> >
> > This changes the incorrectly added macro to the one that we need instead.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > Please apply for 3.10-rc
>
> Really? It doesn't apply to 3.10-rc3 or -rc4 from what I can tell.
Sorry, my mistake. Since the bug was introduced as part of a bug fix
I assumed it was in 3.10-rc but did not look carefully. The problem
only exists in tty-next at the moment.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: omap: repair building without PM_SLEEP
Date: Mon, 3 Jun 2013 20:43:38 +0200 [thread overview]
Message-ID: <201306032043.38656.arnd@arndb.de> (raw)
In-Reply-To: <20130603170730.GA30767@kroah.com>
On Monday 03 June 2013, Greg Kroah-Hartman wrote:
> On Sat, Jun 01, 2013 at 11:18:13AM +0200, Arnd Bergmann wrote:
> > A recent bug fix in 3.10, ddd85e225c "serial: omap: prevent runtime PM for
> > "no_console_suspend"", introduced a regression from an obvious typo:
>
> I don't see that commit id, or commit, in Linus's tree at all. Where do
> you see it?
>
> > drivers/tty/serial/omap-serial.c:1677:14: error: 'serial_omap_complete'
> > undeclared here (not in a function)
> >
> > This changes the incorrectly added macro to the one that we need instead.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > Please apply for 3.10-rc
>
> Really? It doesn't apply to 3.10-rc3 or -rc4 from what I can tell.
Sorry, my mistake. Since the bug was introduced as part of a bug fix
I assumed it was in 3.10-rc but did not look carefully. The problem
only exists in tty-next at the moment.
Arnd
next prev parent reply other threads:[~2013-06-03 18:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 9:18 [PATCH] serial: omap: repair building without PM_SLEEP Arnd Bergmann
2013-06-01 9:18 ` Arnd Bergmann
2013-06-01 11:48 ` Sourav Poddar
2013-06-01 11:48 ` Sourav Poddar
2013-06-01 11:48 ` Sourav Poddar
2013-06-03 17:07 ` Greg Kroah-Hartman
2013-06-03 17:07 ` Greg Kroah-Hartman
2013-06-03 18:43 ` Arnd Bergmann [this message]
2013-06-03 18:43 ` Arnd Bergmann
2013-06-03 18:50 ` Kevin Hilman
2013-06-03 18:50 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306032043.38656.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.