All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sourav Poddar <sourav.poddar@ti.com>, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH] serial: omap: repair building without PM_SLEEP
Date: Mon, 03 Jun 2013 11:50:09 -0700	[thread overview]
Message-ID: <871u8jm3ku.fsf@linaro.org> (raw)
In-Reply-To: <20130603170730.GA30767@kroah.com> (Greg Kroah-Hartman's message of "Mon, 3 Jun 2013 10:07:30 -0700")

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Sat, Jun 01, 2013 at 11:18:13AM +0200, Arnd Bergmann wrote:
>> A recent bug fix in 3.10, ddd85e225c "serial: omap: prevent runtime PM for
>> "no_console_suspend"", introduced a regression from an obvious typo:
>
> I don't see that commit id, or commit, in Linus's tree at all.  Where do
> you see it?

It's in linux-next (from your tty-next branch.)

>> drivers/tty/serial/omap-serial.c:1677:14: error: 'serial_omap_complete' 
>> 	undeclared here (not in a function)
>> 
>> This changes the incorrectly added macro to the one that we need instead.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Kevin Hilman <khilman@linaro.org>

>> ---
>> Please apply for 3.10-rc
>
> Really?  It doesn't apply to 3.10-rc3 or -rc4 from what I can tell.

Right, this is -next material, not v3.10.

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: omap: repair building without PM_SLEEP
Date: Mon, 03 Jun 2013 11:50:09 -0700	[thread overview]
Message-ID: <871u8jm3ku.fsf@linaro.org> (raw)
In-Reply-To: <20130603170730.GA30767@kroah.com> (Greg Kroah-Hartman's message of "Mon, 3 Jun 2013 10:07:30 -0700")

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Sat, Jun 01, 2013 at 11:18:13AM +0200, Arnd Bergmann wrote:
>> A recent bug fix in 3.10, ddd85e225c "serial: omap: prevent runtime PM for
>> "no_console_suspend"", introduced a regression from an obvious typo:
>
> I don't see that commit id, or commit, in Linus's tree at all.  Where do
> you see it?

It's in linux-next (from your tty-next branch.)

>> drivers/tty/serial/omap-serial.c:1677:14: error: 'serial_omap_complete' 
>> 	undeclared here (not in a function)
>> 
>> This changes the incorrectly added macro to the one that we need instead.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Kevin Hilman <khilman@linaro.org>

>> ---
>> Please apply for 3.10-rc
>
> Really?  It doesn't apply to 3.10-rc3 or -rc4 from what I can tell.

Right, this is -next material, not v3.10.

Kevin

  parent reply	other threads:[~2013-06-03 18:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01  9:18 [PATCH] serial: omap: repair building without PM_SLEEP Arnd Bergmann
2013-06-01  9:18 ` Arnd Bergmann
2013-06-01 11:48 ` Sourav Poddar
2013-06-01 11:48   ` Sourav Poddar
2013-06-01 11:48   ` Sourav Poddar
2013-06-03 17:07 ` Greg Kroah-Hartman
2013-06-03 17:07   ` Greg Kroah-Hartman
2013-06-03 18:43   ` Arnd Bergmann
2013-06-03 18:43     ` Arnd Bergmann
2013-06-03 18:50   ` Kevin Hilman [this message]
2013-06-03 18:50     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871u8jm3ku.fsf@linaro.org \
    --to=khilman@linaro.org \
    --cc=arnd@arndb.de \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sourav.poddar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.