From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.ml.walleij@gmail.com>,
linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jon Hunter <jon-hunter@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kevin Hilman <khilman@linaro.org>
Subject: Re: [PATCH] gpio/omap: omap_gpio_init_context stub must be inline
Date: Wed, 5 Jun 2013 08:38:47 -0700 [thread overview]
Message-ID: <20130605153847.GV3331@atomide.com> (raw)
In-Reply-To: <2942784.trumtc2GjZ@wuerfel>
* Arnd Bergmann <arnd@arndb.de> [130531 09:05]:
> The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised"
> has caused a new warning for omap1_defconfig:
>
> drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function]
> static void omap_gpio_init_context(struct gpio_bank *p) {}
> ^
>
> The solution is to mark the stub function as 'static inline' so
> it gets left out of the build when unused.
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index d3f7d2d..e5fba65 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1462,7 +1462,7 @@ static void omap_gpio_restore_context(struct gpio_bank *bank)
> #else
> #define omap_gpio_runtime_suspend NULL
> #define omap_gpio_runtime_resume NULL
> -static void omap_gpio_init_context(struct gpio_bank *p) {}
> +static inline void omap_gpio_init_context(struct gpio_bank *p) {}
> #endif
>
> static const struct dev_pm_ops gpio_pm_ops = {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio/omap: omap_gpio_init_context stub must be inline
Date: Wed, 5 Jun 2013 08:38:47 -0700 [thread overview]
Message-ID: <20130605153847.GV3331@atomide.com> (raw)
In-Reply-To: <2942784.trumtc2GjZ@wuerfel>
* Arnd Bergmann <arnd@arndb.de> [130531 09:05]:
> The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised"
> has caused a new warning for omap1_defconfig:
>
> drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function]
> static void omap_gpio_init_context(struct gpio_bank *p) {}
> ^
>
> The solution is to mark the stub function as 'static inline' so
> it gets left out of the build when unused.
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index d3f7d2d..e5fba65 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1462,7 +1462,7 @@ static void omap_gpio_restore_context(struct gpio_bank *bank)
> #else
> #define omap_gpio_runtime_suspend NULL
> #define omap_gpio_runtime_resume NULL
> -static void omap_gpio_init_context(struct gpio_bank *p) {}
> +static inline void omap_gpio_init_context(struct gpio_bank *p) {}
> #endif
>
> static const struct dev_pm_ops gpio_pm_ops = {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-05 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 15:59 [PATCH] gpio/omap: omap_gpio_init_context stub must be inline Arnd Bergmann
2013-05-31 15:59 ` Arnd Bergmann
2013-06-05 15:38 ` Tony Lindgren [this message]
2013-06-05 15:38 ` Tony Lindgren
2013-06-05 16:04 ` Santosh Shilimkar
2013-06-05 16:04 ` Santosh Shilimkar
2013-06-17 6:27 ` Linus Walleij
2013-06-17 6:27 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605153847.GV3331@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=jon-hunter@ti.com \
--cc=khilman@linaro.org \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.