From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.ml.walleij@gmail.com>,
linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tony Lindgren <tony@atomide.com>,
Kevin Hilman <khilman@linaro.org>
Subject: Re: [PATCH] gpio/omap: omap_gpio_init_context stub must be inline
Date: Wed, 5 Jun 2013 12:04:27 -0400 [thread overview]
Message-ID: <51AF618B.9090605@ti.com> (raw)
In-Reply-To: <2942784.trumtc2GjZ@wuerfel>
On Friday 31 May 2013 11:59 AM, Arnd Bergmann wrote:
> The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised"
> has caused a new warning for omap1_defconfig:
>
> drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function]
> static void omap_gpio_init_context(struct gpio_bank *p) {}
> ^
>
> The solution is to mark the stub function as 'static inline' so
> it gets left out of the build when unused.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio/omap: omap_gpio_init_context stub must be inline
Date: Wed, 5 Jun 2013 12:04:27 -0400 [thread overview]
Message-ID: <51AF618B.9090605@ti.com> (raw)
In-Reply-To: <2942784.trumtc2GjZ@wuerfel>
On Friday 31 May 2013 11:59 AM, Arnd Bergmann wrote:
> The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised"
> has caused a new warning for omap1_defconfig:
>
> drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function]
> static void omap_gpio_init_context(struct gpio_bank *p) {}
> ^
>
> The solution is to mark the stub function as 'static inline' so
> it gets left out of the build when unused.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2013-06-05 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 15:59 [PATCH] gpio/omap: omap_gpio_init_context stub must be inline Arnd Bergmann
2013-05-31 15:59 ` Arnd Bergmann
2013-06-05 15:38 ` Tony Lindgren
2013-06-05 15:38 ` Tony Lindgren
2013-06-05 16:04 ` Santosh Shilimkar [this message]
2013-06-05 16:04 ` Santosh Shilimkar
2013-06-17 6:27 ` Linus Walleij
2013-06-17 6:27 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF618B.9090605@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=arnd@arndb.de \
--cc=khilman@linaro.org \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.