From: Tony Lindgren <tony@atomide.com>
To: Sricharan R <r.sricharan@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
Paul Walmsley <paul@pwsan.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
rnayak@ti.com, b-cousson@ti.com, t-kristo@ti.com, ambresh@ti.com
Subject: Re: [PATCH V2 14/14] ARM: OMAP4: hwmod data: Clean up the data file
Date: Sat, 8 Jun 2013 09:57:20 -0700 [thread overview]
Message-ID: <20130608165719.GT3331@atomide.com> (raw)
In-Reply-To: <51B35FCB.5010801@ti.com>
* Sricharan R <r.sricharan@ti.com> [130608 09:52]:
> On Saturday 08 June 2013 12:14 AM, Santosh Shilimkar wrote:
> > On Friday 07 June 2013 02:37 PM, Tony Lindgren wrote:
> >>
> >> Looking at the diff output with and without, it seems to be that the
> >> DMA channels won't get configured.
> >>
> > That should work since DMA engine changes are in mainline and the
> > DMA channel information is already in DT.
> >
> The issue is that mmc, spi drivers try to get the 'dma' request number from
> get_platform_resource, which fails if hwmod has not populated the data.
>
> There are patches already from Balaji [1] for hsmmc, Matt Porter [2] mcspi
> for adapting the drivers for Dma engine. Dma engine gets the data from DT.
>
> [1] http://comments.gmane.org/gmane.linux.kernel.mmc/20378
> [2] http://www.spinics.net/lists/linux-omap/msg87634.html
>
> [1] is already in mmc-next for 3.10 branch.
>
> Then one more patch for spi [3] is required for completing this. This is similar
> to the patch done for mmc to skip the get_platform_resource call in case of DT.
>
> [3] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg90112.html
OK thanks for looking into that. Once those driver changes hit
mainline, please send a follow-up patch to remove the spi and
mmc entries.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 14/14] ARM: OMAP4: hwmod data: Clean up the data file
Date: Sat, 8 Jun 2013 09:57:20 -0700 [thread overview]
Message-ID: <20130608165719.GT3331@atomide.com> (raw)
In-Reply-To: <51B35FCB.5010801@ti.com>
* Sricharan R <r.sricharan@ti.com> [130608 09:52]:
> On Saturday 08 June 2013 12:14 AM, Santosh Shilimkar wrote:
> > On Friday 07 June 2013 02:37 PM, Tony Lindgren wrote:
> >>
> >> Looking at the diff output with and without, it seems to be that the
> >> DMA channels won't get configured.
> >>
> > That should work since DMA engine changes are in mainline and the
> > DMA channel information is already in DT.
> >
> The issue is that mmc, spi drivers try to get the 'dma' request number from
> get_platform_resource, which fails if hwmod has not populated the data.
>
> There are patches already from Balaji [1] for hsmmc, Matt Porter [2] mcspi
> for adapting the drivers for Dma engine. Dma engine gets the data from DT.
>
> [1] http://comments.gmane.org/gmane.linux.kernel.mmc/20378
> [2] http://www.spinics.net/lists/linux-omap/msg87634.html
>
> [1] is already in mmc-next for 3.10 branch.
>
> Then one more patch for spi [3] is required for completing this. This is similar
> to the patch done for mmc to skip the get_platform_resource call in case of DT.
>
> [3] http://www.mail-archive.com/linux-omap at vger.kernel.org/msg90112.html
OK thanks for looking into that. Once those driver changes hit
mainline, please send a follow-up patch to remove the spi and
mmc entries.
Regards,
Tony
next prev parent reply other threads:[~2013-06-08 16:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 11:56 [PATCH V2 14/14] ARM: OMAP4: hwmod data: Clean up the data file Sricharan R
2013-06-07 11:56 ` Sricharan R
2013-06-07 12:32 ` Paul Walmsley
2013-06-07 12:32 ` Paul Walmsley
2013-06-07 16:29 ` Tony Lindgren
2013-06-07 16:29 ` Tony Lindgren
2013-06-07 17:50 ` Tony Lindgren
2013-06-07 17:50 ` Tony Lindgren
2013-06-07 18:10 ` Paul Walmsley
2013-06-07 18:10 ` Paul Walmsley
2013-06-07 18:14 ` Santosh Shilimkar
2013-06-07 18:14 ` Santosh Shilimkar
2013-06-07 18:37 ` Tony Lindgren
2013-06-07 18:37 ` Tony Lindgren
2013-06-07 18:14 ` Santosh Shilimkar
2013-06-07 18:14 ` Santosh Shilimkar
2013-06-07 18:37 ` Tony Lindgren
2013-06-07 18:37 ` Tony Lindgren
2013-06-07 18:44 ` Santosh Shilimkar
2013-06-07 18:44 ` Santosh Shilimkar
2013-06-08 16:46 ` Sricharan R
2013-06-08 16:46 ` Sricharan R
2013-06-08 16:57 ` Tony Lindgren [this message]
2013-06-08 16:57 ` Tony Lindgren
2013-06-08 17:21 ` Shilimkar, Santosh
2013-06-08 17:21 ` Shilimkar, Santosh
2013-06-08 17:42 ` Tony Lindgren
2013-06-08 17:42 ` Tony Lindgren
2013-06-10 10:38 ` Tomi Valkeinen
2013-06-10 10:38 ` Tomi Valkeinen
2013-06-10 14:14 ` Tony Lindgren
2013-06-10 14:14 ` Tony Lindgren
2013-06-11 7:42 ` Tomi Valkeinen
2013-06-11 7:42 ` Tomi Valkeinen
2013-06-12 13:54 ` Tony Lindgren
2013-06-12 13:54 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130608165719.GT3331@atomide.com \
--to=tony@atomide.com \
--cc=ambresh@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=r.sricharan@ti.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.