All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@iki.fi>
To: Tony Lindgren <tony@atomide.com>
Cc: Paul Walmsley <paul@pwsan.com>, Sricharan R <r.sricharan@ti.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	santosh.shilimkar@ti.com, rnayak@ti.com, b-cousson@ti.com,
	t-kristo@ti.com, ambresh@ti.com
Subject: Re: [PATCH V2 14/14] ARM: OMAP4: hwmod data: Clean up the data file
Date: Mon, 10 Jun 2013 13:38:30 +0300	[thread overview]
Message-ID: <51B5ACA6.2010101@iki.fi> (raw)
In-Reply-To: <20130607175005.GB3331@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]

On 07/06/13 20:50, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [130607 09:35]:
>> * Paul Walmsley <paul@pwsan.com> [130607 05:38]:
>>> On Fri, 7 Jun 2013, Sricharan R wrote:
>>>
>>>> - The IO resource information like dma request lines, irq number and
>>>>   ocp address space can be populated via dt blob. So such data is stripped
>>>>   from OMAP4 SOC hwmod data file.
>>>>
>>>> - The devices which are still missing the device tree bindings,
>>>>   address space entries are not removed yet. When such devices add
>>>>   the dt bindings, respective address space data can be deleted.
>>>>
>>>> - Also other unnecessary hwmods like firewalls are removed as a part of this.
>>>>   Since emif was getting registered only because of this firewalls links,
>>>>   the mpu->emif direct link is added now.
>>>>
>>>> The above update, results in reduction of about ~1650 lines of code.
>>>>
>>>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>> Signed-off-by: Sricharan R <r.sricharan@ti.com>
>>>
>>> Acked-by: Paul Walmsley <paul@pwsan.com>
>>>
>>> Can't test this one since I don't have an OMAP4 DT config set up in the testbed
>>> yet.  Maybe will add that to the testbed after the v3.10 release.
>>
>> OK thanks, applying into omap-for-v3.11/cleanup.
> 
> I had to undo the following parts to avoid regressions on omap4sdp.
> Can you please follow up on fixing the related issues so the fixup
> won't be needed?
> 
> Seems to work now the same way as earlier for both omap4sdp and blaze
> es, except for DSS, which seems to be a separate issue as posted by
> Tomi. Pushed out now to omap-for-v3.11/cleanup.

What issue do you refer to?

DSS does not have DT bindings, and removing DSS from hwmod data will
break DSS for omap4.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@iki.fi (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 14/14] ARM: OMAP4: hwmod data: Clean up the data file
Date: Mon, 10 Jun 2013 13:38:30 +0300	[thread overview]
Message-ID: <51B5ACA6.2010101@iki.fi> (raw)
In-Reply-To: <20130607175005.GB3331@atomide.com>

On 07/06/13 20:50, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [130607 09:35]:
>> * Paul Walmsley <paul@pwsan.com> [130607 05:38]:
>>> On Fri, 7 Jun 2013, Sricharan R wrote:
>>>
>>>> - The IO resource information like dma request lines, irq number and
>>>>   ocp address space can be populated via dt blob. So such data is stripped
>>>>   from OMAP4 SOC hwmod data file.
>>>>
>>>> - The devices which are still missing the device tree bindings,
>>>>   address space entries are not removed yet. When such devices add
>>>>   the dt bindings, respective address space data can be deleted.
>>>>
>>>> - Also other unnecessary hwmods like firewalls are removed as a part of this.
>>>>   Since emif was getting registered only because of this firewalls links,
>>>>   the mpu->emif direct link is added now.
>>>>
>>>> The above update, results in reduction of about ~1650 lines of code.
>>>>
>>>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>> Signed-off-by: Sricharan R <r.sricharan@ti.com>
>>>
>>> Acked-by: Paul Walmsley <paul@pwsan.com>
>>>
>>> Can't test this one since I don't have an OMAP4 DT config set up in the testbed
>>> yet.  Maybe will add that to the testbed after the v3.10 release.
>>
>> OK thanks, applying into omap-for-v3.11/cleanup.
> 
> I had to undo the following parts to avoid regressions on omap4sdp.
> Can you please follow up on fixing the related issues so the fixup
> won't be needed?
> 
> Seems to work now the same way as earlier for both omap4sdp and blaze
> es, except for DSS, which seems to be a separate issue as posted by
> Tomi. Pushed out now to omap-for-v3.11/cleanup.

What issue do you refer to?

DSS does not have DT bindings, and removing DSS from hwmod data will
break DSS for omap4.

 Tomi


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130610/57a915d0/attachment.sig>

  parent reply	other threads:[~2013-06-10 10:38 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07 11:56 [PATCH V2 14/14] ARM: OMAP4: hwmod data: Clean up the data file Sricharan R
2013-06-07 11:56 ` Sricharan R
2013-06-07 12:32 ` Paul Walmsley
2013-06-07 12:32   ` Paul Walmsley
2013-06-07 16:29   ` Tony Lindgren
2013-06-07 16:29     ` Tony Lindgren
2013-06-07 17:50     ` Tony Lindgren
2013-06-07 17:50       ` Tony Lindgren
2013-06-07 18:10       ` Paul Walmsley
2013-06-07 18:10         ` Paul Walmsley
2013-06-07 18:14         ` Santosh Shilimkar
2013-06-07 18:14           ` Santosh Shilimkar
2013-06-07 18:37           ` Tony Lindgren
2013-06-07 18:37             ` Tony Lindgren
2013-06-07 18:14       ` Santosh Shilimkar
2013-06-07 18:14         ` Santosh Shilimkar
2013-06-07 18:37         ` Tony Lindgren
2013-06-07 18:37           ` Tony Lindgren
2013-06-07 18:44           ` Santosh Shilimkar
2013-06-07 18:44             ` Santosh Shilimkar
2013-06-08 16:46             ` Sricharan R
2013-06-08 16:46               ` Sricharan R
2013-06-08 16:57               ` Tony Lindgren
2013-06-08 16:57                 ` Tony Lindgren
2013-06-08 17:21                 ` Shilimkar, Santosh
2013-06-08 17:21                   ` Shilimkar, Santosh
2013-06-08 17:42                   ` Tony Lindgren
2013-06-08 17:42                     ` Tony Lindgren
2013-06-10 10:38       ` Tomi Valkeinen [this message]
2013-06-10 10:38         ` Tomi Valkeinen
2013-06-10 14:14         ` Tony Lindgren
2013-06-10 14:14           ` Tony Lindgren
2013-06-11  7:42           ` Tomi Valkeinen
2013-06-11  7:42             ` Tomi Valkeinen
2013-06-12 13:54             ` Tony Lindgren
2013-06-12 13:54               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B5ACA6.2010101@iki.fi \
    --to=tomi.valkeinen@iki.fi \
    --cc=ambresh@ti.com \
    --cc=b-cousson@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=r.sricharan@ti.com \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.