From: Lee Jones <lee.jones@linaro.org>
To: Fabio Baltieri <fabio.baltieri@linaro.org>
Cc: Ola Lilja <ola.o.lilja@stericsson.com>,
alsa-devel@alsa-project.org,
Linus Walleij <linus.walleij@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 0/3] DMA fixes for ux500 ASoC driver
Date: Wed, 12 Jun 2013 11:48:52 +0100 [thread overview]
Message-ID: <20130612104852.GD4320@laptop> (raw)
In-Reply-To: <1371023879-21884-1-git-send-email-fabio.baltieri@linaro.org>
On Wed, 12 Jun 2013, Fabio Baltieri wrote:
> Hi Mark,
>
> The DMA driver used on ux500 has been recently reworked to make it
> device-tree capable, but the rework required to drop some "features",
> such as opportunistic channel allocation and hardcoded addresses, that
> the ASoC driver was relying upon.
>
> This series fixes the audio driver to make it work with the current
> dma40 implementation, and works fine even when booting with device-tree.
>
> Would you consider merging these for asoc/topic/ux500?
>
> Thanks,
> Fabio
>
>
> Fabio Baltieri (3):
> ASoC: ux500: Move DMA parameters into ux500_msp
> ASoC: ux500: Set DMA address during device init
> ASoC: ux500: Add DMA slave config prepare routine
>
> sound/soc/ux500/ux500_msp_dai.c | 11 ++++-------
> sound/soc/ux500/ux500_msp_dai.h | 2 --
> sound/soc/ux500/ux500_msp_i2s.c | 13 +++++++++----
> sound/soc/ux500/ux500_msp_i2s.h | 15 ++++++++-------
> sound/soc/ux500/ux500_pcm.c | 30 ++++++++++++++++++++++++++++++
> 5 files changed, 51 insertions(+), 20 deletions(-)
I don't see anything visually wrong with them, so as long as they work
for you, then you can apply my:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Fabio Baltieri <fabio.baltieri@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Ola Lilja <ola.o.lilja@stericsson.com>
Subject: Re: [PATCH 0/3] DMA fixes for ux500 ASoC driver
Date: Wed, 12 Jun 2013 11:48:52 +0100 [thread overview]
Message-ID: <20130612104852.GD4320@laptop> (raw)
In-Reply-To: <1371023879-21884-1-git-send-email-fabio.baltieri@linaro.org>
On Wed, 12 Jun 2013, Fabio Baltieri wrote:
> Hi Mark,
>
> The DMA driver used on ux500 has been recently reworked to make it
> device-tree capable, but the rework required to drop some "features",
> such as opportunistic channel allocation and hardcoded addresses, that
> the ASoC driver was relying upon.
>
> This series fixes the audio driver to make it work with the current
> dma40 implementation, and works fine even when booting with device-tree.
>
> Would you consider merging these for asoc/topic/ux500?
>
> Thanks,
> Fabio
>
>
> Fabio Baltieri (3):
> ASoC: ux500: Move DMA parameters into ux500_msp
> ASoC: ux500: Set DMA address during device init
> ASoC: ux500: Add DMA slave config prepare routine
>
> sound/soc/ux500/ux500_msp_dai.c | 11 ++++-------
> sound/soc/ux500/ux500_msp_dai.h | 2 --
> sound/soc/ux500/ux500_msp_i2s.c | 13 +++++++++----
> sound/soc/ux500/ux500_msp_i2s.h | 15 ++++++++-------
> sound/soc/ux500/ux500_pcm.c | 30 ++++++++++++++++++++++++++++++
> 5 files changed, 51 insertions(+), 20 deletions(-)
I don't see anything visually wrong with them, so as long as they work
for you, then you can apply my:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-06-12 10:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 7:57 [PATCH 0/3] DMA fixes for ux500 ASoC driver Fabio Baltieri
2013-06-12 7:57 ` [PATCH 1/3] ASoC: ux500: Move DMA parameters into ux500_msp Fabio Baltieri
2013-06-12 7:57 ` [PATCH 2/3] ASoC: ux500: Set DMA address during device init Fabio Baltieri
2013-06-12 7:57 ` [PATCH 3/3] ASoC: ux500: Add DMA slave config prepare routine Fabio Baltieri
2013-06-12 9:51 ` [PATCH 0/3] DMA fixes for ux500 ASoC driver Linus Walleij
2013-06-12 10:48 ` Lee Jones [this message]
2013-06-12 10:48 ` Lee Jones
2013-06-12 16:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612104852.GD4320@laptop \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.baltieri@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ola.o.lilja@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.