* [kvm-unit-test PATCH] kvmclock: serialize RDTSC
@ 2013-06-14 21:30 Marcelo Tosatti
2013-06-17 15:43 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Tosatti @ 2013-06-14 21:30 UTC (permalink / raw)
To: kvm-devel
Serialize RDTSC so its executed inside kvmclock_read
section.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=922285
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/x86/kvmclock.c b/x86/kvmclock.c
index 0624da3..5b831c5 100644
--- a/x86/kvmclock.c
+++ b/x86/kvmclock.c
@@ -177,10 +177,10 @@ cycle_t pvclock_clocksource_read(struct pvclock_vcpu_time_info *src)
do {
version = pvclock_get_time_values(&shadow, src);
- barrier();
+ mb();
offset = pvclock_get_nsec_offset(&shadow);
ret = shadow.system_timestamp + offset;
- barrier();
+ mb();
} while (version != src->version);
if ((valid_flags & PVCLOCK_RAW_CYCLE_BIT) ||
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [kvm-unit-test PATCH] kvmclock: serialize RDTSC
2013-06-14 21:30 [kvm-unit-test PATCH] kvmclock: serialize RDTSC Marcelo Tosatti
@ 2013-06-17 15:43 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2013-06-17 15:43 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: kvm-devel
Il 14/06/2013 23:30, Marcelo Tosatti ha scritto:
>
> Serialize RDTSC so its executed inside kvmclock_read
> section.
>
> Fixes https://bugzilla.redhat.com/show_bug.cgi?id=922285
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/x86/kvmclock.c b/x86/kvmclock.c
> index 0624da3..5b831c5 100644
> --- a/x86/kvmclock.c
> +++ b/x86/kvmclock.c
> @@ -177,10 +177,10 @@ cycle_t pvclock_clocksource_read(struct pvclock_vcpu_time_info *src)
>
> do {
> version = pvclock_get_time_values(&shadow, src);
> - barrier();
> + mb();
> offset = pvclock_get_nsec_offset(&shadow);
> ret = shadow.system_timestamp + offset;
> - barrier();
> + mb();
> } while (version != src->version);
>
> if ((valid_flags & PVCLOCK_RAW_CYCLE_BIT) ||
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Applied, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-17 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-14 21:30 [kvm-unit-test PATCH] kvmclock: serialize RDTSC Marcelo Tosatti
2013-06-17 15:43 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.